Giter Club home page Giter Club logo

Comments (9)

TomasVotruba avatar TomasVotruba commented on June 26, 2024 1

@Perf Let's do the 2 Symfony methods at the moment. I'll think about the service-ones later, if really needed.
Thank you

from rector.

Perf avatar Perf commented on June 26, 2024 1

You are welcome, guys!
Just one question - when it's going to be released?

from rector.

TomasVotruba avatar TomasVotruba commented on June 26, 2024 1

We're waiting for more bug fixes to collect.
I think by the end of this week we'll make a release.

At the moment you can use dev-main branch to get early access 😉

from rector.

samsonasik avatar samsonasik commented on June 26, 2024

@Perf could you create a patch PR for it at https://github.com/rectorphp/rector-src/blob/f680a070335ee796de19b25a98c2d4ac172b6fe8/src/Configuration/RectorConfigBuilder.php#L27 ?, should be add 4 methods:

  • withSymfonyContainerXml()
  • withSymfonyContainerPhp()
  • withSingleton()
  • withAlias()

thank you.

from rector.

Perf avatar Perf commented on June 26, 2024

@samsonasik done!
rectorphp/rector-src#5524

from rector.

TomasVotruba avatar TomasVotruba commented on June 26, 2024

Thanks 👍

What are aliases needed for? RectorConfigBuilder should not duplicate full containers features, so we have only relevant methods to autocomplete by IDE.

from rector.

Perf avatar Perf commented on June 26, 2024

@TomasVotruba, actually, I am not so confident about requested withSingletons and withAliases.
If these needs to be removed from PR, please let me know.

from rector.

Perf avatar Perf commented on June 26, 2024

@TomasVotruba done!

from rector.

TomasVotruba avatar TomasVotruba commented on June 26, 2024

Closing as merged, thank you @Perf 👍

from rector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.