Comments (9)
@Perf Let's do the 2 Symfony methods at the moment. I'll think about the service-ones later, if really needed.
Thank you
from rector.
You are welcome, guys!
Just one question - when it's going to be released?
from rector.
We're waiting for more bug fixes to collect.
I think by the end of this week we'll make a release.
At the moment you can use dev-main
branch to get early access 😉
from rector.
@Perf could you create a patch PR for it at https://github.com/rectorphp/rector-src/blob/f680a070335ee796de19b25a98c2d4ac172b6fe8/src/Configuration/RectorConfigBuilder.php#L27 ?, should be add 4 methods:
- withSymfonyContainerXml()
- withSymfonyContainerPhp()
- withSingleton()
- withAlias()
thank you.
from rector.
@samsonasik done!
rectorphp/rector-src#5524
from rector.
Thanks 👍
What are aliases needed for? RectorConfigBuilder
should not duplicate full containers features, so we have only relevant methods to autocomplete by IDE.
from rector.
@TomasVotruba, actually, I am not so confident about requested withSingletons
and withAliases
.
If these needs to be removed from PR, please let me know.
from rector.
@TomasVotruba done!
from rector.
Closing as merged, thank you @Perf 👍
from rector.
Related Issues (20)
- LongArrayToShortArrayRector rule drops code formatting HOT 3
- Exception stop rector: Scope not available on "PhpParser\Node\Name\FullyQualified" node with parent node of "PhpParser\Node\Stmt\TraitUseAdaptation\Alias"... HOT 2
- Please add Rule for using !empty() with tenary operator HOT 1
- rector will remove else if, but is not correct HOT 4
- result cache will be cleared when using a process arg HOT 2
- When using `custom-rule` command, add rector test suite to PHPUnit config if one does not already exist HOT 1
- example of rector.php config file with all rules and sets included but commented HOT 7
- [DX] Accept y[es] and n[o] for initial config generation HOT 1
- RectorConfigBuilder feedback HOT 5
- RemoveAlwaysTrueIfConditionRector remove functional condition HOT 1
- Error when using PHPStan bleeding edge HOT 5
- Unneeded brackets in variable declaration HOT 1
- Remove "/vendor" from Rector paths and run again. HOT 6
- Incorrect behavior of LocallyCalledStaticMethodToNonStaticRector on call via static:: of other method from static method
- Incorrect behavior of StringExtensionToConfigBuilderRector HOT 2
- AddOverrideAttributeToOverriddenMethodsRector adds Override attribute to methods implementing interface HOT 6
- Incorrect behavior of CompleteDynamicPropertiesRector
- Incorrect behavior of RemoveParentCallWithoutParentRector HOT 5
- System error: "Node "PhpParser\Node\Expr\FuncCall" with is missing scope required for scope refresh HOT 1
- Bad behavior of DirNameFileConstantToDirConstantRector HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rector.