Giter Club home page Giter Club logo

Comments (19)

bradrn avatar bradrn commented on May 15, 2024

Actually, it seems that I was a bit hasty in my last try. It turns out that if you wait a bit longer and ignore the errors, the Playground works just fine, including the live code update. There's still lots of errors though; it would be nice to get rid of them. There's also still the problem of the unix dependency which prevents Windows compilation; is there any reason why that cannot be removed?

from reanimate.

bradrn avatar bradrn commented on May 15, 2024

Well, I've done a bit of digging, and it looks like most of the 'errors' above were just normal messages which I misinterpreted as errors. (Suggestion: rephrase these messages to make this more obvious so other people don't make that same mistake.) However, there are some genuine problems on Windows:

  • Unused unix dependency prevents Windows compilation. Fix: remove dependency, since it doesn't appear to be doing anything.
  • Browser isn't opening on Windows. Fix: use the open-browser package, or add "start" (the Windows command) to Reanimate.Driver.openBrowser.
  • Weird errors with DeleteFile and runInteractiveProcess (see above for exact error messages). Fix: I'm really not sure, actually. I think it's a problem with a dependency (possibly fsnotify), not with reanimate itself.

from reanimate.

bradrn avatar bradrn commented on May 15, 2024

Since #2 has been merged the HEAD of reanimate now compiles and works on Windows. However, the weird file errors are still there, so I won't close this issue just yet.

from reanimate.

lemmih avatar lemmih commented on May 15, 2024

Do you know why the errors happen? Is it something we can test for?

from reanimate.

lemmih avatar lemmih commented on May 15, 2024

For me, it happens when I reload the browser window but not when changes are detected via fsnotify. No idea why this is so, though.

from reanimate.

lemmih avatar lemmih commented on May 15, 2024

Hi @bradrn. I've fixed a few race conditions in the driver and now everything works smoothly for me on Windows. If it also works for you then I'd like to close this issue.

from reanimate.

bradrn avatar bradrn commented on May 15, 2024

Hi @lemmih, thanks so much for fixing this! Unfortunately I don’t have enough time just right now to test it, but in a few hours when I get home I will definitely try it out.

from reanimate.

lemmih avatar lemmih commented on May 15, 2024

Sigh, I spoke too early. I still see the same errors.

from reanimate.

lemmih avatar lemmih commented on May 15, 2024

Ok, now I've fixed the last issues (I think). Everything works as well on Windows as it does on Linux for me. Code reloads, refreshing the browser, latex output, etc.

from reanimate.

bradrn avatar bradrn commented on May 15, 2024

Ok, now I've fixed the last issues (I think). Everything works as well on Windows as it does on Linux for me. Code reloads, refreshing the browser, latex output, etc.

Sounds good @lemmih! I finally have enough time to test this (it’s compiling as I write), so will inform you if it works for me.

Out of curiosity, in which commits did you fix the issue?

from reanimate.

lemmih avatar lemmih commented on May 15, 2024

2298fca#diff-3aca47243ba1ee857817d88ba75931b2L48

Reusing the same temporary directory for compilations messed things up for some reason. Using a separate directory for each compilation fixed the errors for me.

from reanimate.

bradrn avatar bradrn commented on May 15, 2024

That’s odd. Do you have any idea why reusing the same directory would have caused those issues?

from reanimate.

lemmih avatar lemmih commented on May 15, 2024

Nope, it wasn't a problem on Linux or Mac. And it's particularly weird that GHC would create an empty binary but not give any error message or error return value.

from reanimate.

bradrn avatar bradrn commented on May 15, 2024

I’ve just tried the latest version and can confirm that the DeleteFile and runInteractiveProcess errors are gone! However, I still get terminateProcess: permission denied (Permission denied) errors, even when I run as administrator.

from reanimate.

lemmih avatar lemmih commented on May 15, 2024

That last error is harmless. I think it happens because it tries to terminate a process which has already been terminated.

from reanimate.

bradrn avatar bradrn commented on May 15, 2024

That last error is harmless.

I know, but it’s not too good an impression if you’re trying out this library for the first time…

I think it happens because it tries to terminate a process which has already been terminated.

It’s possible. I think it happens when I close a tab, but I will have to investigate more before saying anything definitively.

from reanimate.

bradrn avatar bradrn commented on May 15, 2024

Well, I can’t reproduce that error again. I still have no idea what caused it.

from reanimate.

lemmih avatar lemmih commented on May 15, 2024

Everything looks to be solved. Closing issue.

from reanimate.

bradrn avatar bradrn commented on May 15, 2024

That’s fine @lemmih.

from reanimate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.