Comments (8)
@bemcdonnell and @goanpeca GitHub is complicated for the uninitiated developer regardless of the branching model adopted by the project. If the branching model adopted is not documented then of course there will be confusion. That said, you are doing the work, so you get to choose the branching model. I would recommend documenting it.
I am committed to working here at OWA, but the headache of keeping track of the US EPA repo isn't going to go away. You need to accommodate it in your plans.
OR we can use the name develop instead of master if this makes the model clearer.
I think what @goanpeca proposes above is a hybrid solution. Basically, do what you want to do, just do it on develop
instead of master
. That will leave master
free for the bothersome tracking of the EPA's repo. I second @goanpeca idea. That sounds like a solution to me.
from stormwater-management-model.
I agree with @bemcdonnell, the current model is leading and will lead to more issues (plus we don't have anything documented!) the usual model is:
master: keeps the latest developments (5.2.0 in this case)
named branches: are kept for stable releases that need patching, e.g. 5.1.x would be such branch.
When we make the first 5.2 release we will create a new branch 5.2.x and do patch fixes there and so on and so on. Any fixes on lower versions (if still supported) are bubbled up to master to keep everything in sync, so if there is a hotfix (patch) on 5.1.17... those changes would be merged against 5.1.x, then on 5.2.x we would merged with 5.1.x to capture those fixes (and solve any merge conflicts) then on master we would merge with 5.2.x and fix any conflicts. This way everything remains in sync from bottom to top.
So all the toolkit effort should actually be going to master and we should have a new branch for patches on 5.1.x release.
The added headache is keeping track of the USEAP repo, but if we need to keep track of that, we should use a branch different from master (if the original idea was to use master for that).
And I suggest we stop using the branch dev
. The dev/develop
branches make more sense when developing a SAS cause we have alpha, beta and production instances. This is clearly not the case here. OR we can use the name develop
instead of master
if this makes the model clearer.
from stormwater-management-model.
The added headache is keeping track of the USEAP repo, but if we need to keep track of that, we should use a branch different from master (if the original idea was to use master for that)
May no longer be a concern :-)
from stormwater-management-model.
@bemcdonnell @michaeltryby lets have a meeting to settle the workflow a bit more? then we can get it on "paper" :-)
from stormwater-management-model.
i like this one: https://git-scm.com/book/en/v2/Git-Branching-Branching-Workflows
from stormwater-management-model.
i like this one: https://git-scm.com/book/en/v2/Git-Branching-Branching-Workflows
Yeah, that is fine and kinda what we are doing, but we need to incorporate the stable version (current release) branch 5.1.x
in this case and 5.2.x
in some months
from stormwater-management-model.
@goanpeca and @michaeltryby,
I added a page to the wiki on the Branching Model
from stormwater-management-model.
Oh yes, and I updated the relevant branches. This repo now defaults to the develop
branch.
from stormwater-management-model.
Related Issues (20)
- Add CITATION Reference File HOT 2
- Proposal to relicense OWA SWMM from MIT to CC BY 4.0 HOT 7
- Why dataframe exports only last value of iteration to csv? HOT 1
- Update .rpt and .out header to indicate different codebase HOT 13
- Update flow direction in API function HOT 6
- Flow and Routing Stats Bug HOT 9
- Add toolkit function for build info in json format HOT 1
- Addition of new Subarea Runoff methods HOT 11
- Bring in USEPA SWMM v5.1.15 HOT 1
- Link and Node Pollutant Function Call HOT 2
- Update .rpt text to indicate OWA SWMM codebase HOT 14
- CI Maintenance: Windows-2016 Actions runner scheduled for depreciation HOT 1
- Subcatchment runoff is missing LID runoff rate
- Expanding SWMM toolkitapi to allow modification of more properties HOT 4
- Documentation needs to be updated to reflect the current state of code base HOT 2
- Merge in USEPA-v5.2.2 into repo HOT 1
- Toolkit API Versioning
- Node volume constraints when coupling with 2D models HOT 1
- Incorrect Error Thrown to PySWMM
- Possible set start/end date calculation precision issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stormwater-management-model.