Comments (13)
I configured cmake to create the following each time the build system is generated:
/*
* version.h - SWMM version information
*
* Created on: Nov 2, 2021
*
* Author: Michael E. Tryby
* US EPA - ORD/CESER
*/
#ifndef VERSION_H_
#define VERSION_H_
#define VERSION "5.1.14"
#define VERSION_MAJOR 5
#define VERSION_MINOR 1
#define VERSION_PATCH 14
#define GIT_HASH "8e4610611ae3d61edac53518dc65d67108b400f3"
#define BUILD_ID "2021-11-02T14:23:31"
#endif /* VERSION_H_ */
The variables get updated automatically. What do y'all think?
from stormwater-management-model.
@jennwuu , are our build numbers always going to match the EPA build numbers? My recommendation is to be more explicit about the build numbers. So something along the lines of the example below. A little bit of a mouthful right now but my larger point is to be more explicit.
OWA STORM WATER MANAGEMENT MODEL - VERSION 5.1 (Build 5.1.14) ADAPTED FROM EPASWMM 5.1.14 SOURCE
----------------------------------------------------------------------------------------------------------------------------------
from stormwater-management-model.
I had the same thought as @cbuahin. I was thinking we should have a version.h
file that contains the version, commit number, and the build number in it. We could configure cmake to create the file automatically when generating the build system.
from stormwater-management-model.
@jennwuu I am very supportive of this change. It will consistently conflict with USEPA-SWMM as we merge in changes, however. However, this isn't a big deal
from stormwater-management-model.
@jennwuu I agree with @cbuahin. It is better to be explicit with the build numbers. I propose we use EPA first and then specify the version of OWA after that, as the EPA solver is still the base of the OWA version.
EPA STORM WATER MANAGEMENT MODEL - VERSION 5.1 (Build 5.1.14/OWA Build 5.1.15)
----------------------------------------------------------------------------------------------------------------------------------
from stormwater-management-model.
@cbuahin finished up the PR. Have a look!
from stormwater-management-model.
@cbuahin finished up the PR. Have a look!
I'll put it on my agenda to review first thing tomorrow. Nice work on this.
from stormwater-management-model.
That looks really good! What about text format for .rpt file?
from stormwater-management-model.
Theses or similar information should be in the header of the SWMM5 rpt file
from stormwater-management-model.
@jennwuu I will create a PR for this. Once we are comfortable with how it works and the variables it creates we can use it to refactor the report file, CLI, and CI build/test.
from stormwater-management-model.
@michaeltryby , I recall writing functions to grab the version number when I merged 5.1.14. We should probably make sure we are not duplicating things there.
from stormwater-management-model.
@michaeltryby Following up status of .rpt file, should I make a separate ticket for .rpt for the version numbers?
from stormwater-management-model.
@jennwuu, go ahead and make a new ticket for RPT
from stormwater-management-model.
Related Issues (20)
- Add CITATION Reference File HOT 2
- Proposal to relicense OWA SWMM from MIT to CC BY 4.0 HOT 7
- Why dataframe exports only last value of iteration to csv? HOT 1
- Update flow direction in API function HOT 6
- Flow and Routing Stats Bug HOT 9
- Add toolkit function for build info in json format HOT 1
- Addition of new Subarea Runoff methods HOT 11
- Bring in USEPA SWMM v5.1.15 HOT 1
- Link and Node Pollutant Function Call HOT 2
- Update .rpt text to indicate OWA SWMM codebase HOT 14
- CI Maintenance: Windows-2016 Actions runner scheduled for depreciation HOT 1
- Subcatchment runoff is missing LID runoff rate
- Expanding SWMM toolkitapi to allow modification of more properties HOT 4
- Documentation needs to be updated to reflect the current state of code base HOT 2
- Merge in USEPA-v5.2.2 into repo HOT 1
- Toolkit API Versioning
- Node volume constraints when coupling with 2D models HOT 1
- Incorrect Error Thrown to PySWMM
- Possible set start/end date calculation precision issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stormwater-management-model.