Giter Club home page Giter Club logo

Comments (9)

michaeltryby avatar michaeltryby commented on September 4, 2024 3

So the problem is that stats are being computed and written to the report because that's how the program was originally conceived. Now that there is an API and we want more flexible access to stats we need to decouple stats computation from report writing.

from stormwater-management-model.

jennwuu avatar jennwuu commented on September 4, 2024

I am looking for review regarding this issue. Looking to see if anyone can review the proposed solution here: jennwuu@a0aa668

from stormwater-management-model.

jennwuu avatar jennwuu commented on September 4, 2024

@bemcdonnell @michaeltryby @abhiramm7 @cbuahin I want to follow up this issue and see if anyone can review the proposed solution above.

from stormwater-management-model.

bemcdonnell avatar bemcdonnell commented on September 4, 2024

@jennwuu, I can review it today. I think the approach is to create a simple function to compute stats and both the api can call it (while the model is running) and the rpt writer can call it. But your PR could be more. You could look at see all the values being calculated in the rpt writer and make them all functions.

from stormwater-management-model.

abhiramm7 avatar abhiramm7 commented on September 4, 2024

@jennwuu did we address this issue? Looks like you had a fix ready to go.

from stormwater-management-model.

jennwuu avatar jennwuu commented on September 4, 2024

@abhiramm7 No, I proposed a solution, but it needs review.

from stormwater-management-model.

jennwuu avatar jennwuu commented on September 4, 2024

jennwuu@a0aa668

from stormwater-management-model.

abhiramm7 avatar abhiramm7 commented on September 4, 2024

cool thanks @jennwuu :)

from stormwater-management-model.

karosc avatar karosc commented on September 4, 2024

merged @jennwuu 's commit in @354. Thanks for the great work!

from stormwater-management-model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.