Comments (9)
So the problem is that stats are being computed and written to the report because that's how the program was originally conceived. Now that there is an API and we want more flexible access to stats we need to decouple stats computation from report writing.
from stormwater-management-model.
I am looking for review regarding this issue. Looking to see if anyone can review the proposed solution here: jennwuu@a0aa668
from stormwater-management-model.
@bemcdonnell @michaeltryby @abhiramm7 @cbuahin I want to follow up this issue and see if anyone can review the proposed solution above.
from stormwater-management-model.
@jennwuu, I can review it today. I think the approach is to create a simple function to compute stats and both the api can call it (while the model is running) and the rpt writer can call it. But your PR could be more. You could look at see all the values being calculated in the rpt writer and make them all functions.
from stormwater-management-model.
@jennwuu did we address this issue? Looks like you had a fix ready to go.
from stormwater-management-model.
@abhiramm7 No, I proposed a solution, but it needs review.
from stormwater-management-model.
from stormwater-management-model.
cool thanks @jennwuu :)
from stormwater-management-model.
merged @jennwuu 's commit in @354. Thanks for the great work!
from stormwater-management-model.
Related Issues (20)
- Add CITATION Reference File HOT 2
- Proposal to relicense OWA SWMM from MIT to CC BY 4.0 HOT 7
- Why dataframe exports only last value of iteration to csv? HOT 1
- Update .rpt and .out header to indicate different codebase HOT 13
- Update flow direction in API function HOT 6
- Add toolkit function for build info in json format HOT 1
- Addition of new Subarea Runoff methods HOT 11
- Bring in USEPA SWMM v5.1.15 HOT 1
- Link and Node Pollutant Function Call HOT 2
- Update .rpt text to indicate OWA SWMM codebase HOT 14
- CI Maintenance: Windows-2016 Actions runner scheduled for depreciation HOT 1
- Subcatchment runoff is missing LID runoff rate
- Expanding SWMM toolkitapi to allow modification of more properties HOT 4
- Documentation needs to be updated to reflect the current state of code base HOT 2
- Merge in USEPA-v5.2.2 into repo HOT 1
- Toolkit API Versioning
- Node volume constraints when coupling with 2D models HOT 1
- Incorrect Error Thrown to PySWMM
- Possible set start/end date calculation precision issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stormwater-management-model.