Giter Club home page Giter Club logo

Comments (4)

ArthurSens avatar ArthurSens commented on June 20, 2024

We could easily fix that by adding an option for adding extra labels/annotations in the Alerting spec

from pyrra.

metalmatze avatar metalmatze commented on June 20, 2024

Oh, that's an interesting point with the URLs. I haven't run into this myself yet.
I guess in that case your proposal makes sense.

The original reasoning for having them as CRD labels is to make filtering via kubectl get slo -l pyrra.dev/team=backend possible. I wonder how much usage that feature has in the first place.

from pyrra.

ArthurSens avatar ArthurSens commented on June 20, 2024

The original reasoning for having them as CRD labels is to make filtering via kubectl get slo -l pyrra.dev/team=backend possible. I wonder how much usage that feature has in the first place.

I usually search for SLOs using ArgoCD UI or Pyrra UI. I haven't used kubectl in a while, honestly 😬. If people rely on that feature, I guess they could keep their labels there, but I understand the duplicated effort to keep labels in sync in two different places.

I can totally understand that I don't represent all users! Do you see other people requesting the original use case?

from pyrra.

PabloPie avatar PabloPie commented on June 20, 2024

In our case, we use annotations for runbooks and dashboard links, they are also propagated when prefixed with pyrra.dev/ and allow for much larger texts. I think labels are meant to be used more to filter, which is not something we usually require for those links.

from pyrra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.