Comments (4)
We could easily fix that by adding an option for adding extra labels/annotations in the Alerting spec
from pyrra.
Oh, that's an interesting point with the URLs. I haven't run into this myself yet.
I guess in that case your proposal makes sense.
The original reasoning for having them as CRD labels is to make filtering via kubectl get slo -l pyrra.dev/team=backend
possible. I wonder how much usage that feature has in the first place.
from pyrra.
The original reasoning for having them as CRD labels is to make filtering via
kubectl get slo -l pyrra.dev/team=backend
possible. I wonder how much usage that feature has in the first place.
I usually search for SLOs using ArgoCD UI or Pyrra UI. I haven't used kubectl in a while, honestly 😬. If people rely on that feature, I guess they could keep their labels there, but I understand the duplicated effort to keep labels in sync in two different places.
I can totally understand that I don't represent all users! Do you see other people requesting the original use case?
from pyrra.
In our case, we use annotations for runbooks and dashboard links, they are also propagated when prefixed with pyrra.dev/
and allow for much larger texts. I think labels are meant to be used more to filter, which is not something we usually require for those links.
from pyrra.
Related Issues (20)
- 0s burnrate generated HOT 3
- local dev issue HOT 2
- SLO publishing workflow HOT 1
- Errors with v0.7.0-rc.1 HOT 3
- [Pyrra v0.7.0] Missing changes in CRD? HOT 3
- Run CI check for generate examples
- Using Grafana UI with standard generated prometheus rules HOT 2
- One faulty slo disables all slos HOT 1
- Setting dashboard view longer than 4w HOT 1
- Time based error budget (feature request) HOT 1
- Help deploying Grafana Dashboards using Generic Rules HOT 7
- Proposal for Saturation SLO HOT 2
- pyrra_errors_total inaccurate in Grafana dashboard
- New line inserted in the generated files HOT 1
- Rules are not valid with latest prometheus-operator HOT 2
- Invalid prometheus rule when trying to add grouping to SLO HOT 7
- Generic rules causes incorrect graphs in grafana HOT 3
- Customizable reload URI HOT 1
- Reconcile errors "prometheus rule not found" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyrra.