Giter Club home page Giter Club logo

Comments (7)

metalmatze avatar metalmatze commented on June 17, 2024 3

Hey everyone. Sorry for the late response...
The PR is now merged.
We can cut a patch release for this if people are interested. In that case I'll cherry pick the PR's to the release branch.

from pyrra.

BradErz avatar BradErz commented on June 17, 2024

We are also having the same problem, not sure if you figured this out?

from pyrra.

LukeDAtkinson avatar LukeDAtkinson commented on June 17, 2024

Went digging in the controller code a bit and I have a hypothesis as to what is going wrong:

pyrra/kubernetes/controllers/servicelevelobjective.go

Line 246 in 3763769

// ignore these rules
Here in the code, if we have got an ErrGroupingUnsupported error back from the objective.GenericRules() function, then the comment suggests we should be ignoring the returned rule. However, it looks like the returned rules are still appended to rule.Groups regardless.

Digging further into the objective.GenericRules() function, it looks like if you have grouping in a ratio indicator, then it returns an empty RuleGroup and an ErrGroupingUnsupported error: https://github.com/pyrra-dev/pyrra/blob/3763769724b2618bfff643ff8820357d9651c637/slo/rules.go#L1169C26-L1169C26

I suspect the this empty RuleGroup is being added to the PrometheusRule spec and failing validation due to not having a name property set. Could anyone with more familiarity with the code confirm/deny if this seems likely?

from pyrra.

ingvarch avatar ingvarch commented on June 17, 2024

Hi there! Any updates ?

from pyrra.

mgs255 avatar mgs255 commented on June 17, 2024

A patch release would be really welcome - thank you! 🙇

from pyrra.

metalmatze avatar metalmatze commented on June 17, 2024

v0.7.4 has been released.

from pyrra.

sepulworld avatar sepulworld commented on June 17, 2024

v0.7.4 has been released.

do you mean 0.7.3? I don't see a 0.7.4 release yet

from pyrra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.