Comments (7)
Hey everyone. Sorry for the late response...
The PR is now merged.
We can cut a patch release for this if people are interested. In that case I'll cherry pick the PR's to the release branch.
from pyrra.
We are also having the same problem, not sure if you figured this out?
from pyrra.
Went digging in the controller code a bit and I have a hypothesis as to what is going wrong:
Here in the code, if we have got anErrGroupingUnsupported
error back from the objective.GenericRules()
function, then the comment suggests we should be ignoring the returned rule. However, it looks like the returned rules are still appended to rule.Groups
regardless.
Digging further into the objective.GenericRules()
function, it looks like if you have grouping in a ratio indicator, then it returns an empty RuleGroup and an ErrGroupingUnsupported error: https://github.com/pyrra-dev/pyrra/blob/3763769724b2618bfff643ff8820357d9651c637/slo/rules.go#L1169C26-L1169C26
I suspect the this empty RuleGroup is being added to the PrometheusRule spec and failing validation due to not having a name property set. Could anyone with more familiarity with the code confirm/deny if this seems likely?
from pyrra.
Hi there! Any updates ?
from pyrra.
A patch release would be really welcome - thank you! 🙇
from pyrra.
v0.7.4 has been released.
from pyrra.
v0.7.4 has been released.
do you mean 0.7.3? I don't see a 0.7.4 release yet
from pyrra.
Related Issues (20)
- Error Budget showing strange skew HOT 1
- Surface Pyrra version HOT 1
- Feature - Add link to Pyrra in alerts HOT 1
- Grafana Dashboard HOT 5
- Feature: Allow customisation of warning/critical alert levels HOT 2
- [Feature] Link Grafana Dashboard to Pyrra equivalent HOT 1
- Environment variables support in Pyrra HOT 1
- SLO dependencies / levels / hierarchy HOT 3
- Custom PropagationLabelsPrefix HOT 2
- No data Budget and Availability HOT 1
- Doubt - Error Budget
- Issue when showing some SLOs (white screen) HOT 1
- Pyrra causes instability of Prometheus HOT 1
- Fix typo in Kubernetes example readme HOT 1
- Allow providing an error rate query rather than a error count query HOT 1
- ConfigMapMode not working with option --config-map-mode=true
- Webhook Panic on Unexpected Parser Expression HOT 2
- Allow Prometheus Rules to Publish Rules to Azure Managed Prometheus HOT 3
- Grafana Alerting & Mimir support HOT 8
- Latency format incorrect when using milliseconds HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyrra.