Comments (3)
This is because morty parses files individually, doing macro resolution of each, not taking into account the previously parsed files and the defines contained within. I attempted to make use of some of the parser's features to collect all the defines from the parsed files, but I haven't properly tested or investigated any further issues. You can give the following branch a shot if you like: https://github.com/pulp-platform/morty/tree/collect_defines
Let me know if this works, or if you encounter any issues with this change.
from morty.
Again, that was fast 😍 ! That should fix it, however it's difficult to estimate whether it would break backward compatibility.
You're the best placed to decide!
Thanks!
from morty.
I will likely modify this feature to be enabled/disabled with a flag before merging to ensure compatibility isn't broken.
from morty.
Related Issues (20)
- Fix missing re-naming of optional endlable
- Comments after string literals
- Add anchor symbols to paragraph headings
- Also rename interfaces
- We are currently using `signal` as prefix in the ID of all `VarItems`. I wonder if we should change that to `var` to be closer to the language.
- Not directly related, but all those `<h3 ...` strings are very similar and their construction should be refactored IMO.
- Parsing fails for defines as keys in case statement HOT 3
- Issue with parsing some generate statements HOT 2
- Re-enable minimization and keeping comments HOT 1
- defines and compile order HOT 1
- Improve error handling
- Multiple declarations of the same module builds a bad module graph
- $fatal guarded by synopsys translate_off/on` causes parse error HOT 3
- Morty panic HOT 2
- [RFC]: Parse documentation HOT 1
- Parse error on generate begin HOT 3
- Morty stack overflow HOT 14
- Only re-name defined modules HOT 1
- Parse error of SystemVerilog set membership operator 'inside'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from morty.