Giter Club home page Giter Club logo

Comments (4)

PsiAphex avatar PsiAphex commented on July 28, 2024

AFAIK, Pickups.opts is the full perms including inherited perms, realOpts is the real perms without inherition and thats what is being stored in the database, realOpts contains default over rides + channel defaults, we can update inherited properties by directly just changing it in cache and then implement some changeProperties method in Pickups which updates channel specific overrides

from pugbot.

PsiAphex avatar PsiAphex commented on July 28, 2024

But I suppose we could stop uploading defaults to the DB and leave channel settings empty on creation and assign defaults to the channel on local initialization

from pugbot.

TheUltimateKeval avatar TheUltimateKeval commented on July 28, 2024

AFAIK, Pickups.opts is the full perms including inherited perms, realOpts is the real perms without inherition and thats what is being stored in the database, realOpts contains default over rides + channel defaults, we can update inherited properties by directly just changing it in cache and then implement some changeProperties method in Pickups which updates channel specific overrides

But that feels janky and inconsistent. Having a better system for storing and accessing options is necessary.

from pugbot.

PsiAphex avatar PsiAphex commented on July 28, 2024

Ok then second option seems better to me, using getters feels a bit unnatural for me, but if you feel that it would be better you can do that

from pugbot.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.