Comments (4)
AFAIK, Pickups.opts is the full perms including inherited perms, realOpts is the real perms without inherition and thats what is being stored in the database, realOpts contains default over rides + channel defaults, we can update inherited properties by directly just changing it in cache and then implement some changeProperties method in Pickups which updates channel specific overrides
from pugbot.
But I suppose we could stop uploading defaults to the DB and leave channel settings empty on creation and assign defaults to the channel on local initialization
from pugbot.
AFAIK, Pickups.opts is the full perms including inherited perms, realOpts is the real perms without inherition and thats what is being stored in the database, realOpts contains default over rides + channel defaults, we can update inherited properties by directly just changing it in cache and then implement some changeProperties method in Pickups which updates channel specific overrides
But that feels janky and inconsistent. Having a better system for storing and accessing options is necessary.
from pugbot.
Ok then second option seems better to me, using getters feels a bit unnatural for me, but if you feel that it would be better you can do that
from pugbot.
Related Issues (17)
- Attaching the Pickups structure directly to the CommandoClient HOT 18
- Ranked and ELO
- Global Elo
- Implement more functionalities through classes - Something to work on before moving to ELO HOT 1
- Pickups dont inherit default options from Parent Channel
- Map isn't stored to the Game instance
- Help command is dead
- Manual Picking
- Allow Offline and Offline purging
- Player can join same game more than once HOT 1
- Admin and Moderation commands
- Add more QOL to add/remove commands HOT 2
- Maps HOT 1
- Need to work out a more consistent and reliable method to import and pass structures, util functions and handlers HOT 4
- Rework command parsing
- Match IDs are broken again HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pugbot.