Attaching the Pickups structure directly to the CommandoClient about pugbot HOT 18 CLOSED

commit #2882270 fixed it, review and close issue @TheUltimateKeval @PsiAphex

from pugbot.

It should work

from pugbot.

Since the client instance is already in all the different scopes it would also reduce memory usage?

from pugbot.

Its better if we implement these base reforms before extending its functionalities. And yes it'll help performance wise as well I guess.

from pugbot.

Alright, you can assign yourself to the issue if you want to implement or I will do it tomorrow

from pugbot.

I'll try to work on it but I'm still trying to get familiar with the code.

from pugbot.

Updating cache is also a very tedious task, if we change game/pickups info and forget to update cache it may not propagate to the entire cache, keep in mind if you are implementing

from pugbot.

Feel free to change style or whatever

from pugbot.

Erm I have not yet understood the complete concept of having a cache. I think its irrelevant though if we're accessing everything through the Client.

from pugbot.

The cache is for storing mutable data like active games, once the bot restarts all that data will be dropped

from pugbot.

to store in database we can call the deserialize function in pickups

from pugbot.

What exactly do pickups and pickupsCount objects store in the cache?

from pugbot.

pickups store game info pickupsCount stores the id for the channel, since all match ids in a channel must be unique

from pugbot.

There is probably a better way to implement counting

from pugbot.

Ehm I am finding it difficult to relate the names with the function.

So pickups stores instances of Pickups instances and pickupsCount stores the number of active Games in a pickups channel both mapped with their channel names.

from pugbot.

Aight I'll try to get into this more tomorrow. Gotta sleep right now.

from pugbot.

Right see ya! Pickups stores Objects mapped by channel id, Which have arrays of Pickups instances, pickupsCount simply stores an Object mapped by channel IDs with an integer 'count' which is incremented each time a new Game is made, this count also serves as the unique ID of each Game/Match

from pugbot.

Pero

from pugbot.