Network connection error checking works only with get method about restclient HOT 16 CLOSED

I've found a work around about this, you can catch the error in res variable

  RestClient.Post<Info>(rh, new Info(), (err, res, body) =>
    {
        if (!String.IsNullOrEmpty(res.error))
        {
            Debug.Log("Errorr : " + res.error);

from restclient.

@jdnichollsc i've just tried running the latest release and run into this
https://github.com/proyecto26/RestClient/releases/download/1.2.1/RestClient.unitypackage

from restclient.

@jdnichollsc I've tried that with some public APIs as well as my own ASP.NET Core project. Looks like checking the error will be OK.

from restclient.

ok, let me fix that issue at night

from restclient.

@czuczorf ohh can you share a screenshot? I had not thought about that situation 😅

from restclient.

Thanks

from restclient.

yes, let me check in a moment. Thanks for notify this issue 👍

from restclient.

Hi, Thanks a lot for updating the package, but I believe the issue is still present, Get() is showing the no internet error but Post() is not showing the same. Post method is only showing the success. You can check the screenshot attached.
I have produced this bug with :

1. After Disconnect the wifi
2. Change the APIs address to something else

from restclient.

Excellent, I need to add that validation with the promises 👍

from restclient.

I think the solution is modifying the following lines to validate if an error exist:

• https://github.com/proyecto26/RestClient/blob/master/src/Proyecto26.RestClient/HttpActions/HttpBase.cs#L17
• https://github.com/proyecto26/RestClient/blob/master/src/Proyecto26.RestClient/HttpActions/HttpBase.cs#L34
• https://github.com/proyecto26/RestClient/blob/master/src/Proyecto26.RestClient/HttpActions/HttpDelete.cs#L16

Example:

if (request.isDone && String.IsNullOrEmpty(res.error))

What do you think @czuczorf?
Let me know to publish a new release with that change :)

from restclient.

Hey. I accidentally wrote yesterday from the second, old account, I'm sorry.
Do you think it is enough to just check the res.error? May be also check for the status code to be "2xx"? What do you think @jdnichollsc?

from restclient.

@davidorbelian I don't know if validating by the status code is the correct way, because exist a lot of different status, or if validating by a range would be better... What do you think? 🤔

from restclient.

@jdnichollsc I will check today after work if checking error value is enough and post the results here.

from restclient.

@davidorbelian thanks for your help! 👍

from restclient.

Fixing this issue with the version 1.2.2

from restclient.

@czuczorf @davidorbelian @itsharshdeep check the last release and let me know! 👍 https://github.com/proyecto26/RestClient/releases/tag/1.2.2

from restclient.