Comments (15)
Hi @jdnichollsc , I've just forked the project and I'm changing things here and there to make it work for me.
I haven't thought about adding more things to RequestException, but I agree that this is a great solution, and probably the best the way, what I've done now was just a quick fix, (I'm appending the code and desc the to error description, hehe).
One other change that I've made to this class was here https://github.com/proyecto26/RestClient/blob/master/src/Proyecto26.RestClient/HttpActions/HttpBase.cs#L17
Instead of
if (request.isDone && string.IsNullOrEmpty(request.error))
I'm using
if (request.isDone && !request.isNetworkError)
That way no changes need to be made to RequestException and only if there's a NetworkError an error will be returned.
BUT this may not desired by everyone, I don't know.
What you think?
from restclient.
Humm, I think that's is pretty great actually, and it will be fine for everyone.
from restclient.
@caneva20 sounds great, let me publish a new version of the plugin this weekend
Thanks for your help!
from restclient.
@jdnichollsc I should thank you for the attention.
Thanks!
from restclient.
@caneva20 please validate the changes before generating a new release e287f94
Thanks in advance 👍
from restclient.
Hi @jdnichollsc I've tested it with my server and it works fine, now I can have more control over each request and do what I need.
One thing that you may have not realized is that the demo does not work anymore, 'cause you renamed some variables, quickly you'll fix it, I'm saying just to let you know.
Thanks man! :)
from restclient.
Hello @jdnichollsc, I've updated my comment there, I just don't know how to update the "on previous version 1.2.2" and since I'm already here I would like to suggest one more thing, but that time is pretty simple, as you might have noticed, I don't like JSONUtility and the .BodyString
solved this problem, I would like to ask you to add a section to the README with others JSON Serializers, and how it would be used/implemented (I can send you my wrapper), that way will be easier to newcomers.
I can recommend two libs that work nicely with Unity:
- JSON .NET For Unity - The one I use
- OdinSerializer - The one used by Odin
But that is really up to you. :)
from restclient.
Hi @caneva20, thanks for report this issue!
Check the validations that I have https://github.com/proyecto26/RestClient/blob/master/src/Proyecto26.RestClient/HttpActions/HttpBase.cs#L17
What do you think? What changes do you propose to improve the RequestException class?
Other option is change the access of the Unity Request to be public to get the info https://github.com/proyecto26/RestClient/blob/master/src/Proyecto26.RestClient/Utils/RequestHelper.cs#L67
RequestHelper requestToken;
RestClient.Get($"{URL}/test").Then(response => {
//Do something
requestToken = new RequestHelper {
url = $"{URL}/token"
};
return RestClient.Post(requestToken, model)
}).Then(response => {
switch (response.statusCode) {
case 200:
break;
}
}).Finally(() => {
//Do something
}).Catch(error => {
if (requestToken != null) {
//requestToken.request => To get the info of the Unity request if it is public
}
Debug.LogException(error);
})
I prefer to add more information to the RequestException, but let me know what you think
Best Regards, Nicholls
from restclient.
Ok, what you think if we add a new property called IgnoreHttpException from RequestHelper class to ignore http exceptions?
Thanks @caneva20
from restclient.
Any comment from the unity store is really appreciated! 👍 https://assetstore.unity.com/packages/tools/network/rest-client-for-unity-102501
from restclient.
Hi @caneva20 :)
Ohh yes, let me fix the demo, review the code once again and publish a new release!
Thanks for the help
from restclient.
@caneva20 thanks for your comments from the Unity store! 👍
A moment ago, I reverted all the changes from the master branch to create a pull request to compare with the previous version of the plugin, I'm going to add a property BodyString
from the RequestHelper
class to send your JSON if you want to use other tool to serialize the code, so let me do that change and improve the code, any comments are really apreciated
Pull request => #18
Regards, Nicholls
from restclient.
Check my friend the files modified, thanks for your help and patience! 💯 https://github.com/proyecto26/RestClient/pull/18/files
from restclient.
@caneva20 any good comment from the Unity Asset Store would be really appreciated :)
from restclient.
ohh any pull request is welcome my friend!
from restclient.
Related Issues (20)
- 404 Error when using DELETE HOT 3
- has no meta file, but it's in an immutable folder. The asset will be ignored. HOT 4
- can not debug anything/not getting any debugs in console after adding this package HOT 1
- Update promises to be awaitable using `async`/`await` HOT 6
- Missing Meta files
- Empty response on RestClient GET, works with curl HOT 1
- Can this library be called by hololens2 HOT 4
- Can't send post request after Update to latest version HOT 2
- Lost reference to script in GET
- Can't use GET in hololens build
- Running multiple POST requests using Promise.ThenAll returns an IEnumerable of ResponseHelper objects, not all of them returned Data
- How can I add mode in proyecto26? HOT 1
- Post not working on WebGL compilation HOT 3
- Can i use this asset to make my offline game multiplayer? HOT 1
- Default seralizer JsonUtility cannot serialize records HOT 1
- Why not async/await? HOT 2
- Using RestClient as a dependency in a unity package HOT 1
- Error while downloading file from Firebase Storage
- Specified cast is not valid. HOT 1
- Crashlytics reporting constant Fatal Exception: java.lang.Exception
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from restclient.