polymerx / polymer-skeleton Goto Github PK

Hi, if i run

yarn dev

i get this error on chrome

We should change the browsers target for no-module build to:

browsers: [
  '> 1%',
  'last 2 versions',
  'Firefox ESR'
]

I'm thinking if we should bundle a router with the Skeleton. And this should be related to #13 since the routing should be handle by Redux.

@LasaleFamine can u say me, why i dont see my changes in Develop if i pull?

Sorry for the issue, but i dont know how i can contact you :D

Yep, but maybe in a month or two. Will be also the v2 of the Polymer Skeleton. 🚀

Need to work on a base template like the Polymer Starter Kit (but better 😄 ).

We can also check:

• polymer-news (latest case study published by Polymer team)
• polymer-shop

Of course I'm talkin about some basic configuration of the index.html and few more files, but of course we have a different structure and designers 💯

Reminder example:

...
     contentBase: path.resolve('src'),
     publicPath: '/assets/js',
     compress: true,
     port: 3100
     watchContentBase: true,
     watchOptions: {
		ignored: 'assets/**/**/*.js',
  		poll: true
	},
	hot: true,
	inline: true
...

Also set reload to false for BrowserSync.

This space is dedicated to discussions about the logo. This weekend i will work on this.

Currently we are running the first webpack.config.js and then the webpack-module-build.config.js. This is actually wrong because the main Webpack configuration file generates Service Workers with Workbox and the module.bundle.js should be already generated before running Workbox. The command should be fixed within the package.json:

From

"build": "NODE_ENV=production webpack --optimize-minimize",
"postbuild": "NODE_ENV=production webpack --config webpack-module-build.config.js",

To

"prebuild": "NODE_ENV=production webpack --config webpack-module-build.config.js",
"build": "NODE_ENV=production webpack --optimize-minimize",

IMPORTANT: The CopyWebpackPlugin should be also moved from the webpack.config.js to the webpack-module-build.config.js.

Need to investigate about update of webcomponents-loader.js and Polymer 3

Sample HTML template for 1.0.0-beta release

https://github.com/webpackmonitor/webpackmonitor

https://github.com/FormidableLabs/webpack-dashboard

XO:

PolymerX Skeleton (you can change the color and also the text):

Github Release (or Tag?):

Others? What do you think? @equinusocio

Like some Vaadin elements or Ikonograph or others.

webpack-browser-plugin 🦄

dist folder? On .gitignore?

@LasaleFamine Maybe we can consider to provide another directory beside the components one:

• Components (For modular components)
• Wrappers (for containers components like views, pages, components-containers)

What do you think?

.includes() is incorrect right now.

We should implement the CommonsChunkPlugin.

PolymerRedux

@LasaleFamine Do you think that we can add eslint and stylelint configuration files?

cc: @equinusocio

Offline caching with Service Worker

@LasaleFamine do you also plan to add docker here?

Running yarn dev:module for develop on browsers that supports type=module script import is causing an error due a known bug of webpack: webpack/webpack#5776

Wait for a fix that should come soon, I hope, we can now disable the hot reload during the development.

ERROR: webpackHotUpdate

WORKAROUND: remove the --hot flag from https://github.com/PolymerX/polymer-skeleton/blob/master/package.json#L15

unfetch

Merge polymer-3 branch to master.

We can now switch again from the lite to the loader polyfill, with the correct loading of the bundle.

The problem in Firefox and Edge we had were related to a problem of loading. More info: webcomponents/webcomponentsjs#846 (comment)

We can consider to add a changelog generator?

• conventional-changelog-cli

https://github.com/kevlened/copy-webpack-plugin
https://github.com/johnagan/clean-webpack-plugin

And remove statics scripts.

I'm using Mac OS El Capitan, latest Chrome, yarn goes without any issues in terminal and no errors so far.
In Chrome console I got next errors:

(index):70 Error during service worker registration: DOMException: Only secure origins are allowed (see: https://goo.gl/Y0ZkNV).
(anonymous) @ (index):70
Promise rejected (async)
(anonymous) @ (index):69
(index):86 GET http://0.0.0.0:3000/module.bundle.js net::ERR_ABORTED

I'd changed localhost address and set enable to allow-insecure-localhost flag.
What is wrong with my installation?
Thanks!

This https://github.com/PolymerX/polymer-skeleton/blob/master/src/assets/icons/manifest.json should be inside the root.

Need to implement the postcss-loader with webpack during development and also for the production build.

We should add the logic for the "Add to home screen" alert.

• Update app manifest
• Update pwa assets

Workbox

Related: #15

We should add SVG files on the glob path of Workbox:

new WorkboxPlugin({
    globDirectory: outputPath,
    globPatterns: ['**/*.{html,js,css,svg,png}'],
    swDest: join(outputPath, 'sw.js')
 }),