Giter Club home page Giter Club logo

burstcoin-mobile's Introduction

Get it on Google Play

Burstcoin Mobile Wallet

This repository holds the source code for the Burstcoin mobile wallet developed by the PoC-Consortium. Documentation: https://poc-consortium.github.io/burstcoin-mobile/

Building

Prerequisities

Android

iOS

If you setup your environment correctly, follow these steps:

  1. Clone this repository

    git clone [email protected]:poc-consortium/burstcoin-mobile-wallet.git
    
  2. Install all used npm packages

    npm install
    
  3. Run the application on your virtual device

    Android

    tns run android
    

    iOS

    tns run ios
    

Features

  • Watch only addresses
  • Currency conversion
  • Client-side encryption and decryption
  • Encrypted / Unencrypted transaction messages
  • Contact book
  • QR code support
  • Secure and easy passphrase generation
  • Support for over 15 languages
  • Support for over 30 currencies

Translators 💕

  • bmxakias
  • bold
  • Brabantian
  • fabry1999
  • FLEGI
  • Gadrah
  • HajimeYamanaka
  • Hiro Inu
  • Leass
  • NullNomad
  • Quibus
  • RedFury
  • SolidLiquid
  • umbrellacorp03
  • westhorn

Bugs and feature requests

Please post bugs/problems into the issue section of this repository. This is the only place guaranteeing your issue is recognized and resolved quickly. Feature requests can also be posted.

burstcoin-mobile's People

Contributors

andylamgot avatar cgebe avatar rico666 avatar umbrellacorp03 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

burstcoin-mobile's Issues

Feature Request: Extended QR Code Scanning

As User I want to scan a QR-Code e.g. from an payment website which contains the receivers address as well as the amount of coins he would like to receive so that i don't need to type in the amount manually.

Acceptance Criteria:

  • Scanning of QR codes containing BURST address
  • Scanning of QR code containing BURST address and amount of coins
  • Scanning of QR code containing BURST address, amount of coins and text message (e.g. Reference No. of an shop)

Patch Notes 0.1.1

  • Added translations for the following languages: ...
  • Added the following currencies for conversion: "AUD", "BRL", "CAD", "CHF", "CLP", "CNY", "CZK", "DKK", "EUR", "GBP", "HKD", "HUF", "IDR", "ILS", "INR", "JPY", "KRW", "MXN", "MYR", "NOK", "NZD", "PHP", "PKR", "PLN", "RUB", "SEK", "SGD", "THB", "TRY", "TWD", "ZAR"
  • PIN codes now have to be exactly 6 digits and not more. Previously pin codes with more than 6 digits were allowed
  • Fixed a bug which caused a reset of the node address when app was restarted
  • (TODO) Swap over balance bug cgebe/burstcoin-wallet#9 --> #27

Make a "credits" button/submenu

From @rico666 on September 15, 2017 15:27

In "Settings" - somewhere - make a button to show credits for contributors.

So testers, translators etc. get their fair share of fame.

Copied from original issue: PoC-Consortium/burstcoin-mobile-doc#18

Assets don't appear on the app

If you have multiple feature requests, please create a seperate issue for each individual feature.
If you report a bug, please use the following template!

Specifications

  • Application Version:0.2.2
  • Android Version:9
  • Device:HUAWAY mate10 pro

Expected Behavior

Actual Behavior & Screenshots
Screenshot_20200307_064712_org icewave burstcoinwallet

Please confirm attached data .

Backup Passphrase

From @LithMage on October 14, 2017 17:8

Mobile Wallet needs to have a "Backup Passphrase" feature. It could be done by generating specific hashed link or just hash and sending it to user specified email.
I am using Exodus wallets functionality as an example (it works real well too):

  1. Log into wallet.
  2. Start Backup Process.
  3. Enter backups password/key (for obvious reasons).
  4. Enter backups password/key again (for obvious reasons).
  5. Send the hashed link/whaterver to user specified email.

Backup restore process
Enter the sent hash or if possible somehow link it as url that would open wallet app (would be harder to implement for desktop wallet but not impossible i think).

  1. Wallet requests Backups password/key
  2. if it checks out hash is decoded and passphrase added to app.

Copied from original issue: PoC-Consortium/burstcoin-mobile-doc#32

switchable backend wallet

Before we release on GP and attach to the MainNet, a way to switch the backend Wallet must be in place. I.e. that is a showstopper feature (without it, we should not release).

By the way, it would be very nice if even the published wallet had a way to still connect to the testnet (which should be easy achievable with the capability to switch "backend wallets")

Feature Request: Account Transaction Notifications

From @chadbaldwin on January 25, 2018 3:25

Im constantly checking my account to see if I've gotten any mining payouts.

I think a useful feature would be to have notifications from the wallet for deposits and withdrawals. Some potential sub features would be the ability to customize... Like notifications only for deposits, or, only notify for withdrawals larger than a certain size. Etc.

Copied from original issue: PoC-Consortium/burstcoin-mobile-doc#38

Use Fingerprint Sensor instead of PIN

From @rico666 on October 12, 2017 16:31

For devices that offer a Fingerprint sensor, allow the user to use that instead of a PIN.

Copied from original issue: PoC-Consortium/burstcoin-mobile-doc#31

Request - Dark Theme

From @darkdaze on September 28, 2017 22:30

Dark theme option - white screens are extremely bright in a dimly lit environment. I for one prefer a light theme, but after running a forum, I have found there are many people who prefer dark.

Copied from original issue: PoC-Consortium/burstcoin-mobile-doc#26

Naming accounts

From @Gadrah on September 20, 2017 1:2

I'm not sure if this has already been brought up. In doubt: having the possibility to rename your accounts would be a nice addition for several reasons:

  • People love to customize and appropriate things.
  • It would allow categorization on the accounts page. (e.g. a "groceries" account, a "saving" account...)
  • Burst blockchain allows account naming.
  • If people have a desktop wallet with a name set, they most likely would like keeping it when importing the account on mobile.

Copied from original issue: PoC-Consortium/burstcoin-mobile-doc#25

Deleted accounts should be gone

  • Application Version: 0.2.2
  • Android Version: 5.0.1
  • Device: GT-I9505 S4

Expected Behaviour
Deleted accounts should be gone

Actual Behaviour & Screenshots
after deleting the last account you see the expected the default home screen (to make or import an account). but then suddenly my last account (offline imported type) reappears.

Steps to Reproduce the Problem

  1. add 1 (or more) accounts. had a few 'offline imported' and 1 generated account on the phone.
  2. remove the accounts
  3. Wait a second and it jumps to the screen with QR code and balance, where only the last deleted account is suddenly back.

This is not a big problem for me at the moment. Encountered it while making tutorial screenshots.

Backend SSL cert expired

The cert of wallet.burst.cryptoguru.org seems to be invalid/expired. Refresh of balance/history results in an error.

Equip the wallet with an "optimum fee guesser"

The mobile wallet should suggest the optimum fee for a transaction to make sure - with sufficient confidence - that transaction gets incorporated in the next block (or into one of the next blocks) - certainly before the tx timeout runs out.

Having a fixed tx fee is problematic, because it may be too low in high traffic conditions and too high in low traffic times.

The guesser could look at the average fill of the past 10 blocks and use the median of transactions * FEE_QUANT for a good approximation of the optimum fee.

Swiping from "Balance" has dead area

From @rico666 on September 12, 2017 13:7

Specifications

  • Android Version: 7.0
  • Device: Moto G5

Expected Behavior

I should be able to swipe from the "Balance" screen to History.

Actual Behavior & Screenshots

The app ignores any swiping attempt as long as I am over the two lines that show the RS Address and the Balance. Because these are quite in the center, it looks as if the App was unresponsive.

Swiping over the QR area, or below (BTC / $) works.

Steps to Reproduce the Problem

  1. Go to Balance screen
  2. position your finger over the RS address
  3. try to swipe to History

Copied from original issue: PoC-Consortium/burstcoin-mobile-doc#9

Passphrase 'spaces' issue

I randomly generated passphrase on android wallet and wrote it down 'on paper' (No copy & paste function) , with the format and order provided . Account created and logged in successfully.

Later on, I get back to PC - Qbundle. I put in the same passphrase , login succeed, but the account address/ID is different, I found out that its a new account (new hash index i supposed).

Finally, i found out that I didn't key in 'spaces' between passphrase words, and there aren't any hints/settings to remind 'spaces' between words inside QBundle or android wallet. I guess some users would lose the account forever if they don't figure out 'spaces' issue, unless they choose 'create own passphrase' and set any phrase without spaces.

Please check that out and hope better ui/ux, i suppose most users like me are lazy and sometimes lose focus on details.

Cheers.

Thoughts about Load Balancing

What would happen if 500 000 people downloaded the wallet and tried to use it?

Our default backend wallet would crash. Ok, they could use alternatives, but that's a hassle.

I propose the backend wallet chosen by the user should actually be a list where the mobile wallet would perform a round-robin in case a wallet would be unresponsive.

While it may not be a problem now, I believe this has to be addressed better sooner than later (if we would run into scaling problems)

iOS Wallet issue when using tns run ios

When I follow instructions this is what I receive when attempting to run the iOS wallet ( I wanted to see the POC Consortium wallet):

OS: MacOS 10.13.4
Xcode: 9.3 (9E145)

Can provide further information if you want but here is output:

somethingUseful:~/GitHub/burstcoin-mobile$tns run ios

Support for Node.js 10.0.0 is not verified. This CLI might not install or run properly.

node[48101]: ../src/node_contextify.cc:631:static void node::contextify::ContextifyScript::New(const FunctionCallbackInfov8::Value &): Assertion `args[1]->IsString()' failed.
1: node::Abort() [/usr/local/bin/node]
2: node::Assert(char const* const () [4]) [/usr/local/bin/node]
3: node::contextify::ContextifyScript::New(v8::FunctionCallbackInfov8::Value const&) [/usr/local/bin/node]
4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo
) [/usr/local/bin/node]
5: v8::internal::MaybeHandlev8::internal::Object v8::internal::(anonymous namespace)::HandleApiCallHelper(v8::internal::Isolate*, v8::internal::Handlev8::internal::HeapObject, v8::internal::Handlev8::internal::HeapObject, v8::internal::Handlev8::internal::FunctionTemplateInfo, v8::internal::Handlev8::internal::Object, v8::internal::BuiltinArguments) [/usr/local/bin/node]
6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node]
7: 0x2b863c20427d
8: 0x2b863c20f755
9: 0x2b863c28bc20
10: 0x2b863c2144f7
11: 0x2b863c2144f7
Abort trap: 6

In-App purchase

Provide a way for the user to be able to buy a small amount of BURST via In-App purchase.

I'm thinking like 10 BURST for 0.99EUR

Of course these BURST are way more expensive than on exchanges, but we have to think about the the comfort should be worth it.

  • User does not need to beg for start-BURST
  • additional BURST acquisition channel
  • also some revenue

Currently people have to go through a tiresome pipeline when trying to get some Burst:

Fiat (bank) -> My main exchange -> bitcoin -> different exchange -> Burst -> MyWallet

In-App purchase could make that

Fiat (Google pay) -> Burst (in Wallet)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.