Add Homebrew formula about video-compare HOT 22 CLOSED

looks like it's now live! Homebrew/homebrew-core#119813 (comment) nice work

from video-compare.

Hey @thomasbachem,

So I just noticed the project made it to 80 stars. Feel free to re-run the audit check when you have time for it.

Cheers!

from video-compare.

Great, so the only thing that's missing is a new release :D

from video-compare.

I created the pull request for the Homebrew formula :)

from video-compare.

I've revived this at Homebrew/homebrew-core#119813. I'm a Ruby novice so not sure if I've correctly implemented the feedback on our test. Guess we'll see!

Another idea I had, but couldn't figure out how to do: is there any way we could programmatically pass through the CLI what the F command does, then check for presence of the saved PNG images?

from video-compare.

When I've PR'd in the past they wait for 2 reviews before merging, but indeed we're looking good!

from video-compare.

Hi @thomasbachem,

Glad to hear you find this utility useful!

And I'd be happy to help, of course. Let me get in contact with GitHub support and ask them to defork the project.

I'll let you know when the deforking has been done.

from video-compare.

Wow, that didn't take long. Big props to GitHub support!

The project is now deforked.

from video-compare.

Thanks, sadly Homebrew requires repositories to be more popular/active:

brew audit --new-formula video-compare
video-compare:
  * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
Error: 1 problem in 1 formula detected

So maybe at some point in the future :)

from video-compare.

Haha, yeah - let's spread the word!

from video-compare.

Thanks for looking into it, @thomasbachem.

from video-compare.

Oh, BTW... I'm going to make a change to get rid of the external font dependency.

from video-compare.

Oh, BTW... I'm going to make a change to get rid of the external font dependency.

OK, it's been fixed.

from video-compare.

Waiting on #14

from video-compare.

Waiting on #14

Thanks! Merged to the master branch just now.

from video-compare.

Great, so the only thing that's missing is a new release :D

Right you are, my friend! ;-)

20220412 has now been released.

from video-compare.

I created the pull request for the Homebrew formula :)

Thanks, much appreciated!

from video-compare.

Do we need some kind of pure CLI "test mode" option to satisfy the Homebrew formula requirements? It might be as simple as checking we are able to stream a pair of files via avformat and avcodec without opening the main UI window, then returning a string we can assert in the formula if all went well. Who does this sound to you?

I can look into it this weekend. Shouldn't be too hard to do.

from video-compare.

I've revived this at Homebrew/homebrew-core#119813. I'm a Ruby novice so not sure if I've correctly implemented the feedback on our test. Guess we'll see!

Great stuff! Thanks for your contribution, @unitof.

from video-compare.

It seems like your PR passed review. Excellent work guys!

from video-compare.

Callooh callay! Indeed today!

from video-compare.

So cool, thanks for reviving this, @unitof!

from video-compare.