Giter Club home page Giter Club logo

Comments (8)

c0494133d4 avatar c0494133d4 commented on May 29, 2024 1

I have confirmed that the filter works. Thank you.

from video-compare.

jonfryd avatar jonfryd commented on May 29, 2024

Hi @c0494133d4,

I've not been able to recreate the problem. Are you using the same FFmpeg libraries for both ffplay and video-compare?

from video-compare.

c0494133d4 avatar c0494133d4 commented on May 29, 2024

@jonfryd Please look into the 0.1s sample (GoPro -> HandBrake x265)

https://github.com/pixop/video-compare/assets/41767537/5cba3d42-e584-40b6-bb7a-f841dd217b4f
https://github.com/pixop/video-compare/assets/41767537/3a66e230-5d54-4514-86e6-847ac6932c33

They looks exactly the same within one player (QuickTime / ffplay / IINA), while the latter one is lightly darker than the first one in video-compare.

Out of topic problem: they looks different across different players.

from video-compare.

jonfryd avatar jonfryd commented on May 29, 2024

Thanks for submitting a short sample of both videos.

Screenshot 2023-11-16 at 07 51 03

I'm not sure what the problem is to be honest. The videos seem to be correctly displayed with the same brightness level on my 2017 iMac running the 20230807-github version of video-compare.

from video-compare.

jonfryd avatar jonfryd commented on May 29, 2024

Same observation on my Lenovo laptop with Windows 10, whether using the 20230807-github version or today's release of video-compare. The brightness level appears identical for both videos as far as I can tell.

It's a bit of a mystery to me why they appear different on your system, @c0494133d4. Have you discovered any clues yourself?

from video-compare.

c0494133d4 avatar c0494133d4 commented on May 29, 2024

No clues yet. Here are screenshots:

A
B

I am using the latest version of video-compare and ffmpeg from homebrew on a P3-gammut display (sRGB icc has also been tested).

from video-compare.

jonfryd avatar jonfryd commented on May 29, 2024

Thanks for sharing those screenshots. Clearly there is a difference in brightness level between the two videos when decoded on your system (but not on mine). You are using the standard FFmpeg HEVC software decoder (hevc), right?

from video-compare.

jonfryd avatar jonfryd commented on May 29, 2024

Hey @c0494133d4,

I'm able to reproduce the brightness problem by using the latest release and the videotoolbox HW decoder on video A:

./video-compare --left-hwaccel videotoolbox -d videoA.mp4 videoB.mp4

However, in this case it's actually video B (yuv420p) which is brighter than video A (yuvj420p) which contradicts your description of the issue above.

The problem disappears by converting the pixel format to e.g. yuv422p. This might work as a workaround for now:

./video-compare --left-hwaccel videotoolbox -l format=yuv422p -d videoA.mp4 videoB.mp4

With software decoding both videos still look exactly the same on my system.

Assuming the workaround works for you, as well, do you mind if we close this issue for now?

from video-compare.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.