phambatho / btnavigationdropdownmenu Goto Github PK

Hi,

Why is my first separator light (compared to your gif)? Also, how do I change the separator color altogether?

Thanks!

I have one ViewController in a NavigationController where the menu is not working. Other viewcontrollers are working as aspected. Not sure what happens yet but Reveal shows me this:

And the fix was to add the menuWrapper to the navigationController and not to the window (#251).

    // Add Menu View to container view
    //window.addSubview(self.menuWrapper) //COMMENT THIS
    self.navigationController?.view.addSubview(self.menuWrapper) //FIX

I tried to reproduce in a sample project but no luck, think my project changes or uses the keywindow.

Any idea? And does the fix seems to be ok?

How to set initial index ?

Hi, i an using two storyboards, one for iphone and one for ipad (this one is always in landscape). I`m changing line 218+ from BTNavigationDropDownMenu, checking if my UINavigationController has a parent UISplitViewController, and changing the menuWrapperBounds origin x based on the masterViewController (my menu) frame.

It worked, but i had to split my masterViewController size by 2 and i cant understand why this is needed, can you help me please?

the code:

 var menuWrapperBounds = window.bounds


        if let uISplitViewController = navigationController.parentViewController as? UISplitViewController {

            let splitWidth = uISplitViewController.viewControllers[0].view.bounds.size.width
            menuWrapperBounds.origin.x = splitWidth / 2 // why the /2 is needed?
           // menuWrapperBounds.size.width = menuWrapperBounds.size.width - splitWidth

        }

Without changing the width:

Chaging the width without the /2

Chaging the width with the /2

Hi just wanted to mention that in 6 and 5s i'm noticed that the title view is outside the bar

so I had to edit the line to be like this:
// Set frame
let frame = CGRectMake(0, 0, titleSize.width + (self.configuration.arrowPadding + self.configuration.arrowImage.size.width)*2, self.navigationController!.navigationBar.frame.height-12)

-12 at the end is my addition. Of course this is very lazy and can break in other layouts but anyway i felt i need to report this.

When your navigation controller is embedded inside a tab bar controller, the dropdown overlay doesn't appear overtop the tab bar.

So the update you just pushed for XCode 7.3 is not backwards compatible. I wished you'd have tagged it 0.3.1 or something.

Hello,

With an item array with 15 items it's not possible to select the last option.

self.menuView = BTNavigationDropdownMenu(navigationController: self.navigationController, title: items.first!, items: items)

It's a Bug or there are any way to fix that.

Thank you.

When there is more than a page of menu item i can't tap on the lasts because they are "hidden"

Looks like the fix for the old issue where the line "self.navigationController = UIApplication.sharedApplication().keyWindow?.rootViewController?.topMostViewController?.navigationController" was nil on init, was fixed by letting programmer pass in their own navigationController.

However, I'm noticing that the line "let window = UIApplication.sharedApplication().keyWindow!" crashes as well. In my app, there is nothing set to keyWindow.

Is there an easier way to add new items for the dropdown menu after it has been initialized?
Right now I'm recreating it but I'm experiencing crashes when doing this?

I can't get the drop down menu to work, it keeps crashing as soon as it starts loading. It crashes at the point where it creates the frame in the "init" function. I am using Xcode 6.4 with iOS 8.

Here's my code:

import UIKit
import CVCalendar
import BTNavigationDropdownMenu

class RosterViewController: UIViewController, UITableViewDelegate, UITableViewDataSource, UITextFieldDelegate {

@IBOutlet weak var menuButton:UIBarButtonItem!
@IBOutlet weak var tableView: UITableView!
@IBOutlet weak var calendarView: CVCalendarView!
@IBOutlet weak var menuView: CVCalendarMenuView!

var menuViewNav: BTNavigationDropdownMenu!

override func viewDidLoad() {
    super.viewDidLoad()

    tableView.delegate = self
    tableView.dataSource = self
    tableView.tableFooterView = UIView()

    let items = ["Most Popular", "Latest", "Trending", "Nearest", "Top Picks"]
    menuViewNav = BTNavigationDropdownMenu(title: "Hey", items: items)
    menuViewNav.didSelectItemAtIndexHandler = {(indexPath: Int) -> () in
        print("Did select item at index: \(indexPath)")
    }
    self.navigationItem.titleView = menuViewNav

    if self.revealViewController() != nil {
        menuButton.target = self.revealViewController()
        menuButton.action = "revealToggle:"
        self.view.addGestureRecognizer(self.revealViewController().panGestureRecognizer())
    }
}

let menuView = BTNavigationDropdownMenu(title: items.first!, items: items) get error

fatal error: unexpectedly found nil while unwrapping an Optional value

I am using the menu to send NSNotifications to a navigation controller, where selecting a cell chooses which view controller to navigate to. In order to make this possible, each view controller has it's own instance of BTNavigationDropdownMenu.

This means that navigating to a new view controller instantiates a new dropdown menu, so the checkmark is always on the first cell. I'd like to be able to manually select which cell has the checkmark.

Is this currently possible?

When setting the arrowImage after creating the menu, it never actually tries to set the menuArrow image view image field to the newly assigned image.

Also the size of the image is forced to being a weird aspect ratio of 12/7, seems like the arrow image icon frame should be square, makes it easier to get an icon into it without looking weird.

Thank you for this great menu. It works very well.

My only issue is I use it in "ViewController2". When the menu is displayed, the user can push the "back" button to unwind to "ViewController1", and the menu remains the displayed in "ViewController1"

It does not cause any crashes or generate errors/warnings. It just looks odd.

Thank You Again,
Paul

Maybe something I'm doing wrong, but I can't call BTNavigationDropdownMenu from my ViewController. Noob on here, so let me know what code you need to see to help diagnose.

If you have the menu on a secondary page that gets opened on nav, every time you visit it it adds a new child subview to window.

"menuWrapper" is private, so you can't get access to it to force cleanup.

Hi,

I am not able to add this on navigation rightBarButtonItem....

Thanks,
Ketul shah

I would like to check which item is selected in the menu.

Something like....

let p = self.navigationDropDown!.selectedIndex

I'm aware I could change the library directly - but I'm using Pods so would much prefer this was built into the library native.

Possible?

Cheers!

Awesome work!

But is it possible to toggle the dropdown by a uibutton outside of the navigation bar?

When you call updateItems after initialise;
for example items = [] in viewDidLoad and you make http request to get your items and fill items finally updateItems new filled items array.

I solve problem change this line at line 261

self?.setMenuTitle("\(items[indexPath])")
to
self?.setMenuTitle("\(self!.tableView.items[indexPath])")

no errors during compile or in editor but when you go to a view that trys to instantiate the menu...you get a run time error as follows:

Since i am totally new to Swift and Xcode, i do not know how to give any further information about errors such as logs. If i can help tell me what to do.

Thank you for sharing your code and expertise.

iOS 7 support would be nice.

Unable to set bounceOffset in most recent version.

"direct field offset for BTNavigationDropdownMenu.BTNavigationDropdownMenu.(configuration in _2FD11A7176F1278EC9F8CADD0C8AF5A3) : BTNavigationDropdownMenu.BTConfiguration"

Over and Over again facing this issue.Whenever trying to initialize this issue occures.

As it is, the control is using only one viewController. How would I use the control so that when i select a row in it, I instantiate another view controller. I'm doing it this way:

        ...
        print("Did select item at index: \(indexPath)")
        let vc = self.storyboard?.instantiateViewControllerWithIdentifier(self.items[indexPath])

        self.presentViewController(vc!, animated: true, completion: nil)
    }

and it does work. it brings up a vc with the identifier as is labelled in the storyboard except i lose the navigation bar along with the menu when i select any other viewController except the one that's embedded in a navigationController.

I've tried embedding all the VC's in their own navigationControllers but nothing.
I've tried copying all the 'menuView' code into each of the viewController's classes but I still don't get the menu when I select a different viewController.

Assist me please? *sorry if its kind of a noob question. I'm only just learning Swift. Thanks!

For many menu items, some are hidden, can not scroll up and touch down.
iOS 9.3 / iPhone6

Hi,

i create a function which will create the DropdownMenu.
Every time i run this function 2mb of ram will get lost.

if i open a view like in you example close it an reopen it 5-10mb of ram are lost.

hope you understand what i mean.

i think it has something to do with "closures and strong reference cycle",
but i didn´t find the error.

Thanks.

I opened up the sample project, and I had 9 errors and 1 warning. If you can fix them that would be greatly appreciated!

Hi,
can i keep navigation title static.
I need to keep it, even when i choose some item from dropdown.

Please make isShown property public and reachable, because sometimes you really need to know is menu open right now or not.

Hi,
i have found two issue for this fantastic DropDownMenu.

1. If the menu is opened and i rotate the device (from portrait to landscape) there are problems. If the menu is opened and i rotate the device (from landscape to portrait) the navigation bar disappears.

1. If the list contains many elements the scroll doesn't work

Thanks in advance.

Love this library. Been using it for a while now, but after upgrading cocoapods and reinstalling all the pods, I know am hitting a strange error. Nothing else has changed, but this is now the issue I'm seeing:

cell.checkmarkIcon.hidden = (indexPath.row == selectedIndexPath) ? false : true

Running XCode 7.3.1 and the latest BTNavigationDropdownMenu

Any idea why this is happening? It could certainly be me, but I haven't been able to solve it for some time. Thanks!

kane

@PhamBaTho Is there a way to close the menu programatically? When I press my rightBarButtonItem with the menu opens, it remains open, I would like to close it in my Action.

Thanks!

How do you add a custom view per? I want to add an image and button per menu row.

Something like...

let menuView = BTNavigationDropdownMenu()

let items = ["Foo", "Bar"]

override func viewDidLoad() {
     super.viewDidLoad()
     menuView = BTNavigationDropdownMenu(navigationController: self.navigationController, title: "Main Menu", items: items)
}

This would help with keeping the navigation title static, as the menuView could re-initialize in viewDidAppear()

What I want is adding an arrow at the top of the Menu.Just like this

But what I accomplish is this

So I've been looking a bit at this library and it does exactly what I need/want so I'd like to use it. However, I've noticed that it does not truncate labels that are too large. So for instance I can have a text like "this is a very long text and will most likely not fit" as a cell and it will just keep on going out of its bounds and run over the icon and through my navigationbar as well. Is there a way to prevent this?

Here is a print screen of what I'm describing

Dropdown view won't open when I press on the drop down button. It will only work when I tap the center of the text, which isn't where a user would instinctively tap.

When I click on arrow, my menu opens, but when I drag it down it stretches. How can I disable it? Just fixed size, without stretching down after opening? Thanks!

Hi,
If the first selected element is not the first element of list the checkmark is wrong. The selected row on initialization is ever the first.

Thanks in advance.

Hello,

Your navigation dropdown menu is very cool. I use it on a new application. A lot of my future user are blind people. I may implement UIAccessibility. It not a hard work.

I'm using your code via cocoa pod. This my question how to set UIAccessibility for menu title and menu item.

regards
seb

Hi @PhamBaTho,

I noticed that the title is not always centered depending on the device (iPhone 5s vs iPhone 6).

Do you have any tip?

Hey, will this be updated anytime soon?

17 errors occur when loading this code in the above version of Xcode. The first four are:
1 Invalid redeclaration of 'BTNavigationDropdownMenu'
2 Cannot invoke 'BTConfiguration' with no arguments
3 'BTTableView' is ambiguous for type lookup in this context
4 Invalid redeclaration of 'BTConfiguration'

Unfortunately, since i am just now learning SWIFT, i cannot offer corrections or suggestions. Thank you for sharing your code for others.

Hello, is it possible to hide menu when a user taps outside its bounds? If not, could you give me a hint to which view should I add a tapGestureRecognizer?

Thanks in advance