peers / js-binarypack Goto Github PK

I want to release aabbbc2 as v1.0.2 and the current master as v2.
Tagging @afrokick, only he has repository access.

Steps to reproduce: Essentially, just conn.send( '𨋢' ) using the default binary serialization. See full example below.

Expected behaviour: Data is sent and received correctly.

Actual behaviour: The receiving peer crashes inside util.unpack, because the sender sent garbled data.

Cause
This happens when sending any Unicode codepoint above U+FFFF:

• In the Javascript string, a single codepoint above U+FFFF is expressed as a UTF-16 surrogate pair made of two code units, e.g. '\uD860\uDEE2'.
• This is a single Unicode codepoint (even though it has Javascript string length 2).
• The function utf8Length wrongly assumes each individual surrogate becomes three UTF-8 bytes (i.e. a total of six bytes for a surrogate pair).
• But in fact a surrogate pair, taken as a whole, becomes four UTF-8 bytes.
• This length mismatch causes the crash in util.unpack.

Fix: #10

Workaround: Using JSON serialization (instead of the default binary) avoids the crash (but has certain other disadvantages).

Full code to reproduce the error

var peer1 = new Peer();
peer1.on( 'open', function ( id ) {
        var peer2 = new Peer();
        peer2.on( 'open', function() {
                var conn2 = peer2.connect( id );
                // But using JSON serialization, instead of the default binary, avoids the crash
                //var conn2 = peer2.connect( id, { serialization: 'json' } );
                conn2.on( 'open', function () {
                        // Send U+282E2, the Cantonese word for 'elevator'
                        // (but it could be any of the 93,000 Unicode codepoints above U+FFFF)
                        conn2.send( '𨋢' );
                } );
        } );
} );
peer1.on( 'connection', function ( conn1 ) {
        conn1.on( 'data', function ( data ) {
                // This never runs: util.unpack crashes before we get this far
                console.log( 'received: ' + data );
        } );
} );

In version 1.0.1, support for Blob and File types was available. However, it seems that support for Blob and File types has been removed in version 2.0.0 after the introduction of TypeScript. The error message states, Type 'function Blob() { [native code] }' not yet supported.

Now that PeerJS is using the 2.0.0 version of js-binarypack, I would like to request the addition of support for Blob and File types in version 2.*.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Pending Approval

These branches will be created by Renovate only once you click their checkbox below.

• chore(deps): update dependency eslint to v9

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): lock file maintenance

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency @biomejs/biome to v1.7.0

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update dependency @typescript-eslint/eslint-plugin to v7

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository