Such code works:

var UINT_MAX = 4294967295;

BinaryPack.unpack(
    BinaryPack.pack(
        { number: UINT_MAX }
    )
);

This throws ( RangeError: Maximum call stack size exceeded ):

BinaryPack.unpack(
    BinaryPack.pack(
        { number: UINT_MAX + 1 }
    )
);

The use of the variable name 'byte' causes google closure compiler to refuse to compile the source.

Google closure compiler exits with:

ERROR: JSC_PARSE_ERROR. Parse error. identifier is a reserved word at ./node_modules/js-binarypack/lib/binarypack.js line 111 : 6
ERROR: JSC_PARSE_ERROR. Parse error. identifier is a reserved word at ./node_modules/js-binarypack/lib/binarypack.js line 113 : 9

Attached a PR removing the use of a temporary variable entirely. #12

See the PR #13

Thanks so much for this helpful library!

I’m using the binarypack through peer.js to send data from the Kinect 2, using Kinect2 library, which sometimes includes negative infinity. This is causing me to get the error “Invalid Integer” repeatedly from line 400, which is slowing down my peer connection significantly. I’ve fixed it in my own code with adding this as an additional option at line 399:

else if(num===Number.NEGATIVE_INFINITY){num=0;}

In my use case setting num to 0 solves the issue. Although there's likely a better way to add a more universal fix.

The browser encoder uses character length for strings, but the browser decoder, node encoder, and node decoder all expect byte lengths. This leads to hilarity at decode time.

Since this is several years old, it seems to have missed the fact that msgpack has included distinct codes and encodings for strings and byte arrays for a while now (1). Current msgpack impls support the spec in this regard. Further, the codes used in binarypack conflict with those used in msgpack for these purposes. Should binarypack be deprecated and binaryjs made to use a current msgpack impl? Or at very least, binarypack should be made compatible with current spec.

1. https://github.com/msgpack/msgpack/blob/master/spec.md