Giter Club home page Giter Club logo

Comments (14)

rhyneav avatar rhyneav commented on May 17, 2024 2

Gotcha! Could this also be solved by changing the html from

<div class="container paper">

to

<div class="container">
  <div class="paper">

That way the paper width of 100% is within the container and not overriding it.

I'm just trying to find ways around using !important. This way it's easier for someone using PaperCSS to override the styles if need be.

from papercss.

rhyneav avatar rhyneav commented on May 17, 2024 1

Ah dang. The culprit is the CDN url. Just a simple overflow-wrap: break-word; style should fix this.

img_5081

from papercss.

TotomInc avatar TotomInc commented on May 17, 2024

So shouldn't this property be added to a component?

from papercss.

afzalsayed96 avatar afzalsayed96 commented on May 17, 2024

We missed this...

image

from papercss.

afzalsayed96 avatar afzalsayed96 commented on May 17, 2024
table tbody tr td {
    padding: 8px;
    line-height: 1.5;
    vertical-align: top;
    border-top: 1px dashed #d9d9d8;
}

The padding is the problem

from papercss.

afzalsayed96 avatar afzalsayed96 commented on May 17, 2024

Proposed fix:

  • Padding for table tbody tr td must be in percentage
  • Adding !important in media query for container width
.container {
    width: 100%;
    max-width: 960px;
    position: relative;
    margin: 0 auto;
    @media @medium-screen {
        width: 85% !important;
    }
    @media @xsmall-screen {
        width: 90% !important;
    }

from papercss.

rhyneav avatar rhyneav commented on May 17, 2024

Good catch with the padding! And is the !important tag needed here?

from papercss.

TotomInc avatar TotomInc commented on May 17, 2024

@rhyneav I think the !important tag override the default width which is set upper.

from papercss.

afzalsayed96 avatar afzalsayed96 commented on May 17, 2024

@rhyneav Yes it's needed

image

important

@TotomInc It does override only for the specified screen-size which is actually desired to achieve

from papercss.

afzalsayed96 avatar afzalsayed96 commented on May 17, 2024

Great! Your fix works. I totally forgot about problem with overriding !important 😅

from papercss.

afzalsayed96 avatar afzalsayed96 commented on May 17, 2024

Is anyone assigned to this issue?

from papercss.

rhyneav avatar rhyneav commented on May 17, 2024

Nope! Do you want to take this one @afzalsayed96?

from papercss.

afzalsayed96 avatar afzalsayed96 commented on May 17, 2024

I'm on it

from papercss.

rhyneav avatar rhyneav commented on May 17, 2024

You rock, thank you @afzalsayed96!

from papercss.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.