MaxPullRequestPollCount shall be configurable about bulldozer HOT 2 CLOSED

Thanks for using Bulldozer! I think there's some confusion about the purpose of theMaxPullRequestPollCount setting, so let me try to explain what it does and then we can see if it still needs to be configurable.

This setting does not control the number of pull requests Bulldozer will merge or the number of times Bulldozer will update a feature branch by merging in develop. Instead, it is the number of times Bulldozer retries the merge operation for a single pull request in the event of some specific errors:

• If GitHub has not calculated the mergability of the pull request yet
• If the request to the merge API fails due to a network error
• If GitHub returns an unexpected error code, like a 500 Internal Server Error

As these are all exceptional cases, hitting the current limit of 5 should only happen if something is broken in GitHub or with the application.

For the first case, have you seen cases where pull requests you expected to merge were not merged? If so, the application logs should explain why any pull request was or was not merged.

In the second case, did you have to resolve a merge conflict when creating commit 385385c? Bulldozer can only update a feature branch if there are no conflicts to resolve. Once conflicts are resolved, I expect it to keep updating the branch until the pull request merges, which seems to be what happened here.

from bulldozer.

Hi,

thanks for clarification, that retry happens for the mentioned errors. This was not clear to me.

In the meanwhile, I was not observing anymore, that bulldozer was not doing the merges as expected (y) Maybe my given use case was an exception. Unfortunately I do not have access to these logfiles in the deployed environment, but as I said, from my perspective, bulldozer is doing a really good job!

from bulldozer.