Comments (2)
Thanks for using Bulldozer! I think there's some confusion about the purpose of theMaxPullRequestPollCount
setting, so let me try to explain what it does and then we can see if it still needs to be configurable.
This setting does not control the number of pull requests Bulldozer will merge or the number of times Bulldozer will update a feature branch by merging in develop. Instead, it is the number of times Bulldozer retries the merge operation for a single pull request in the event of some specific errors:
- If GitHub has not calculated the mergability of the pull request yet
- If the request to the merge API fails due to a network error
- If GitHub returns an unexpected error code, like a 500 Internal Server Error
As these are all exceptional cases, hitting the current limit of 5
should only happen if something is broken in GitHub or with the application.
For the first case, have you seen cases where pull requests you expected to merge were not merged? If so, the application logs should explain why any pull request was or was not merged.
In the second case, did you have to resolve a merge conflict when creating commit 385385c
? Bulldozer can only update a feature branch if there are no conflicts to resolve. Once conflicts are resolved, I expect it to keep updating the branch until the pull request merges, which seems to be what happened here.
from bulldozer.
Hi,
thanks for clarification, that retry happens for the mentioned errors. This was not clear to me.
In the meanwhile, I was not observing anymore, that bulldozer was not doing the merges as expected (y) Maybe my given use case was an exception. Unfortunately I do not have access to these logfiles in the deployed environment, but as I said, from my perspective, bulldozer is doing a really good job!
from bulldozer.
Related Issues (20)
- 415 error on GitHub v3 API GET call GHE 2.22.25 HOT 2
- Sporadic 403 "You have exceeded a secondary rate limitβ errors HOT 16
- New trigger idea: auto_merge HOT 1
- Support GitHub Merge Queue HOT 3
- Bot fails to interpret .bulldozer.yml HOT 2
- Verify author of a PR status HOT 3
- Can bulldozer wait until non-required checks are finished before merging? HOT 8
- Option to add update trigger after required statuses pass for the first time HOT 2
- Bulldozer doesn't trigger when use the shared configuration from `.github` repository HOT 1
- Bulldozer cause the Jenkins build to trigger twice HOT 1
- Add special "merge action" which comments instead of merging HOT 1
- Conditionally change commit title/body?
- Options can't be configured as ENV var HOT 2
- PRs left open when GitHub is too busy HOT 4
- pushing commits to master
- could not refresh installation id ####'s token: received non 2xx response status \"302 Found\" when fetching HOT 3
- Bulldozer is not auto merging my PRs HOT 6
- Could not refresh token error HOT 2
- Unable to merge due to branch protection rules HOT 1
- +1 year without release :disappointed: HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bulldozer.