Comments (4)
asvoboda
commented on August 30, 2024
Hey @justinwyer, thanks for submitting this. I think we already try 5 retries when merging, so something else might be going sideways here. How many pull requests are merging when you see this type of issue? We could probably increase the number of retries and backoff.
from bulldozer.
justinwyer
commented on August 30, 2024
Thanks @asvoboda it seems like there is no retry in this case as the error returns non as retry-able
Lines 291 to 293 in 7b3d468
Base branch was modified. Review and try the merge again. or we could more generally make http.StatusMethodNotAllowed retry-able. What would you prefer?from bulldozer.
asvoboda
commented on August 30, 2024
Yep that'll do it.
I think it probably makes sense to check for that specific error. In general the 405 should indicate the request is actually not meant to be retried, but Github internally treats this particular error as retry-able, which is a little bit wonky.
from bulldozer.
justinwyer
commented on August 30, 2024
Okay great, will open a PR a bit later.
from bulldozer.
Related Issues (20)
- 415 error on GitHub v3 API GET call GHE 2.22.25 HOT 2
- Sporadic 403 "You have exceeded a secondary rate limit” errors HOT 16
- New trigger idea: auto_merge HOT 1
- Support GitHub Merge Queue HOT 3
- Bot fails to interpret .bulldozer.yml HOT 2
- Verify author of a PR status HOT 3
- Can bulldozer wait until non-required checks are finished before merging? HOT 8
- Option to add update trigger after required statuses pass for the first time HOT 2
- Bulldozer doesn't trigger when use the shared configuration from `.github` repository HOT 1
- Bulldozer cause the Jenkins build to trigger twice HOT 1
- Add special "merge action" which comments instead of merging HOT 1
- Conditionally change commit title/body?
- Options can't be configured as ENV var HOT 2
- pushing commits to master
- could not refresh installation id ####'s token: received non 2xx response status \"302 Found\" when fetching HOT 3
- Bulldozer is not auto merging my PRs HOT 6
- Could not refresh token error HOT 2
- Unable to merge due to branch protection rules HOT 1
- +1 year without release :disappointed: HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bulldozer.