Garbage Collection about backbone.virtualcollection HOT 5 CLOSED

You can bind the virtual collection with a view with the close_with attribute. Once the view is closed, the virtual collection will remove the listeners.

from backbone.virtualcollection.

I think you're right @dtodor, although I think the solution would be to replace

model.on('all', this._onAllEvent, this); for this.listenTo(model, 'all', this._onAllEvent)

and https://github.com/p3drosola/Backbone.VirtualCollection/blob/master/src/backbone.virtual-collection.js#L41 for _.each(this.models, function () { this.stopListening(model) }, this)

would you agree?

from backbone.virtualcollection.

would also need to update _indexRemove and _onRemove

from backbone.virtualcollection.

Yes, that would be the better solution.

from backbone.virtualcollection.

nice. I'll try and get to it during a flight on saturday :)

from backbone.virtualcollection.