Comments (5)
p3drosola
commented on September 26, 2024
Hi @reubenrybnik I'm afraid I'm not maintaining this project at the moment. If you suggest a PR I'd be happy to consider it.
from backbone.virtualcollection.
reubenrybnik
commented on September 26, 2024
No worries, I can work around this with an override of _onAdd in an extending class for now, and I can probably get a PR up some time in the next few weeks (assuming there's no rush since I'm the only one currently reporting it). Thanks for the follow-up @p3drosola!
from backbone.virtualcollection.
reubenrybnik
commented on September 26, 2024
@p3drosola PR is up, happily pretty straightforward, though I left notes in the PR regarding a few minor already existing differences in sorting behavior from Backbone that this PR does not address. As I mentioned, I've got a workaround in place for this already and no one but me is requesting this fix, so there's certainly no rush to review it. Thanks for putting this project together, and thanks in advance for whatever time you might take in reviewing my PR!
from backbone.virtualcollection.
p3drosola
commented on September 26, 2024
Outstanding!
I'll publish a new version to npm with your fix.
Thanks for taking the time to make a PR.
from backbone.virtualcollection.
p3drosola
commented on September 26, 2024
https://github.com/p3drosola/Backbone.VirtualCollection/wiki/Changelog
from backbone.virtualcollection.
Related Issues (20)
- Not compatible with 0.9.2 HOT 1
- NPM is not up to date HOT 2
- Change event triggered without options.index causes error HOT 1
- Source Missing License Header HOT 2
- Listen to a specific attribute changes in a model in a virtual collection
- Publish 0.5.2 to NPM HOT 2
- Create a virtual collection from multiple collections HOT 3
- Support Backbone.PageableCollection HOT 4
- IE8 fix HOT 6
- Caching, disabling and re-enabling subsets HOT 2
- Models added twice to a virtual collection HOT 7
- Properly override clone HOT 5
- Problem with Sort when not overridden HOT 7
- Backbone update event not being handled HOT 5
- Add a License and Re-Publish to NPM HOT 1
- Garbage Collection HOT 5
- Option for creating deaf collections HOT 2
- Event "change:attr" is not handled in some cases HOT 6
- make backbone a peer dependency HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backbone.virtualcollection.