owncloud / activity Goto Github PK

Would it be possible to move the erase time to the config file, also increment the maximum amount of activity from int to bigint.

@nickvergessen

Copied from todo in the code

I am running OC7 commit a34491e28895f84d220cb5dbbbe4273172334716 with activity commit 9f4ea28 (both currently most recent commits)

When I enter the activity app it gives me an unreadable screen:

Logs are filling with:

Error   PHP Invalid argument supplied for foreach() at /usr/share/owncloud/apps/activity/lib/data.php#148   May 26, 2014 12:18:17
Error   PHP Method OC_L10N_String::__toString() must return a string value at /usr/share/owncloud/lib/private/util.php#862  May 26, 2014 12:18:17
Error   PHP vsprintf(): Too few arguments at /usr/share/owncloud/lib/private/l10n/string.php#57

I have seen this before but then I ignored it, so the issue is not entirely new.

Server: Ubuntu 13.10, mysqld Ver 5.5.37, PHP 5.5.3, Apache/2.4.6
Client: Ubuntu 14.04, Firefox 29.0

Any thoughts?

The icons (+, X, <, ... ) are not vertical aligned correctly.

@jancborchardt you want to take a look at it?

• Depends on owncloud/core#8659

when you share something with someone (or receive a share), the avatar should be shown left next to the name of that person. (Do not show the avatar of the current user!)

Steps to reproduce

1. Call cron.php

Expected behaviour

No errors

Actual behaviour

Errors

Server configuration

Operating system: opensuse 12.3

Web server: nginx 1.5.12

Database: postgresql

PHP version: php 5.5.14

ownCloud version: (see ownCloud admin page) 7 RC1

Updated from an older ownCloud or fresh install: Updated

List of activated apps:

• Activity
• Calendar
• Files
• Contacts
• Deleted files
• PDF Viewer
• Share Files
• Text editor
• Versions
• Imprint

The content of config/config.php:

<?php
$CONFIG = array (
  'loglevel' => '2',
  'instanceid' => '…',
  'passwordsalt' => '…',
  'datadirectory' => '/data',
  'dbtype' => 'pgsql',
  'version' => '7.0.0.4',
  'dbname' => '…',
  'dbhost' => '127.0.0.1',
  'dbtableprefix' => 'oc_',
  'dbuser' => '…',
  'dbpassword' => '…',
  'installed' => true,
  'appstoreenabled' => false,
  'apps_paths' => 
  array (
    0 => 
    array (
      'path' => '/apps',
      'url' => '/apps',
      'writable' => true,
    ),
    1 => 
    array (
      'path' => '/apps-git',
      'url' => '/apps-git',
      'writable' => false,
    ),
  ),
  'forcessl' => true,
  'maxZipInputSize' => 419430400,
  'allowZipDownload' => true,
  'theme' => '',
  'maintenance' => false,
  'trusted_domains' => 
  array (
    0 => '…',
  ),
  'custom_csp_policy' => 'style-src \'self\' \'unsafe-inline\'; frame-src *; img-src *; font-src \'self\' data:; media-src *',
);

Are you using external storage, if yes which one: nope

Are you using encryption: nope

Logs

ownCloud log (data/owncloud.log)

{"app":"no app in context","message":"Error while running background job: An exception occurred while executing 'SELECT \"amq_affecteduser\"  FROM \"oc_activity_mq\"  WHERE \"amq_latest_send\" < ?  GROUP BY \"amq_affecteduser\"  ORDER BY \"amq_latest_send\" ASC LIMIT 25':

SQLSTATE[42803]: Grouping error: 7 ERROR:  column \"oc_activity_mq.amq_latest_send\" must appear in the GROUP BY clause or be used in an aggregate function
LINE 1: ...send\" < $1  GROUP BY \"amq_affecteduser\"  ORDER BY \"amq_lates...
                                                             ^","level":3,"time":"2014-07-04T13:10:01+00:00"}

@karlitschek please update the daily build for master to include this app, now that it's in a separate repo.

Running commit 61f62c1 which now shows my data but sometimes looses the first character of You shared .... from the old data
So: You shared wnCloudUserManual.pdf and You shared xample.odt
New data goes well.

If I look at the data in the database I see:
new data:
a:1:{i:0;s:14:"/sharetest.txt";}
old data:
a:1:{i:0;s:22:"ownCloudUserManual.pdf";}

So it appears a minor issue which only happens with old data. The filename from the file variable within the database table looks consistent, so that could be a way to prevent having to look at the actual data itself?

@libasys:

Missing logic in timeline:

You have activities 3 days ago and than it shows an activity from today!

timelineproblem occurs of variable allowGrouping! If i set this variable to false the timeline shows right!

protected function getGroupParameter($activity) {
        if (!$this->allowGrouping) {
            return false;
        }

        if ($activity['app'] === 'files') {
            switch ($activity['subject']) {
                case 'created_self':
                case 'created_by':
                case 'changed_self':
                case 'changed_by':
                case 'deleted_self':
                case 'deleted_by':
                    return 0;
            }
        }

        $parameter = false;
        // Allow other apps to group their notifications
        \OCP\Util::emitHook(
            'OC_Activity',
            'group_parameter',
            array(
                'activity'      => $activity,
                'parameter'     => &$parameter,
            )
        );

        return $parameter;
    }

this function don't look for the timestamp if grouping is allowed

I run recent oc master with fresh activity clone on my local installation.
I configured sendmail and i receive testmail and passwort reset mails.
All Notifications for mail are enabled, grouping is set to hourly.

Still no mails get send out.

Here is the export of "oc_activity_mq"

http://codepaste.net/hev5fd

Related errors in owncloud.log:

Undefined index: filter at /home/gomez/public_html/logistik_xtra/htdocs/apps/activity/lib/data.php#259
Undefined offset: 1 at /home/gomez/public_html/logistik_xtra/htdocs/lib/private/share/share.php#1342

Get this on every initial activity app startup (click on the navigation entry for activity) The url-parameter isn't set.

Undefined index: filter at apps/activity/lib/data.php#259

owncloud-archive/apps#1768

See https://github.com/owncloud/activity/blob/master/personal.php#L23-L24

we shouldn’t have dependencies between apps. Which code do you exactly reuse there? Maybe it’s a good idea to move into core?

grouped file actions should be displayed in a row, not in a list (and not repeat the action) so instead of the You created x, you created y, you created z …, it should say: You created x, y, z and 3 more … in one line

https://github.com/owncloud/apps/pull/1769/files#r12634169

it's too hard to guess which date belongs to which activity when your screen is a bit bigger
owncloud-archive/apps#1769 (comment)

• Depends on owncloud/core#9761

With the Mail templates app it is possible to edit templates as admin over the web ui.
The activity template does not appear in the dropdown.
Havent looked into detail, but its a good idea to make this possible.

On recent master i get email with a wrong url of the cloud:

You are receiving this email because in the last
day the following things happened at
http://localhost/var/www/virtual/xsd-xtra.portknox.net/htdocs

There should be the url like https://supercloud.portknox.net

I use the cli cron.php

The problem is we change userid before getting the displayname.
We need to first get the displayname and then modify the userid.

There is no need to keep that data, after the user has been deleted.

At least for the most common queries

owncloud/core#6348

As a user i'd like to have a pop-up-notification-center similar to "Atlassian Confluence".
The difference to the activity-stream would be:

• it is available everywhere in owncloud
• it shows not only a history / past events, but alerts me for present or future events/messages, etc.
• it refreshes via ajax in the background. so i don't have to klick on "News" to check if there are unread news, i don't have to click "Calendar" to check if there are new events.
  There would be a small number (3) on the symbol in the top right corner and i can see directly if there are somethings todo etc.

Mockup:
mockup notification center

I was playing with the new notifications and maybe it would be a good idea to add a "Send all notifications now" button for the admin? With a respone back to the admin, if mails are send and how many?

If it is given

Sidebar

The first section should be like this:

• All Activity
• Activity by you
• Activity by others
• Shares

Then a section for the individual apps:

• Files
• Calendar
• Contacts
• …

After you share a file can you see in the Activity tab the following Hash code:

Copied from todo in the code

• Depends on owncloud/core#9058

Copied from todo in the code

Currently it's done randomly when inserting:

        // call the expire function only every 1000x time to preserve performance.
        if (rand(0, 1000) == 0) {
            Data::expire();
        }

Filename: te<st>
Displayes as: te<st>
Is in HTML as: te<st>

owncloud-archive/apps#1764

It would be nice to allow users deleting their own activity history.

We can manage it by checking e.g. user == affecteduser in activity table. Even we can allow deletion if we are the affected user since there are at least two entries for one activity if it is related to two different users.

owncloud-archive/apps#1783

I stumbled across this. When you search for a filename, the search lists all create, update, delete, ... activities for that file.
I think it makes no sense to spam the search results with acitivities. Users want to find the searched file and not the activity. So the files app should be a search result instead of the activity app.

What would make sense is to add a filter option to the activity app itself, where a user can select to only display activities of type x now.

[Wed May 28 22:45:59 2014] [error] [client 192.168.122.1] PHP Fatal error:  Call to undefined method OC\\Preferences::getValueForUsers() in /var/www/core/apps-external/activity/lib/hooks.php on line 306

On master (core + activity) when deleting files.

We should use some JS magic and display a loading circle (like in the files app)
When changing from one filter to another.

/cc @jancborchardt

@PVince81 I heard you added that into the files app?

Currently when you share something via link, the entry says:

You shared Projects

Which doesn’t make it clear that it was via link.

It should be:

You shared Projects via link

@nickvergessen

owncloud-archive/apps#1625
owncloud/core#6379

I don't understand the use case of the RSS feed of the Activity app.
It would make more sense if it was a public feed with a token (a bit like we do for "share with public link" in Files).

Check News feed of github for something similar.

possibly related to owncloud-archive/apps#1605

.txt previews are generated with a white background, which is now displayed on white background instead of gray background compared to before
owncloud-archive/apps#1769 (comment)

Might not be an issue for normal files as they are not as empty as the one-line testing files I used

Here the strings are converted into "You created %1$s"which causes $s to be used as a variable by PHP.

We should either escape $ or find another way to make flexible translation.

One simple Question: Is there a possibility to use the activity app for other apps to log activities from other user e.g. user a shares a calendar with user b? In the lib of oc i found an activitymanager? Could you please post a snippet, how to init the activitymanager and how to use it?

Thanks in advance!

Since the Notification settings use a table layout, they break on mobile by introducing a horizontal scrollbar. See owncloud/core#8906 for reference.

Now we can still have the table layout, but should make sure that the text wraps on mobile.

cc @owncloud/designers

Hello,

the activity app shows already shared data with owncloud users or groups, for example
"You shared pichture.jpg with testuser".

But if you share some data with a link and input an email-adress, this action isn't shown in the activity app.

Is there any possibilty to show the "share link" actions in the activity app?

Best regards and thanks in advance,

CtrlCCtrlVEnter

About the »Send emails (Hourly, as they happen, …)« setting:

Can we make that more automatic, that it groups events which happen in rapid succession? Also changes are less important – but for new shares you get, you should immediately get a notification.

Much like for how the Activities are grouped in the Activity app itself.

@nickvergessen @owncloud/designers

@nickvergessen as we talked about:

The first section should be like this:

• All Activity
• Activity by you
• Activity by others
• Shares

Then a section for the individual apps:

• Files
• Calendar
• Contacts
• …

And at the bottom an entry:

• RSS feed
  (In the future when we have more settings, we can have an expandable area)

Next to the navigation entries (on the right of them), there should be the number of unread right next to it (with .utils class).

For the first implementation, start with »All Activity« and »RSS feed« (just to switch the layout and keep the current functionality).

in the personal area we can activate or deactivate logging activities, but the logic is not really clear, the information is not really true, for example:
"A new file or folder has been created in a shared folder"
But if i create a file or folder in a not shared folder, this also get logs with. I think the activity should have more options to granulate.
e.g.
"A new file or folder has been created"
"A new file or folder has been created in a shared folder"
So if i am only interested to know who creates or uploads files or folders in a shared folder so i can deactive my activities (A new file or folder has been created) but log the activities from others!

owncloud-archive/apps#1605

In IE11, navigate to the Activity tab and then select RSS feed. The following error appears:

It works fine in Firefox.
{"installed":"true","version":"6.0.0.14","versionstring":"6.0.0a","edition":"enterprise"}

Should not display that

Since activity is separated from the core repository, it does not update the translations from transifex.

This is also valid for files_pdfviewer and updater

@DeepDiver1975

Need to investigate why this is happening.