Giter Club home page Giter Club logo

eole-foobar-theme's People

Contributors

cwilliams5 avatar humbledeer avatar jadetank avatar kik-o avatar kiosion avatar lokke avatar marc2k3 avatar mishaisay avatar oldnero avatar ottodix avatar shademe avatar stzx avatar syaoranchang avatar timmyfox avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

eole-foobar-theme's Issues

Songs tagged with multiple genre only shows up for first genre tag

I have alot of songs with multiple genre tags such as
Darksynth; Synthwave; Horror; Retrowave
With this skin running, selecting Darksynth as genre, it only showcases those songs who have Darksynth tagged first, so if it was tagged like this
Retrowave; Synthwave; Horror; Darksynth
Then it does not show up at all on Darksynth, but Retrowave, by default on foobar it would show up.

Is this there some documentation on this im missing, or is this not a feature available yet?

[Bug] - Album Selected Arrow

Thank you for all your work u put into this beautiful skin!

found a bug:
when "background according to album art (blurred)" is selected, Album Selected Arrow have wrong color.
while cycling from light to dark mode the arrow change color from transparent to black.

foo

Control panel - output device selection?

Hi,
thank you for this amazing theme, I love it. The only thing I can't figure out is - how to add Output device selection onto the control bar? I use this option quite often.
Thank you

There is a problem

Many thanks to the author for a great theme for Foobar2000! The player’s functionality multiplied by such a modern and bright appearance leaves no chance for anything else.
The following issues were found:

When you connect youtube source component allows you to get video covers. But for all videos, the same cover as the first is displayed in the right sidebar, playlist and in the bottom. You can only update manually through the context menu. I would like the covers to display correctly. In the worst case, for all streams to display one common standard cover, as for the radio.
In doing so, the another panels detect and use the correct cover art for each video;
In the library, covers for youtube source appear as empty squares. In the worst case, for all streams, one common standard cover could be displayed, as for a radio;
In idle screen/screensaver, the right cover is not automatically updated when changing the album. In library mode, this is all right.

v1.2.3b14 crash

This version crashes foobar2000 just from copying the files over, before I had a chance to import new theme.

How to set biography display only cover.jpg

Biography view will fetch data and images from last.fm and display the image.

I only want to display the cover image file from my disk.

Tried to disable the auto fetch feature by setting all the Auto-Fetch to 0 and restart foobar2000

But sometimes it still give me "No Cover" or other images out of nowhere.

Is there any setting I can achieve this? Thanks.

Feature Request - Dynamically adding custom tag in Filter

First of all great skin! It'd be great if we could add additional custom filters instead of the default Genre/Artist/Album in the WSHMod, e.g. %style%, %classification%, etc. since I heavily tag by music for VGM with additional metadata. Initial code reading had lead me to modify the WSHfilter.js, only to find that the code is massive and might require a lot of rework?

Thanks for the effort and keep it going!

How to change grouping of the "Now playing"

I'd like to group by album in right "Playing" panel but dunno how.

In the mid panel of "Library" page I could right click and group by title formatting %album%

But as the right playing track panel is there a way to configure it? Thanks.

Inconsistent behavior for the link under expanded album view

I've noticed some inconsistent behavior with the iTunes-like expanded album view.

Consider this scenario:
I have my ARTIST Group set to this:
$if2($meta(album artist),$meta(artist))
This doesn't give albums an artist, let's just call him Ben Gold, only appears on, but it's beside my point.
This will give me album 1:

| track artist | album artist | title                           | album            |
|--------------|--------------|---------------------------------|------------------|
| Ben Gold     | Ben Gold     | Sapphire (Recut)                | Sapphire (Recut) |
| Ben Gold     | Ben Gold     | Sapphire (Recut) (Extended Mix) | Sapphire (Recut) |

But crucially also album 2, where Mr. Gold is technically only the album artist.

| track artist           | album artist | title                                        | album                                   |
|------------------------|--------------|----------------------------------------------|-----------------------------------------|
| Ben Gold; Eric Lumiere | Ben Gold     | Hide Your Heart (Chris Schweizer Radio Edit) | Hide Your Heart (Chris Schweizer Remix) |
| Ben Gold; Eric Lumiere | Ben Gold     | Hide Your Heart (Chris Schweizer Remix)      | Hide Your Heart (Chris Schweizer Remix) |

When you click that link that says "Ben Gold" in the iTunes-like expanded album view on album 1, you'll get albums that Ben Gold appears on (no complaint there), but album 2 will not be shown, but I think it really should be.

Need newer foo_ui_columns error on import

I've tried to follow the instructions in the README, but I get stuck on the step where I need to import the FCL file in the Column UI settings.

The error simply says: Need fewer foo_ui_columns.

I tried resetting my foobar2000 configuration to default settings in case it was something related to that but this didn't help.

Any ideas?

Spider Monkey Panel: brw.groups[albumIndex] is undefined

Hello, it's me again! :) I encountered this error while browsing through the library, but this time I'll keep it short, I promise!

It seems to appear randomly on different media, and it seems linked to the album art cache generation, though I can't be sure. Basically, the library browser panel crashes sometimes when opening some category from the left side menu, regardless of the active sort method (I've tried folder structure, artist, and genre). I've already got a fully formed cache with saved images on my HDD, but I regenerated it just in case, which didn't resolve the issue.

This is the error I always get:

Error: Spider Monkey Panel v1.2.2-beta+67d2c599 (GraphicBrowser v1.2.2b22 by Ottodix)
brw.groups[albumIndex] is undefined

File: JStheme_common.js
Line: 2807, Column: 3

Stack trace:
get_albumArt_async@JStheme_common.js:2807:3
async*oImageCache/this.hit@JStheme_common.js:2947:9
oBrowser/[email protected]:4629:15
oBrowser/[email protected]:4759:6
[email protected]:5932:12

Sort by Album

Hi, how would I group by album rather than album & artist?

I attempted to use the Group By > Custom Titleformat option but that doesnt seem to be working

Beautiful and functional skin but very high memory usage

Hi,

I found your skin on devintart and first off I would like to thank you for sharing it with the community.
The only problem I have with is memory usage which can exceed 300-400 MB at times.
This wouldn't be a problem if the usage went down when the player is minimized, some users like to keep the music playing when working with cad, rendering, other memory intensive software or even while gaming and 300-400 MB for a music player are kind of difficult to swallow as a requirement to enjoy the added functionality and beauty of your skin.

This is not a an issue but merely an improvement suggestion.
I am not an expert of javascript nor a foobar skin maker and I don't know how feasible this is but a version with a lower memory usage or optimizations to allow the skin to get "lighter" when the player is minimized would be much appreciated.

https://i.imgur.com/ZK4W8Xr.jpg

Suggestion: Font change

Would it be possible for you to implement easy font change?
Also there's issue of text overlapping when font size is increased. Maybe it'd be good to make some panels resizeable or change their fixed width.

Screenshot_3

Mini player white progress bar bug

Hello,

I get an error mentioned below when I want to set playlist progress bar to white in the mini mode.

Error: Spider Monkey Panel v1.2.1 (MiniModePlaylist v1.0.0 by Ottodix)
progressbar_color_bg_off is not defined

File: WSHsmoothplaylist.js
Line: 2947, Column: 13

Stack trace:
  oBrowser/[email protected]:2947:13
  [email protected]:4693:16

edit. Same happens with right playlist. Also is it normal for cover to disappear from the right when I select transparent background or blurred for the main tracklist?

[Suggestion] Hide biography panel

Hello,

If you're willing I'd love to see an option to hide biography panel and have lyrics panel cover the space as I don't care for it at all and then I could make the font for lyrics bigger without breaking lines.

SpiderMonkeyPanel: this.groups[this.groups_draw[this.activeTextIndex]] undefined

Just an issue I quickly came across when trying out the skin today for the first time. This is after a fresh install of the foobar program with an immediate installation of the theme. I went over the instructions a few time, but I guess there's always the chance I did something incorrectly. If this is the case, I do sincerely apologize.

The way I come across it is completely repeatable for me:

  1. Click "All" on left sidebar for the genres
  2. Click on an album cover art to open up track list
  3. Click on album title in track list window that opened up
  4. Error appears -only- after moving mouse icon when new central display area is shown, but it happens immediately when you do move it.

Result:
Capture

Blurry covers

Hello,

Every time I hide/show left panel in the library panel covers get blurry. Their size changes. I've even set cover cache size to 500 px but it didn't change anything. I need to refresh them manually to look okay. Would the only way to solve this be setting cover cache to 0?

edit. It looks like it doesn't solve it either.

buttons for de-/increase width of sidebars

Left toogle button is not displayed even though it is on. At the same time, the width can only be set via a settings menu. It is unconfortable to adjust the left side.

Request - Show disc number over album art on library view

Just found your skin today on DeviantART and I'm really liking it, truly beautiful and very practical. Just wanted to ask for an option to show the disc number over the album art, just like the one that you already added for the release date. It would really improve the ux when you have really long compilations. My Street Fighter V compilation with 11 discs and the Mega Man X with 13 are real culprits here. 👀

Thanks for sharing this skin.

4k Scaling Issues

While most of the UI is fine even in 4k, the lower control panel is a bit unusable, especially in the mini player. Is it possible to rescale it?
Control bar 1
Control bar 2

Album Art For Radio Stream

So I listen to DI.FM's radio streams and I am trying to just put their logo as the album art. I was able to add their logo on the right side, but I can't get it to show in the middle panel. How do I set the middle image?

image

Default sort options for ALL panels.

Hello, dear Author! After updating up to latest version,1.2.3b6, I got my right side playlists are sorted strange way. Please take a look at the screenshot, playback order is different for the same album. How can I set default sorting for ALL playlists?
2020-01-08_231240

Unresponsive script on every start up.

Foobar2k fails to start normally every time with this theme. An unresponsive script

Panel: TitleBar
Script:JStheme_common.js:2795

I can select 'Dont ask me again' option but that does not help.

Album Display Error

Hello,

I've recently been looking at Foobar themes. Your theme is quite pleasant for my desires, and it's clear you've put hard work into it. Also it's up-to-date which doesn't hurt. However I am encountering one issue with it. The display for an album that is a movie soundtrack does not group together. Instead each song is displayed separately as it's own album. I believe this has to do with the Artist names all being different, even though the Album names are the same. I have a video link to show what I'm talking about. This video displays three test examples. One album being Shrek 2 movie soundtrack, Holes movie soundtrack, and a standard Steriogram album. I'm using Imgur to upload, so the video quality is shit, but you should still be able to get the idea from it.

https://imgur.com/a/815SL7B

Let me know your thoughts or any fixes that I do not know of. I've triple checked to ensure my install of your theme is correct, and have tested on other Foobar themes/skins. Other themes/skins have grouped the albums correctly.

[Suggestion] ESLyric instead of Lyrics3

Hey, I just found out that you're updating this skin again! Tried out the new version and I like some of the new features, however I think you should go back to ESLyric for the Now Playing panel. It's customizability is better and Lyrics3 doesn't include a desktop lyric feature.

Again, thanks for continuing support, rock on dude!

"Displayed Playlist" Setting Resets

First off, let me say that I've used Eole for years, and delayed updating the plugins forever just so that I could use the theme. Finally made the switch to a different theme a while back, but i was always nostalgic. I'm delighted that Eole now lives again! Great job, man!

I've noticed that some behaviours persist from old Eole that I've always hated. I'm not sure if this is a bug or some limitation, but it's always been annoying. The WSH Smooth Playlist has a setting (the "Displayed Playlist" setting) that enables it to either always display the active playlist or cycle through currently selected playlists. Every time Foobar starts up, it resets to playing playlists mode.

This practically means that nothing shows up until something begins playing. Which, generally, isn't a big deal, except that the WSH playlist looks and works better than ELPlaylist, so I hid the main playlist from view. Unfortunately, this means that I can't use the WSH playlist to browse my playlists and play at the same time, unless I change that setting every time foobar starts, which is a pain.

Back when I was actively using Eole, I forcibly ELPlaylist from the layout completely, since it was practically useless next to WSH playlist. I've never understood why both were kept. Perhaps it might be time to retire it? Anyway, I'm just throwing that out there, I'd be happy with everything as-is, if only that setting worked properly. :)

Thanks for reading though my rant! I wish you a long and prosperous developing!

Panel crash when pressing the lightswitch while header bar on album art grid is hidden

I suspect this is easily reproducible, if not, let me know.
You just have to hide the header bar, restart foobar2000, and press the lightswitch

Error: Spider Monkey Panel v1.2.3-beta+fbfc0fd8 (GraphicBrowser v1.2.3b8 by Ottodix)
CreateImage failed:
Failed to create GdiPlus object (0x2): InvalidParameter

File: WSHgraphicbrowser_trackinfos.js
Line: 2454, Column: 26

Stack trace:
  oHeaderBar/this.setHideButton@WSHgraphicbrowser_trackinfos.js:2454:26
  oHeaderBar/this.onColorsChanged@WSHgraphicbrowser_trackinfos.js:2625:8
  on_colours_changed@WSHgraphicbrowser_trackinfos.js:7004:14
  on_notify_data@WSHgraphicbrowser_trackinfos.js:7494:4
  Lightswitch@WSHtitle_bar.js:327:16
  build_buttons/buttons.Lightswitch<@WSHtitle_bar.js:555:5
  JSButton/[email protected]:187:26
  JSButtonGroup/[email protected]:396:19
  on_mouse_lbtn_down@WSHtitle_bar.js:969:11

Some fonts replaced by Arial for some reason

Hey, this is an extremely minor issue, but I just wanted to point this out. After reinstalling Windows, I noticed that some fonts used by Eole probably aren't getting recognized (which is weird - didn't it use Segoe UI almost exclusively?) and they reverted to Arial as a result. This happened with my old install as well with a fresh install with the newest version installed.

I included some pictures to indicate what exactly I'm talking about. It's not really an important issue, but I figured it'd be a good thing if I reported this here.

foobar2000_2020-03-15_22-33-37
foobar2000_2020-03-15_22-29-50

import fcl file, Eole v1.2.3b5 and after

Installed in foobar v1.5.1 with columns UI, when open foobar, a window will pop up reminding "import fcl file, Eole v1.2.3b5 and after“. reinstall the eole theme v1.2.3b10, the issue remains. How to solve the problem, thanks!
image

Settings is not saved after rebooting Foobar

Hi, the problem is: the 'tracklist>activate tracklist' custom setting is not saved after rebooting Foobar. At the same time, 'animate opening' setting is saved. I choose to disable both 'activate tracklist' and 'animate opening' options, but 'activate tracklist' setting goes back to enable after restarting.
Take a look at the screenshots.
2020-02-15_084028
After restart:
2020-02-15_084208

Inconsistencies in the loading of AlbumArt images

Most of my music collection possesses AlbumArt files. They are in the same dedicated folders than their corresponding music files. Most of them have a relatively straight naming : "%albumartist% - %album%.jpg"

I'm not yet sure why, but Eole does not load all of those covers. Some following this naming scheme are automatically loaded, others are ignored while existing.

Do you have any idea, from how Eole is made to behave, where I can find the solution to that?

Right sidebar function button

Haven't tested in the newest beta, but when removing the "Right sidebar function" button, it reappears on restart. It's the only button that is doing this

2019-08-21_777

Album art of the first track always being used for the whole album

I saw that you added the option that I asked for to show the album number in the library. Thank you very much for that!

Using the skin for some days now, I noticed that the cover art of the first track of the first disc is used for the whole album almost everywhere but the Now Playing tab, that loads the correct image.

Seems like you're using some complex code to load the covers, so maybe this was necessary, but can you make this behavior consistent? Making it so the now playing artwork in the control panel and the right side panel loads the correct cover art for each track, and each disc in the library view displays the cover art of its own first track?

feature/Equalizer

Issue

Would it be possible to add an Equalizer panel, maybe next to visualization? It seems like this feature is inaccessibe with this theme.

side note

I want to add that I have tried to find a way to contact you before opening an issue, but I wasn't able to find any contact information, so I'm writing this here. Sorry if it's inappropriate.

Appreciate a lot what you have done, by the way. This theme is awesome

Is it possible to implment async loading?

Just wondering if it's possible to use implement it, since from what I see it's the main cause for performance issues. A solution to this could be using async loading, where it loads the images after you have scrolled, that way there's no performance impact and it's smooth when scrolling.

Crash

Error: Spider Monkey Panel v1.2.3-beta+fbfc0fd8 (PlaylistHeader v1.2.3b9 by Ottodix)
cur_btn_down is not defined

File: WSHplaylistheader.js
Line: 955, Column: 9

Stack trace:
  [email protected]:955:9

foobar version: 1.5.1

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.