Giter Club home page Giter Club logo

Comments (7)

Ottodix avatar Ottodix commented on June 19, 2024

Hi,

Yep, easy to reproduce, easy to fix bug : ) It's because you are using the new grid mode without spaces between covers, no ? You can upgrate to the latest release: https://github.com/Ottodix/Eole-foobar-theme/releases/tag/v1.2.2b11

It will make the toggle of this left panel visibility slightly slower though (because now the thumbnails are refreshed after each resize of this central library panel). On a good computer, the change will be hard to notice though, and this refresh only occurs when the display mode is set to "Grid mode"

from eole-foobar-theme.

mjuzikfrik avatar mjuzikfrik commented on June 19, 2024

Great! I think it did the trick. :) Also something to consider for the future: maybe a to increase maximum size of covers in the library panel. When I try to change size in the properties it get weird. They are bigger than they should or the line knob on the slider to control the size moves of out range.

from eole-foobar-theme.

Ottodix avatar Ottodix commented on June 19, 2024

How much? the current default setting is at 200px, right now when I looked (so quite low that's true).

You can change it yourself by going to foobar > skin settings > cover & memory usage. The number there controls this maximum cover width on the library panel. There is an hardcoded maximum maximum though, defined at 2000px, so that's quite high.
Maybe the label of this option isn't explicit (if you can come up wth a better label : )

Changing it through the properties of the panel won't work, it's a litle bit more complex.

from eole-foobar-theme.

mjuzikfrik avatar mjuzikfrik commented on June 19, 2024

1
It acutally did change the size but it's bigger than it should be. After entering 500 px and maxing the slider out it's 730 px. Could it be that this 500 px is the size of the cover in normal mode and not the grid one?

from eole-foobar-theme.

Ottodix avatar Ottodix commented on June 19, 2024

Oh yes it's very probable that the maximum on the slider is higher than the value entered. This value control the size of the cached image actually, and the maximum thumbnail size adapt itself to this, but it's not the exact value, there is some other parameters (like padding when you are not in grid mode, or panel size when you are in grid mode).

But honestly, i think that for 99,9% of users, they won't notice the difference, so I won't fix that

from eole-foobar-theme.

Ottodix avatar Ottodix commented on June 19, 2024

Actually, i did fix it tonigh : ) Now the cover max width can't be exceeded, because it was kind of .. well, weird (i mean to set up a maximum and then exceed it)
Grad the latest release there https://github.com/Ottodix/Eole-foobar-theme/releases

from eole-foobar-theme.

mjuzikfrik avatar mjuzikfrik commented on June 19, 2024

Great! Thank you.

from eole-foobar-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.