Job data is requested via ajax. This is pretty quick on my machine, but may have a noticeable delay off-site.

Add a spinner that appears in the duration between the ajax request and response.

┆Issue is synchronized with this Asana task by Unito

We probably should be setting the proper content type. Though we might want to be aware of this for file-explorer 2.0 instead of trying to fix it here.

┆Issue is synchronized with this Asana task by Unito

If a job is running, show a button that opens up the job status app.

┆Issue is synchronized with this Asana task by Unito

When I use the "Go To" button it would be nice if I could specify a directory with the preceding tilde to go to a specific user's home directory. For example, ~efranz/.

┆Issue is synchronized with this Asana task by Unito

Doug brought up a good point about verifying the integrity of the data that was transferred whether through an upload or download. I know in some zip formats there is a checksum built-in, but having something similar built into the file explorer may be worth exploring in the future.

┆Issue is synchronized with this Asana task by Unito

Incorrect link appears when hovering over the tree view. It works functionally when you click it, but if a user types the address that appears they won't get to the correct place.

Maybe just suppress 'href' here? It seems to be operating via javascript anyways.

Probably one of the most common keyboard shortcuts I use is ctrl-c and ctrl-v for copying and pasting files/folders. I suggest at least bringing back these keyboard shortcuts.

┆Issue is synchronized with this Asana task by Unito

An option for the future - lets not do this just yet though!

A dropdown that shows supplemental groups you are part of, perhaps as part of the middle "button" i.e.

• The filter would be by the Group selected
• The filter chosen would be stored in a cookie (along with the current state of the other controls)
• The text would display: "Your Jobs", then "PAW0003's Jobs", then
• Or if the group name is not known by the user, maybe "Your Group's Jobs" (these users aren't going to be using a terminal by default)

Adding the dropdown inside the input selection is a little tricky though - styles will have to be modified with custom CSS.

┆Issue is synchronized with this Asana task by Unito

If I edit a file in file-editor or create new files/folders in the shell app I don't see changes reflected in the file explorer app without refreshing the whole browser tab. Refreshing the browser tab has its own issues, i.e., the tree view is reset.

Possibly adding a refresh button in the web app would be the simplest fix.

┆Issue is synchronized with this Asana task by Unito

Similar to OSC/ood-fileexplorer#2 we should place a limit on the directory or file sizes we let the user download. Past a certain point, they should be using sftp.osc.edu.

Downloading via file explorer was done via this pull request: OSC/ood-fileexplorer#102

┆Issue is synchronized with this Asana task by Unito

In this commit we essentially bust the cache of all files: 8a1d5b9

We will test and see if this has any negative implications in the perception of startup time when using the file explorer. If it does, we might want to revisit this and use a more appropriate client side cache management solution, such as including a fixed constant (timestamp) in the asset URLs which could be set when the app is started.

OSC/ood-fileexplorer#24 for a complete list of files to cache bust

┆Issue is synchronized with this Asana task by Unito

The title says it all. There is DOI :

http://dx.doi.org/10.1145/2949550.2949644

but this leads to an error page that says there is no such DOI. Could you check & correct this?

Most of this shouldn't be in the controller and the respective parts should be refactored to the respective Template or Manifest models.

┆Issue is synchronized with this Asana task by Unito

On smaller screens, the master/detail view pushes the data to the bottom.

It's probably possible to move this to the top using bootstrap push/pull, but we're bumping this into an issue for now.

┆Issue is synchronized with this Asana task by Unito

CloudCommander offers a "copy/paste" ability which lets you copy to a "clipboard a list of files so you can "paste" i.e. do a copy of those files from one location of the file system to another.

Since you can't see the clipboard contents, this feature is difficult to use.

If the clipboard contains contents, a "modal" should float above the right side of the panel that can be closed (which would clear the clipboard contents, thus hiding the display).

This is probably a feature best for when we rewrite the file explorer in ember.js

It might look something like this (but with pronounced dropshadow and bottom border):

┆Issue is synchronized with this Asana task by Unito

https://github.com/OSC/ondemand-testing/issues/12#issuecomment-223633113

@brianmcmichael wonders if the URL is # and the buttons are not being disabled properly

This could have buttons on it to do all the actions that you can only do via the context menus. This could also show extra details like file permissions, file owner, etc.

Version 2 of the editor could use Monaco instead of Ace

https://microsoft.github.io/monaco-editor/index.html

This has a diff mode that could be very useful, and auto-complete.

┆Issue is synchronized with this Asana task by Unito

The new validations protect against creating a new template with a folder size.

A user can create a small template and add a lot of data to it. Do we want to validate against this as well?

┆Issue is synchronized with this Asana task by Unito

Currently cloudcmd displays file permissions, but does not allow you to change them.

I've submitted an issue at coderaiser/cloudcmd#63

Additionally, node.js uses default file permissions of 0666 for uploads. This is unacceptable and will need to be changed to a default of at least 0644.

┆Issue is synchronized with this Asana task by Unito

When viewing a file in cloud commander, we get a simple text only popup view of the file. Instead, it would be better to open to a new window and have the browser handle the file appropriately. We could even handle files differently based on file type. This could be a separate route in Express that we add to handle this.

┆Issue is synchronized with this Asana task by Unito

This bug only appears to exist in MSEdge.

• Load page
• Click 'Open in Terminal' Button
  • No Response.
• Click a file or folder in the panel.
• Click 'Open in Terminal' Button
  • Works to spec.

Need to find out what I'm using to detect the current folder and find an option that works with Edge.

i.e. /jobs or a JobsController added to the dashboard

This will partly address AweSim-OSC/osc-ondemand#81 because the dashboard menu will be above this view. The javascript may need to be adjusted so that it affects only appropriate divs etc. on this page - of course it can be loaded on any other page.

Add a more detailed design/plan of integrating and any modifications required before proceeding.

There are no automated test for this app and it could benefit from appropriate tests.

As the user can't qpeek to observe status of running job. It might be best to have the templates send output to a log file instead of the batch output. That way the user can observe progress through the File Explorer app.

┆Issue is synchronized with this Asana task by Unito

Right now we show a preview of the script content for the selected submission script.

This would be more useful if it were an editable panel incorporating the Ace editor.

This feature currently GET's file content via the cloudcmd API. It could be saved by adding a button that PUT's edited content back to the API.

┆Issue is synchronized with this Asana task by Unito

We might want to prevent the user from shooting themselves in the foot, but we should also handle legal file names even if they have odd characters in them

┆Issue is synchronized with this Asana task by Unito

Dave requested a feature that allows a user to select favorite jobs and filter view by those favorites.

┆Issue is synchronized with this Asana task by Unito

Dave demonstrated a feature in Eclipse Parallel Tools that shows a view consisting of all of the nodes in a cluster. Each of those nodes is divided up into cores and they are color-coded and selectable based on the running jobs on that system.

He suggested an enhancement to the Job Status page that performs similar behavior.

When worrying about disk space usage, it would be nice to see and/or sort jobs disk usage in human readable format. This would allow the user to see jobs that need to be archived or deleted to more quickly free up space.

┆Issue is synchronized with this Asana task by Unito

Files are currently displayed in an unordered list.

Make a recursive algorithm to nest subfolders in the list, rather than displaying them all in one line.

Bonus points: format the list a little nicer.

┆Issue is synchronized with this Asana task by Unito

Add buttons allowing the user to put one of their jobs on hold or release it.

┆Issue is synchronized with this Asana task by Unito

The cloud commander UI uses its own API. It is mostly:

1. A list view of files and directories that you can select, double click, etc.
2. Context menus to do initiate various actions with the selected file or directory
3. Accept drops from the desktop to initiate file upload
4. Drag and drop from one commander view to another to cause some action to occur

1 & 2 probably very easy to implement using EmberJS or similar. 3 & 4 are big questions marks. But a clearer separation between the interface that we want to control and the cloud commander code we use would be very helpful.

┆Issue is synchronized with this Asana task by Unito

If we could track a "session" i.e. the state of the tree view associated with the "browser name" - so we could cache different tree view states on multiple browser windows, the user could reload the browser safely without losing the tree state. This is related to https://github.com/AweSim-OSC/osc-fileexplorer/issues/84 - where the file size gets out of date when the file is modified (if you modify a file using file editor or vim etc)

Needs design

Proposed design:

Add an indexed boolean column to the simulation or workflow model: legacy. Then do this on each request to the index page:

#pseudo code
unless Simulation.where(legacy: true).any?
  display "import" button if (File.exist?("~/crimson_files/JobConstructor") && Dir.glob("~/crimson_files/JobConstructor").length > 0)
end

Import button would be at top of page. The user can import old jobs by clicking the import button which will connect to mysql to read the user's information about their jobs and create corresponding database records. No files will be moved - the legacy jobs staged data would remain under ~/crimson_files/JobConstructor

┆Issue is synchronized with this Asana task by Unito

A template source is a directory whose subdirectories are job templates.

Currently there are two template sources: OSC Templates and My Templates. Alongside these fixed locations to find templates, let the user add extra paths to new template sources.

CustomSource and Source would share functionality. Ideally CustomSource would be a type of Source but also be ActiveRecord - so we would need to put some thought into the implementation to make this clean. The list of all templates would be extended to include Source.my.templates + Source.osc.templates + CustomSource.all.map(&templates) (pseudocode)

This would involve five UI changes:

1. Add /sources/new to create a new template source:

2.Add /sources/edit to edit a template source (that is not OSC or My Templates - ignore the fact that this screenshot shows editing that - it would actually only allow you to edit custom template sources):

1. Source dropdown would be added to the new job page with the options for adding or editing template sources added to this. Source dropdown would have (and default) to "All) showing all templates (as new job page currently does) or allow you to select a specific template source to view that. The edit button would be enabled if you select a custom template source. The add button would always be there:

Unfortunately, this would involve a schema change.

┆Issue is synchronized with this Asana task by Unito

Some of the users end up producing many many jobs. We might consider pagination in the main list of jobs.

┆Issue is synchronized with this Asana task by Unito

When I expand a row and then scroll down, I lose the context of the job:

We can use scrollspy to temporarily apply a "currently-viewing" class to when we scroll past the row so its out of view - this way the information in that row could be displayed:

You can do this if the "currently-viewing" class applies "position fixed" to the row, but determining the correct style modifications after you do that will take a little bit of time. This screenshot shows a quick example where I pop the row contents out, but it doesn't look ideal:

Though even this might be good enough. The styles I used to apply to this would be:

.currently-viewing {
    position: fixed;
    top: 0;
    z-index: 2000;
    background-color: white;
    border: 1px solid #ddd;

    /* round corner and add dropshadow */
    -webkit-box-shadow: 1px 1px 5px 0px rgba(0,0,0,0.75);
    -moz-box-shadow: 1px 1px 5px 0px rgba(0,0,0,0.75);
    box-shadow: 1px 1px 5px 0px rgba(0,0,0,0.75);
    -webkit-border-radius: 5px;
    -moz-border-radius: 5px;
    border-radius: 5px;
}

┆Issue is synchronized with this Asana task by Unito

This is possible, as the bootstrap styles don't conflict with the terminal.

However, the bright red is bothersome with the default black/dark colors - your eyes can't adjust well.

Could use the grey background like in the other apps but keep the ondemand menu. Easier on the eyes:

Yep. Gray is the best. I have modifications to add this cleanly.

So that you can change the "root" of the tree to be project space OR the home directory

We might want to think through this a little more because you might want to select some files and drag it to a project space directory in the tree. So you might want to be able to expand the root of the project space while looking in your home directory. But it could work like an accordion control, in that only one tree is open at a time.

Opening an issue to collect some ideas for a 2.0 version that we will open source with Open OnDemand.

We should identify features from these apps that would be helpful to include:

• file explorers like OS X's Finder and the uber Path Finder app http://www.cocoatech.com/pathfinder/
• sftp clients like Cyberduck, FileZilla, and WinSCP

For example, some features we should consider:

• drag and drop in the window and between window and tree

• favorites (like in Apple's finder)

• "actions" like "new folder" and "new file" or other things that work on the "current directory" (not the selection) could go in an actions button dropdown similar to apple's finder:

  

• embeddable "file picker" mode that we can use with other apps

• by adding a prefix, this puts the text before the number
• by unchecking the "increment by number" the name of the job directory is the name specified in "prefix" without any number following it
• Because the default is to name the directory a number "incremented by 1" the next unique number needs to be determined before this view is rendered.
• When submitting the form (after the user presses "Use selected template") the path we are copying to needs to be verified to not exist yet (i.e. unique) and a form validation error should be thrown if it does (i.e. a conflict) so the user can change this

┆Issue is synchronized with this Asana task by Unito

Currently double-clicking a folder with open the folder, however, double-clicking a file will cause no event.

It may not be difficult to implement a double click listener for files that triggers the view action.

There may be unintended consequenses though. What happens if I 'view' a very large file?

Along with customizing the directory names of the jobs themselves, a feature request was made by Kate to customize the project directory path. So every project directory would not appear in a subdirectory of ~/ondemand/data/sys/myjobs/projects but could be in the user's home directory, or perhaps even in shared project space.

The fact that we store absolute paths to scripts etc. right now means we would need to consider changing this to storing relative paths - relative to the project directories that contain them (or perhaps with the project directories in the path). But if the user could change the project directory name after the fact, this also creates possible complications. So there are some edge cases that need to be thought through for this.

┆Issue is synchronized with this Asana task by Unito

If we let the users specify a custom name for newly created jobs from templates, we don't do the same when the user just copies a job from another job - we might want to do this.

┆Issue is synchronized with this Asana task by Unito

Per Eric

It would be nice to have some sort of automated test to confirm that cloud commander can open this directory without throwing an error. Otherwise, if the app gets deployed somewhere else we will forget to update cloud commander's whitelist.

┆Issue is synchronized with this Asana task by Unito

And if we do this, consider "Enter" to open the selected directory

┆Issue is synchronized with this Asana task by Unito

Commandline tests I did: OSC/ood-myjobs#26 (comment)

Some of these would make easy unit tests. Such as:

irb(main):025:0> Filesystem.new.validate_path_is_copy_safe "/"
=> [false, "Timeout occurred when trying to determine directory size. Size must be computable in less than 10 seconds. Either directory has too many files or the file system is currently slow (if so, please try again later)."]

You would want to create one directory whose permissions were temporarily modified so that du might throw an error similar to what I did here:

irb(main):024:0> Filesystem.new.validate_path_is_copy_safe "/nfs/17/efranz/process/tmp/p4trunk"
=> [false, "Error with status pid 18730 exit 1 occurred when trying to determine directory size: du: cannot access `/nfs/17/efranz/process/tmp/p4trunk/.svn': Permission denied\ndu: cannot access `/nfs/17/efranz/process/tmp/p4trunk/p4_calico': Permission denied\ndu: cannot access `/nfs/17/efranz/process/tmp/p4trunk/p4': Permission denied\ndu: cannot access `/nfs/17/efranz/process/tmp/p4trunk/README': Permission denied\n"]And you would want a directory where you created some arbitrary file size and manually set the Filesystem `max_copy_safe_dir_size` to 1 byte and verified that it failed:```irb(main):026:0> Filesystem.new.validate_path_is_copy_safe "/nfs/17/efranz/crimson_files/FanPortal/fans"=> [false, "The directory is too large to copy. The directory should be less than 1073741824 bytes."]```And finally a directory that passed the test.Four simple tests would be sufficient.

┆Issue is synchronized with this Asana task by Unito

Or another ood gem. The final home of https://github.com/AweSim-OSC/osc-machete/blob/d124db819b596f49abec12b4783293e39ebf2919/lib/osc/machete/user.rb and https://github.com/AweSim-OSC/osc-machete/blob/d124db819b596f49abec12b4783293e39ebf2919/lib/osc/machete/process.rb

Copy a file and try to paste it in same directory. Possible solution is renaming it following a common scheme like "Copy of ...". Or possibly "file_1", "file_2", ...

┆Issue is synchronized with this Asana task by Unito