[REVIEW]: Mikrokosmos: an educational lambda calculus interpreter about jose-reviews HOT 38 CLOSED

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @aj2duncan it looks like you're currently assigned as the reviewer for this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/jose-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

1. Set yourself as 'Not watching' https://github.com/openjournals/jose-reviews:

2. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

from jose-reviews.

Attempting PDF compilation. Reticulating splines etc...

from jose-reviews.

--> Check article proof 📄 <--

from jose-reviews.

OK, @RobertTalbert — I manually added a second review checklist above. We're good to go.

👋 @aj2duncan, @MattForshaw — Thank you for agreeing to review for JOSE! This is where the action happens. Each of you has a review checklist above. Feel free to ask questions here, and to open new issues on the submission's repository, if you feel the need.

from jose-reviews.

I've had some difficulty getting the Jupyter Notebook version working on Windows. Please see mroman42/mikrokosmos#45 Anyone else have this problem?

Command line version installs and works just fine.

from jose-reviews.

Suggesting the authors add a more prominent statement where users should seek support. mroman42/mikrokosmos#47

from jose-reviews.

@RobertTalbert I'm not entirely sure how it works from here but I'm pretty happy that @mroman42 has satisfied the only issue I had. I really like the project and think the documentation is very good. Let me know if you need anything else from me.

from jose-reviews.

Likewise, @mroman42 addressed my comment very quickly. I am very happy for this to proceed.

from jose-reviews.

Do I take it that both reviewers are recommending publication, at this point?

from jose-reviews.

Hi @labarba; yes I'm recommending publication. Many thanks, Matt

from jose-reviews.

Hi @labarba - same here. Thanks.

from jose-reviews.

OK.

👋 @RobertTalbert --- You can give the paper an editorial check now, suggest any improvements you'd like to see, and then let me know you're ready to accept.

from jose-reviews.

Will do, probably early next week. (Drowning in Assistant Chair duties right now - remind me why I signed up to do that?)

from jose-reviews.

@labarba I've had a look at the paper and have no other suggestions, so I think this one is good to go.

from jose-reviews.

@whedon generate pdf

from jose-reviews.

Attempting PDF compilation. Reticulating splines etc...

from jose-reviews.

👉 Check article proof 📄 👈

from jose-reviews.

@mroman42 — could you tweak the paper as follows?

1. paragraph 3: "Following (Barendregt, 1984)" ... if the reference is part of the sentence, it should be formatted as: "Following Barendregt (1984)"

2. "as described in (De Bruijn, 192)" ... here, you can remove the "as described in" and simply put the reference at the end of the sentence. It will make it more readable, given the large distance you have between subject and verb ("works").

3. "standard algorithm from (Hindley & Seldin, 2008)" ... same as 1.

4. "see (Sorensen & Urzyczyn, 2006)" ... same.

5. "textbooks such as (Wadler, 2015) or (Girard, Taylor, & Lafont, 1989)" ... same

6. page 2: "installation and usage instructions ... are also described" ... change verb to "given" or "provided"?

7. "described in (Wadler, 2015)" ... "depicted in (Wadler, 2007)" ... "justified in (Danierlson, Hughes, Jansson, & Gibbons, 2006)" ... same as 1.

8. Find other examples in page 3.

from jose-reviews.

In summary, when the citation is part of the sentence, then use: Author (year). If the citation is not part of the sentence, then it should appear in parenthesis.
E.g.

• "We take inspiration from Smith et al. (2006) to ... "
• "The code implements Theory 1 (Jones 2012) and Theory 2 (Roberts 2014) to obtain ... "

For the syntax to obtain brackets in the right places, see: https://rmarkdown.rstudio.com/authoring_bibliographies_and_citations.html

from jose-reviews.

Thank you very much. Commit mroman42/mikrokosmos@a5e9c87 addresses these corrections and changes some propositions to make the name of the author appear as part of the sentence. Please let me know if any other change is required.

from jose-reviews.

@whedoon generate pdf

from jose-reviews.

@whedon generate pdf

from jose-reviews.

Attempting PDF compilation. Reticulating splines etc...

from jose-reviews.

👉 Check article proof 📄 👈

from jose-reviews.

@mroman42 — apologies for the delay (I just came back this weekend from a three-talk tour and I was slammed).

We're ready to publish your submission, once you deposit an archive on Zenodo (or a similar service: Figshare, Dryad, etc.). Once you get a DOI for the archive, give it to us here, and we'll publish your JOSE paper!

from jose-reviews.

If I have done everything correctly (please let me know if something else is needed) the DOI is 10.5281/zenodo.1470226 (https://zenodo.org/record/1470226).

@labarba @RobertTalbert @aj2duncan @MattForshaw Thank you very much for all the feedback; it has been very useful for the project.

from jose-reviews.

Almost ... the author list on the Zenodo archive does not match the author list of the paper. On Zenodo, we have "Mario Román; Pedro A. García-Sánchez" ... on the JOSE paper, just Mario Román. You may need to manually change the metadata in the Zenodo entry.

from jose-reviews.

Thank you; I have manually changed the metadata. https://zenodo.org/record/1470226

from jose-reviews.

@whedon set 10.5281/zenodo.1470226 as archive

from jose-reviews.

OK. 10.5281/zenodo.1470226 is the archive.

from jose-reviews.

@whedon accept

from jose-reviews.

Attempting dry run of processing paper acceptance...

from jose-reviews.

Check final proof 👉 openjournals/jose-papers#3

If the paper PDF and Crossref deposit XML look good in openjournals/jose-papers#3, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

from jose-reviews.

@whedon accept deposit=true

from jose-reviews.

Doing it live! Attempting automated processing of paper acceptance...

from jose-reviews.

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSE! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited 👉 openjournals/jose-papers#4
1. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/jose.00029
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

from jose-reviews.

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://jose.theoj.org/papers/10.21105/jose.00029/status.svg)](https://doi.org/10.21105/jose.00029)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/jose.00029">
  <img src="https://jose.theoj.org/papers/10.21105/jose.00029/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://jose.theoj.org/papers/10.21105/jose.00029/status.svg
   :target: https://doi.org/10.21105/jose.00029

This is how it will look in your documentation:

We need your help!

Journal of Open Source Education is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://jose.theoj.org/reviewer-signup.html
• Making a small donation to support our running costs here: https://www.flipcause.com/secure/cause_pdetails/Mjk3ODA=

from jose-reviews.

This paper is now published in JOSE !!!

@aj2duncan, @MattForshaw — Thank you for your review and being a part in this adventure in new publishing!

from jose-reviews.