Giter Club home page Giter Club logo

Comments (10)

AshokDaparthi avatar AshokDaparthi commented on July 17, 2024

from sai.

vkochan-mlnx avatar vkochan-mlnx commented on July 17, 2024

So my understanding is that we do not have to specify SAI_SCHEDULER_GROUP_ATTR_PARENT_NODE for the level 0 ?

from sai.

AshokDaparthi avatar AshokDaparthi commented on July 17, 2024

from sai.

vkochan-mlnx avatar vkochan-mlnx commented on July 17, 2024

So then it is not needed to have SAI_OBJECT_TYPE_PORT in @objects section ? Or it is needed to handle
multiple cases:

1) level=0, parent_node=port
2) level=0, parent_node is not specified, so the port from the "port" attribute is used

?

from sai.

vkochan-mlnx avatar vkochan-mlnx commented on July 17, 2024

@lguohan Would you please give some clarification on this ? As it is till not clear for me.

Thanks,

from sai.

lguohan avatar lguohan commented on July 17, 2024

it seems redundant, you can add metadata conditional on level > 0 to make this attribute conditional. and then remove the SAI_OBJECT_TYPE_QUEUE

from sai.

vkochan-mlnx avatar vkochan-mlnx commented on July 17, 2024

thanks, but you meant to remove SAI_OBJECT_TYPE_PORT ?

from sai.

kcudnik avatar kcudnik commented on July 17, 2024

currently condition operator supports only "==" but there is a plan do add other operators, but this will complacate comparison logic logic,
you can live in description proper condition restriction, and for now if you want force it you can and each condition as " level == 1 or level == 2 or level == 3" how many levels we can have right now ? 8? 16?

from sai.

kcudnik avatar kcudnik commented on July 17, 2024

anywy, i already saw on other vendors implementation that level 0 is implemented correctly anyway pointing to port

from sai.

lguohan avatar lguohan commented on July 17, 2024

sorry for the typo, yes, remove SAI_OBJECT_TYPE_PORT

from sai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.