outside the range of type ‘sai_object_type_t’ about sai HOT 8 CLOSED

i already merged that on master for object_type and api, so you can build on that

from sai.

yes, probably a bug, can you give link to commit? i will pull that locally and fix that

from sai.

yes, probably a bug, can you give link to commit? i will pull that locally and fix that

I've commit my code to oplklum@54c18db
Please have a test, thanks.

from sai.

thanks, i cherry picked that, seems like gcc compiler internally chooses some 7 bit size to store enum values for sai_object_type_t, even that sizeof(sai_object_type_t) is sizeof(int32_t), and error pops up on cpp, not C, i'm not sure how to elegantly fix this, i can add pragam to ignore this conversion, but im not sure if this could have some implications later, if at some point compiler will decide to actual 7 bits, at some operations, actual proper solution would be to have actualy 128 entries in sai_object_type_t, or some extra enum value that will set this specific bvalue, like a placeholder, but this will mess up current logic

from sai.

i tried to add

#pragma GCC diagnostic ignored "-Wconversion"

but seems like gcc is ignoring this pragma, since warning is still present if that pragma is applied, not sure if this is gcc bug or a feature

it's present on newest gcc https://godbolt.org/z/8Mdse7jva

from sai.

@oplklum i added temporary workaround: #1926, you can cherrypick that and try to build and test locally, but we need to discuss this change on Thursday SAI community meeting

from sai.

@kcudnik I'm sorry for the late response. #1925 is all right now, but the same problem happened for sai_api_t.

#define SAI_API_EXTENSIONS_MAX ((sai_api_t)69)

I guess the actual bits is 6, so when it's >= 64, an same error reported. I add custom range as below for temporary pass. Please know.

SAI_API_MAX,                   /**< total number of APIs */
SAI_API_CUSTOM_RANGE_START = 256,
SAI_API_CUSTOM_RANGE_END

} sai_api_t;

from sai.

ok, i will update that

from sai.