Comments (9)
kcudnik
commented on July 18, 2024
1
reproduced, as i thought it was cherrypicked the commit, problem is taht we dont have pipeline setup on other branches only master, so only master is checked, I fixed it here #2019
from sai.
kcudnik
commented on July 18, 2024
Each commit is checked before merge to pass build, this what you are referring to should not be possible, unless that was cherry picked somehow
from sai.
aparkhomenko-xsight
commented on July 18, 2024
steps to reproduce
- git clone https://github.com/opencomputeproject/SAI.git
- cd SAI
- git checkout v1.11
- cd meta
- make
from sai.
aparkhomenko-xsight
commented on July 18, 2024
I also tried to build SONiC 202311 and got the same issue (commit 96143ee)
and finally I found it happens even on previous commit before 767c325
from sai.
kcudnik
commented on July 18, 2024
interesting, we have automatic builds setup on sonic branches which would fail build if this is happening, not sure how we build sonic now XD
from sai.
k-v1
commented on July 18, 2024
not sure how we build sonic now XD
make saimetadata.c
doxygen Doxyfile 2>&1 | perl -npe '$e=1 if /warning/i; END{exit $e}'
touch xml
perl -I. parse.pl
Processing capability file sample.cap
Skipping cap file sample.cap
Running Aspell
Words to check: 3248
Processing sai_8h.xml
Removing last element SAI_API_MAX
Processing saiacl_8h.xml
Creating range attrs SAI_ACL_TABLE_ATTR_USER_DEFINED_FIELD_GROUP_MIN .. MAX
Limiting range from 255 to 10
Creating range attrs SAI_ACL_ENTRY_ATTR_USER_DEFINED_FIELD_GROUP_MIN .. MAX
Limiting range from 255 to 10
Processing saiars_8h.xml
Processing saiarsprofile_8h.xml
Processing saibfd_8h.xml
Processing saibridge_8h.xml
Processing saibuffer_8h.xml
Ignoring SAI_BUFFER_PROFILE_ATTR_BUFFER_SIZE
Processing saicounter_8h.xml
Processing saidebugcounter_8h.xml
Processing saidtel_8h.xml
Removing last element SAI_DTEL_EVENT_TYPE_MAX
Processing saiexperimentalbmtor_8h.xml
Processing saiexperimentaldashacl_8h.xml
Processing saiexperimentaldashdirectionlookup_8h.xml
Processing saiexperimentaldasheni_8h.xml
Processing saiexperimentaldashinboundrouting_8h.xml
Processing saiexperimentaldashmeter_8h.xml
Processing saiexperimentaldashoutboundcatopa_8h.xml
Processing saiexperimentaldashoutboundrouting_8h.xml
Processing saiexperimentaldashpavalidation_8h.xml
Processing saiexperimentaldashvip_8h.xml
Processing saiexperimentaldashvnet_8h.xml
Processing saiextensions_8h.xml
Processing saifdb_8h.xml
Processing saigenericprogrammable_8h.xml
Processing saihash_8h.xml
Processing saihostif_8h.xml
Ignoring SAI_HOSTIF_USER_DEFINED_TRAP_TYPE_NEIGH
Processing saiipmc_8h.xml
Processing saiipmcgroup_8h.xml
Processing saiipsec_8h.xml
Processing saiisolationgroup_8h.xml
Processing sail2mc_8h.xml
Processing sail2mcgroup_8h.xml
Processing sailag_8h.xml
Processing saimacsec_8h.xml
Ignoring SAI_MACSEC_SA_ATTR_XPN
Ignoring SAI_MACSEC_SA_ATTR_MINIMUM_XPN
Processing saimcastfdb_8h.xml
Processing saimetadatalogger_8h.xml
Processing saimetadatatypes_8h.xml
Processing saimetadatautils_8h.xml
Processing saimirror_8h.xml
Processing saimpls_8h.xml
Processing saimymac_8h.xml
Processing sainat_8h.xml
Processing saineighbor_8h.xml
Processing sainexthop_8h.xml
Processing sainexthopgroup_8h.xml
Ignoring SAI_NEXT_HOP_GROUP_TYPE_ECMP
Processing saiobject_8h.xml
Processing saipoe_8h.xml
Processing saipolicer_8h.xml
Processing saiport_8h.xml
Removing last element SAI_PORT_BREAKOUT_MODE_TYPE_MAX
Removing last element SAI_PORT_INTERFACE_TYPE_MAX
Processing saiportextensions_8h.xml
Processing saiqosmap_8h.xml
Processing saiqueue_8h.xml
Processing sairoute_8h.xml
Processing sairouterinterface_8h.xml
Processing sairpfgroup_8h.xml
Processing saisamplepacket_8h.xml
Processing saischeduler_8h.xml
Processing saischedulergroup_8h.xml
Processing saiserialize_8h.xml
Processing saisrv6_8h.xml
Processing saistatus_8h.xml
Processing saistp_8h.xml
Processing saiswitch_8h.xml
Ignoring SAI_SWITCH_ATTR_PORT_NUMBER
Ignoring SAI_SWITCH_ATTR_SHUTDOWN_REQUEST_NOTIFY
Processing saiswitchextensions_8h.xml
Processing saisystemport_8h.xml
Processing saitam_8h.xml
Processing saitunnel_8h.xml
Processing saitwamp_8h.xml
Processing saitypes_8h.xml
Removing last element SAI_COMMON_API_MAX
Removing last element SAI_OBJECT_TYPE_MAX
Ignoring SAI_ACL_BIND_POINT_TYPE_ROUTER_INTF
Removing last element SAI_PORT_ERR_STATUS_MAX
Processing saitypesextensions_8h.xml
Processing saiudf_8h.xml
Processing saiversion_8h.xml
Processing saivirtualrouter_8h.xml
Processing saivlan_8h.xml
Processing saiwred_8h.xml
no need for END enum for SAI_IN_DROP_REASON_CUSTOM_RANGE_BASE
no need for END enum for SAI_OUT_DROP_REASON_CUSTOM_RANGE_BASE
non range base SAI_UDF_ATTR_BASE
from sai.
kcudnik
commented on July 18, 2024
can you elaborate more ?
from sai.
k-v1
commented on July 18, 2024
can you elaborate more ?
As I understand, when we build SONiC (e.g. syncd) we don't validate SAI headers (don't run ./checkenumlock.sh, etc). We just generate saimetadata.c and saimetadata.h. I'm not sure if it's expected behaviour or not, but it's the main reason why we don't catch this error with SONiC builds.
from sai.
kcudnik
commented on July 18, 2024
thats intended, i put it there, since all validation checks should be done on SAI repo on each commit, this issue actually has no impact on sonic, build error on v1.11 is because value MAX is not excluded from backward compatybility check
from sai.
Related Issues (20)
- SAI_API_MPLS not supported for Mellanox/Nvidia Spectrum chips
- Possible SAI API struct *_api_t mismatch
- Question: Google Proto Buff for SAI-RPC available? HOT 10
- Correct version in saithrift package HOT 3
- Too many saithrift servers in SAI repo HOT 18
- buffer overflow vulnerability in sai_serialize_attribute function HOT 3
- Unused code? HOT 3
- Some generated metadata items are not binary backward compatible HOT 1
- Query: Shared threshold mode for the buffer profile HOT 5
- wrong size of sai_acl_capability_t HOT 3
- outside the range of type ‘sai_object_type_t’ HOT 8
- WEIGHT is valid for SAI_SCHEDULING_TYPE_WRR as well
- How to generate test report for SAI PTF test case
- test
- Clarification on Conflicting Actions Resolution in ACL Table HOT 5
- [information request] do we have a way to set the type of hash algo?
- Get vendor specific version information from SAI HOT 5
- saithrift build issue for bookworm HOT 1
- GCC 12 error in saimetadatatest.c HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sai.