off-piste / trolley.io-cocoa Goto Github PK

🛒 Trolley is a new e-commerce mobile development platform

License: MIT License

Ruby 1.12% Swift 96.82% Objective-C 1.90% Shell 0.15%

trolley.io-cocoa's Introduction

Trolley

Trolley is e-commerce system that allows users to create fast and easy to use iOS Shops without having to wait time building a server

Features

Mobile Friendly: Many competitors forget about handheld devices, we don't. Never again will you have to use someones Shopify wrapper to build your iOS store.
Swift Built: This allows all the fun parts of Swift coding to come into play, less crashes and more fun.
ObjectiveC Support: To help with developers who still love ObjectiveC, they can still use our SDK, some things are missed out but still as fun to use.
Promise Kit: Built around promise kit, so all the async code runs perfectly

Getting Started

Please see our documentation for examples: ObjectiveC, Swift

Installation

Trolley is available through CocoaPods. To install it, simply add the following line to your Podfile:

pod "Trolley"
pod "Trolley/Database" # For the Product/Basket Management

# Coming Soon
pod "Trolley/Notification" # For Notifications
pod "Trolley/Delivery" # For Delivery Tracking
pod "Trolley/UI" # For UI Elements and nice items
pod "Trolley/ARKit" # Name is the clue

Documentation

For now, until the website is up and running, all documentation will be stored here:

Contributing

See CONTRIBUTING.md for more details!

Author

harrytwright, [email protected]

License

Trolley is available under the MIT license. See the LICENSE file for more info.

trolley.io-cocoa's People

Contributors

Watchers

trolley.io-cocoa's Issues

[Proposal 0001] Remove .responseProducts(handler:) & .responseProducts()

Remove `.responseProducts(handler:)` and `.responseProducts()` from Networking

Introduction

Currently, for both swift and Objective-C developers their is .responseProducts(handler:) and .responseProducts() methods, that downloads the JSON from their node and converts it to the [Product]

TRLNetworkManager.shared.get(.products).responseProducts(handler: { response in
    switch response {
    case .error(let error):
        /* ... */
    case .response(let rawres):
        /* ... */
    }
})

TRLRequest *request = [[TRLNetworkManager shared] getDatabase:TRLDatabaseProducts];
[request responseProductsWithBlock:^(NSArray<TRLProduct *> *products, NSError *error) {
    if (error) {
        /* ... */
    } else {
        /* ... */
    }
}];

Motivation

This I now feel makes the app, too easy to use, and takes away from a developer adding there touch with extending our code, thats why I feel like removing them from Networkable and just having the responseJSON(handler:) in it's place and with the JSON initialisers from Product it can be as easily re-added via an extension of Networkable for developers is they so wish

Network Calls Returning Empty Error

Issue

This will be the basis of how all issues should be submitted

The Issue is that somewhere down the line an Error in a callback gets 'nilled' which gives the code a false sense of success with network calls so it will make it seem like it passed even though it didn't which lead to a crash.

Note:
The old Networking didn't hit this, so thats the best place to start looking

Expected Result

The code was meant to hit an error, as the sever is meant to be down, so the code should react to this by sending me an error upon it reaching the call back.

Actual Result

The error was nil, which gave the impression of that the server was working even when I had the TRL console telling me the sever was down.

Code used to create this issue

TRLRequest *request = [[TRLNetworkManager shared] getDatabase:TRLDatabaseProducts];
[request responseProductsWithBlock:^(NSArray<TRLProducts *> *products, NSError *error) {
    if (error) {
        NSLog(@"[Vivacity] %@", error.localizedDescription);
        return;
    }
    /* ... */
 }];

Details

OS: iOS 10.3
Dependency Manager: Cocoapod

ProductName:	Mac OS X
ProductVersion:	10.12.5
BuildVersion:	16F73

1.2.0.beta.3
 Trolley (0.1.0):
 Trolley/Core (0.1.0):
 Trolley/Database (0.1.0):

/Applications/Xcode.app/Contents/Developer
Xcode 8.3.3
Build version 8E3004b