Giter Club home page Giter Club logo

currency-exchange's Introduction

Hi there, I'm Osman ๐Ÿ‘‹

๐ŸŒŒ About Me

I am a highly motivated and experienced Front-End Developer with over ten years of expertise in web and mobile application development. My passion lies in creating websites and mobile apps that grab people's attention and engage users. I have a strong desire for continuous learning, allowing me to quickly adapt to new technologies and deliver exceptional user experiences. In the fast-paced world of digital technology, I stay updated with the latest trends and changes, ensuring that my work remains current and relevant. I am dedicated to writing clear and efficient code, which not only enhances my own productivity but also enables seamless collaboration within diverse teams.

๐ŸŒŸ Notable Projects

:octocat: Websites

๐Ÿ”ง Skills

Skills

currency-exchange's People

Contributors

dependabot[bot] avatar ofcyln avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

currency-exchange's Issues

Responsive UI needs to be improved

Describe the bug
There are unstable padding behaviours on mobile phone screens.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Mobile'
  2. Click on amount and enter an amount then select currency and counter currency then press convert button
  3. See the unstable paddings around the result texts.

Expected behavior
There should be same paddings between elements and components.

Desktop (please complete the following information):

  • OS: iOS and Windows
  • Browser: Chrome
  • Version: 74

Smartphone (please complete the following information):

  • Device: iPhone 6s
  • OS: iOS
  • Browser: Chrome
  • Version: 74

Additional context

Smooth scroll behaviour

It would be good to make users feel in a native mobile app while scrolling long contents.

Unit test integrations for the components

Is your feature request related to a problem? Please describe.
For future coverage report integration with the minimum amount of 80% of code coverage, unit tests needs to be integrated to all of the components and services.

PWA UI improvements

Is your feature request related to a problem? Please describe.
When running on mobile, app always shows installation banner.

Describe the solution you'd like
Arrange the UI to make proper checks and change banner to button offer.

Typing currency bug

Describe the bug
Only typing the currency code results in an undefined fromControl element, which stops the conversion action.

To Reproduce
Steps to reproduce the behavior:

  1. enter amount value,
  2. enter from currency value (without selecting)
  3. enter to currency value (without selecting)
  4. See error in console

Screenshots
image

Enter button logic

On currency selection input there is already a typeahead but it would be perfect if user press Enter key to choose upmost currency sign.

Date range selection problems

Describe the bug
Date range integration has problems when the year changes.
Also, there is a problem with month changes. The actual range is not showing correctly for different months.

UI problems on mobile

Describe the bug
When using the app on mobile as a tab in browser or as a PWA, there are some problems which make the app look like unusable.

To Reproduce
Use it on mobile.

Expected behavior
UI should not be on top of each other.

Smartphone (please complete the following information):

  • Device: iPhone 6s
  • OS: 13.3.1
  • Browser: Safari, Chrome, Brave

Angular v9 update

Describe the solution you'd like
Update Angular to v9 with dependecies that used in the app.

Unstable behaviour in time interval selection

There is an unstable behaviour when the user selects time interval if there are differences between months and years. The code needs to be refactored to check all of the possible scenarios of that.
To simulate this behaviour, the developer can modify the Local Storage exchangeRates object with custom dates.

Design horizontal alignment of the UI for the mobile devices

Describe the bug
The mobile horizontal view is buggy.

To Reproduce
Steps to reproduce the behavior:

  1. Open the app on your mobile phone.
  2. Hold your phone horizontally.
  3. You'll see the problematic UI.

Expected behavior
There should be a user-friendly UI implementation. Reasonable gaps alongside eye-catching UI element positions.
Within the visible area of the screen, the user needs to do the main currency conversion without scrolling.

Screenshots
Screenshot 2021-04-19 at 22 53 06

Code coverage integration to the project

Is your feature request related to a problem? Please describe.
Integration of suitable code coverage for unit tests with minimum 80% of codes needs to be covered.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.