Add TypeScript typings about cjs-module-lexer HOT 7 CLOSED

@SimenB I can get behind unifying the APIs to do that sure. That sounds like a good suggestion to me.

from cjs-module-lexer.

Cool. I can send a couple of PRs tomorrow if you don't get to it.

Current thinking is init should just be Promise.resolve() so you know you can always call it. Without worrying about what API

from cjs-module-lexer.

Thanks for the PRs! I've published a 0.6.0 with these.

from cjs-module-lexer.

I've marked this as an enhancement issue and will leave it open here. If anyone would like to contribute please do.

from cjs-module-lexer.

I was gonna send a PR since the types aren't too advanced, but it seems the functions are different between CJS and ESM with CJS having parse and ESM having {init, parse}.

Thoughts on changing the API to be the same across module types? I.e. changing CJS to

module.exports.parse = parseCJS;
module.exports.init = () => Promise.reject(new Error('init is not supported when using CommonJS'));

Could potentially just no-op in the last one, or warn?

from cjs-module-lexer.

Some time freed up tonight, so sent #27 & #28 👍

from cjs-module-lexer.

Thanks @guybedford!

from cjs-module-lexer.