<div class="highlight highlight-source-js notranslate position-relative overflow-auto" dir="auto" da

I met same problem, and there are some types can be detected. <div class="highligh

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Probably because of <div class="Box-header

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

<a class="user-mention notranslate" data-hovercard-type="user" data-hover

Bug: cannot detect exported numbers about cjs-module-lexer HOT 5 CLOSED

nodejs commented on July 4, 2024

Bug: cannot detect exported numbers

from cjs-module-lexer.

Comments (5)

wangchuan95 commented on July 4, 2024

I met same problem, and there are some types can be detected.

module.exports = {
  a: true,
  b: null,
  c: undefined,
  d: function () {},
};

from cjs-module-lexer.

jaggli commented on July 4, 2024

@guybedford why did you add the "wontfix" tag? The same goes for

module.exports = {
  a: "a",
  b: 'b'
};

The exports are just empty.

from cjs-module-lexer.

aduh95 commented on July 4, 2024

Probably because of

cjs-module-lexer/README.md

Line 19 in 182e276

 _Detection patterns for this project are **frozen**_. This is because adding any new export detection patterns would result in fragmented backwards-compatibility. Specifically, it would be very difficult to figure out why an ES module named export for CommonJS might work in newer Node.js versions but not older versions. This problem would only be discovered downstream of module authors, with the fix for module authors being to then have to understand which patterns in this project provide full backwards-compatibily. Rather, by fully freezing the detected patterns, if it works in any Node.js version it will work in any other. Build tools can also reliably treat the supported syntax for this project as a part of their output target for ensuring syntax support. 

from cjs-module-lexer.

jaggli commented on July 4, 2024

@hanayashiki why closing it? The lexer is wrong... It's not about adding new detection patterns, it's about "not crashing when some funny values show up". I mean, we don't care about values (of any case if an object literal is exported..)

Would you like me to do a PR? I could fix it, but i want to make sure, if it has any chance to be merged...

from cjs-module-lexer.

hanayashiki commented on July 4, 2024

@hanayashiki why closing it? The lexer is wrong... It's not about adding new detection patterns, it's about "not crashing when some funny values show up". I mean, we don't care about values (of any case if an object literal is exported..)

Would you like me to do a PR? I could fix it, but i want to make sure, if it has any chance to be merged...

it says no new patterns should be added. And I don't think the lexer should crash in any cases

from cjs-module-lexer.

Recommend Projects