Rollup ^3.0.0 cjs re-exports edge case with externalLiveBindings: false about cjs-module-lexer HOT 8 CLOSED

Thanks for reporting. Per the policy on this project, the patterns supported were fully stabilized at the point this library started shipping, so that no new detections will be added. Otherwise that risks code that works in new Node.js versions mysteriously breaking in older versions and that would be very very difficult to debug.

I've posted a PR in #80 to better explain this as part of the project status.

from cjs-module-lexer.

/cc @lukastaegert

If Node.js will no longer update the detection mechanism, maybe Rollup will have to adapt to this case? I think it comes down to the use of for ... in vs Object.keys(...).forEach(...).

from cjs-module-lexer.

Unfortunately that basically is the situation today - where build tools do have to accept these semantics as part of their targets now. It's ended up the lesser of the evils, and my apologies we couldn't do better!

from cjs-module-lexer.

esbuild ended up just using a hinting pattern itself - #46

from cjs-module-lexer.

I think the change was done to allow some level of improved ES3 compatibility via this option. But I see that this is only affecting a very minor group of users and since .forEach can easily be polyfilled, I will revert it to the other pattern.

from cjs-module-lexer.

Actually, looking at this longer, it was not about ES3 compatibility. I wanted to switch to the other pattern altogether because it is smaller and more performant, but it cannot be used for live bindings because var k is being reassigned. If you allow const, then it will also use a for..in loop with live-bindings: https://rollupjs.org/repl/?version=3.11.0&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQSUyMiUyMiUyQyUyMm1vZHVsZXMlMjIlM0ElNUIlN0IlMjJjb2RlJTIyJTNBJTIyZXhwb3J0JTIwKiUyMGZyb20lMjAnZm9vJyUyMiUyQyUyMmlzRW50cnklMjIlM0F0cnVlJTJDJTIybmFtZSUyMiUzQSUyMm1haW4uanMlMjIlN0QlNUQlMkMlMjJvcHRpb25zJTIyJTNBJTdCJTIyb3V0cHV0JTIyJTNBJTdCJTIyZm9ybWF0JTIyJTNBJTIyY2pzJTIyJTJDJTIyZ2VuZXJhdGVkQ29kZSUyMiUzQSU3QiUyMmNvbnN0QmluZGluZ3MlMjIlM0F0cnVlJTdEJTdEJTdEJTdE

But yes, I will revert this change.

from cjs-module-lexer.

Fix at rollup/rollup#4826

from cjs-module-lexer.

Thanks @lukastaegert - I will close this one now.

from cjs-module-lexer.