Giter Club home page Giter Club logo

rsnt-really-simple-note-taking-ios's Introduction

rsnt-really-simple-note-taking-ios's People

Contributors

nlharri avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

rsnt-really-simple-note-taking-ios's Issues

Thank you for your code sample & some suggestion

Hi László Harri,

Thank you for your clear & simple code example. It enables me to learn CoreData concept easier.

However, I do have some suggestion on the sample code.

I notice you are using the following code, to "return back" to MasterViewController from ReallySimpleNoteCreateChangeViewController

    // navigate back to list of notes
    performSegue(
        withIdentifier: "backToMasterView",
        sender: self
    )

However, by doing so, a new MasterViewController will be created each time, with old MasterViewController still remain in memory stack. This can be confirmed, by adding some debug message in MasterViewController's init and deinit

    required init?(coder aDecoder: NSCoder) {
        super.init(coder: aDecoder)
        print("MasterViewController init")
    }
    
    deinit {
        print("MasterViewController's deinit")
    }

We will observe that init being called multiple times, and deinit never being called. Very soon. Out of memory may occur. I guess, we should use an unwind segue.

For

private var noteIndexToIdDict : [Int:UUID] = [:]

May I suggest that using

private var noteIds : [UUID] = []

We may use the Int index to perform direct array access.

I appreciate your tutorial and code sample. It enables me to kick start learning Core Data with less pressure.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.