ngxs / cli Goto Github PK

hi,

in our security checks, the glob-parent version used for ngxs/cli is flagged as highly critical. since the last version of ngxs/cli has been published 4 years ago, is there a change for an update that would fix this issue?

thanks.

Firstly, thanks to all involved on your wonderful work on NGXS!

The generated code (from this CLI) contains a class for the state model, which seems to go against the NGXS style guide / recommendations (ref: https://www.ngxs.io/recipes/style-guide#avoid-saving-class-based-instances-in-your-state) which suggest that interfaces (and thus plain JS objects) should be used.

Just wondering if this is intentional, or just something that needs tweaking in the CLI? Let me know and I'd be happy to submit a PR to make the change.

Hi,

when I launch
npm i @ngxs/cli -g

I receive

npm ERR! code E404
npm ERR! 404 Not Found: @ngxs/cli@latest

Affected Package

@ngxs/cli

Is this a regression?

No, this issue has been ever since I started using ngxs cli version

Description

The code generated by ngxs-cli includes non-breaking space characters (nbsp), and the spec utilizes deprecated code.
I'm writing an intellij/webstorm plugin for ngxs. It would be nice to have the ngxs cli working correctly.

🔬 Minimal Reproduction

1. Follow the steps here -> https://www.ngxs.io/plugins/cli to install @ngxs/cli.

2. Generate a store using ngxs cli command

ngxs --name mystore --spec true --folder-name mystore

3. Now examine the generated files.

my-store.state.ts:

The injectable import contains NBSP in it.

my-store.state.spec.ts

Uses deprecated code. I would additionally modify the boilerplate test case to simply verify the truthiness of the state. The default test case isn't particularly helpful.

Libs:

• @angular/cli version: 2.0.0
• @ngxs/store version: 3.8.0

Browser: N/A

For Tooling issues:

• Node version: v16.17.0
• npm version - 9.3.1
• Platform: MacOS Apple M1 Pro - Ventura

@splincode We would be very grateful if you could publish the latest changes to npm, since we cannot use the client currently due to a high risk warning re the glob-parent version used by node-plop.

Thanks in advance. 💐