naluinui / eggrating Goto Github PK

To allow this to work from a view controller written in Objective-C, could you add @objc to all public properties of the EggRating class and to the EggRatingDelegate protocol?

By default both daysUntilPrompt and remindPeriod are 10, but if you set a lower daysUntilPrompt it will be ignored in favor of the remindPeriod because the lastRemind variable is set to the date you first call the shouldPromptForRating method.

For example, I want to prompt the user for a rating two days after downloading the app, but then not bother them again until 10 days after they've ignored the rating prompt. Although I have daysUntilPrompt set to 2, when first calling that method it sets lastRemind's date to now, so when it gets to the portion of the prompt check method "minutesFromLastRemind < minuteRemindPeriod", it returns false because it thinks I already received a reminder just now.

I fixed this in my forked repo by defaulting the lastRemind value to a date from the far past.

Hi naluinui,

you commited "Some changes EggRatingViewController.swift " on your master, but in the podspecs you are telling to use tag 0.1.2. Could you maybe update the file?

Thx! :)

my application has been rejected because I use "import EggRating"

I wasn't actually using it. However, I still think it is rejected automatically because of EGGRATING.

Guideline 1.1.7 - Safety - Objectionable Content

“We noticed that your app includes content and features that can manipulate the user reviews or chart ranking on the App Store. Specifically, your app filters user reviews and only directs users who intend to rate your app 4 - 5 stars to complete a rating on the App Store.”