Giter Club home page Giter Club logo

pe's People

Contributors

myc37 avatar

Watchers

 avatar

pe's Issues

Description for notes about tags could be clearer

The UG states:

To indicate the priority level, simply follow the tag name by typing :p[1/2/3/4] after the tag name.

It is not clear here that the priority level and tag name have to be separated by a space, and users only learn this when they see the example given below.
I was confused when I tried to enter t/important:p1 and p1 became part of the tag name until I saw the given example.

Numeric client names are allowed

Steps to reproduce:

Use the command add n/123456 p/98765432 e/[email protected] a/John street, block 123,#01-01, i/package1

Expected result:

Throw an error indicating that the client name should contain alphabetical numbers and not numbers

Actual result:

Numeric client names are allowed

Screenshot:

image.png

Undo limit

Delete all clients then try to undo to get back the same address book

Expected to get default addressbook but only got back 4 clients

image.png

Numeric insurance package names are allowed

Steps to reproduce:

Use the command add n/John Doe p/98765432 e/[email protected] a/John street, block 123,#01-01, i/123456

Expected result:

Throw an error indicating that the insurance package name should contain some alphabetical characters, not just numbers

Actual result:

Numeric insurance package names are allowed

Screenshot:

image.png

Import does not validate whether or not there are duplicate client names

Steps to reproduce

  1. Use the export command to export the default client data
  2. Open the csv file and edit the second client's name to match the first client (Alex Yeoh)
  3. Use the import command to import the same csv file back into the app
  4. Use the list command to save the imported data

Expected result:

Throw an error to reject the imported data since there are two clients who share the same name, which would not have been allowed if the data was manually keyed in using the add command

Actual result

Invalid data is allowed to be imported

Screenshot:

image.png

Can add tags of the same name and different priority level

Steps to reproduce:

Use the command add n/Jackson p/92341888 e/[email protected] a/laney street, block 123, #01-01, i/package1 t/important t/important :p1 t/important :p2

Expected result:

Could have any of the 3 following responses

  1. Throw an error indicating that a client cannot have more than 1 tag with a particular name
  2. Accept only the first input when there are duplicate tag inputs
  3. Accept only the last input when there are duplicate tag inputs

Actual result:

All duplicate tags are added to the client, which can be confusing as the client can have the same tag multiple times and all with different priority levels

Screenshot:

image.png

No legend for tag priority level within the app itself

Steps to reproduce:

  1. Use the command add n/Jason p/92341888 e/[email protected] a/laney street, block 123, #01-01, i/package1 t/important

  2. Use the command add n/Jackson p/92341888 e/[email protected] a/laney street, block 123, #01-01, i/package1 t/important :p1

Expected result:

UI should indicate to me which color corresponds to which priority level

Actual result:

No indication of what priority level each color represents, have to refer to UG. This can be frustrating for beginner users.

Screenshot:

image.png

Format for package related commands could be clearer

The formats provided under the Package related commands section are as follows:

  1. addp i/PACKAGE_NAME d/PACKAGE_DESC
  2. editp i/PACKAGE_NAME d/PACKAGE_DESC

In every other section of the UG, the formats are all clearly spelled out in full. However, in this section, PACKAGE_DESCRIPTION has been shortened to PACKAGE_DESC, which can be confusing especially for beginner users as it is not immediately clear what DESC is short for.

It would be good for clarity if PACKAGE_DESCRIPTION was also spelled out in full like the rest of the UG.

Find command is allowed even if client list is empty

Steps to reproduce:

  1. Use the clear command
  2. Use the command find n/Jackson

Expected result:

Throw an error indicating client list is empty so there is no client to find

Actual result:

Find command successfully executes

Screenshot:

image.png

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.