"cli.py sync" crashes on comparing 'str' and 'int' for versionCode about magisk-modules-repo-util HOT 6 CLOSED

@IzzySoft , this has been resolved, no longer using is_relative_to

from magisk-modules-repo-util.

AttributeError: 'PosixPath' object has no attribute 'is_relative_to'

• pathlib.PurePath.is_relative_to was added in version 3.9.

from magisk-modules-repo-util.

Well, then we have an issue there: many LTS systems (like mine) are having 3.8 still and no easy upgrade path. Can't you use a different implementation? TBH, I don't even see the reason for that check there:

1. you establish the path for the downloaded file based on module_path, i.e. inside it:
   module_folder.joinpath(online_module.changelog_filename)
2. you send it to that method, which then checks whether the new path is inside module_path:
   if not (file.is_relative_to(module_folder))
   – where else should it be if you explicitly created it inside?

So why not reducing if not (file.is_relative_to(module_folder) and file.exists()): to just if not file.exists()? Or, if you insist, how about this:

if not (file.parents[1] == module_folder and file.exists()):

I've just verified: PosixPath.parents is available in Python 3.8. And that would do the job fine, as the downloaded file must reside in <module_path>/<module_id>/. It's even more precise, as any other location (e.g. directly in module_path, or more than one level deeper) would be wrong, without file.is_relative_to() detecting that.

Any chance for an adjustment here, @ya0211?

from magisk-modules-repo-util.

Thanks! I'll update ASAP (just performed a git pull so I have the current code here already, will test later). Hopefully that was the last "culprit".

Just for info: I (hopefully) finished updating my framework last night. Still needs some testing, but I'm confident to be "back to normal" on the weekend. The only open question remaining is what happened to cli.py sync --remove-unused, and what replaced it. Can you tell me, please?

from magisk-modules-repo-util.

cli.py sync --remove-unused has been removed because it is useless and unnecessary.

from magisk-modules-repo-util.

Thanks for confirming! I'll then remove it from my framework as well (admitting I cannot remember ever having used it).

from magisk-modules-repo-util.