Comments (4)
SanmerDev
commented on September 27, 2024
1
According to Magisk Developer Guides, there will be no comments here, just remove the trailing comma, use regular expressions to match and replace it.
from magisk-modules-repo-util.
SanmerDev
commented on September 27, 2024
If only this one error, I think we don't have to import json5 yet (I will try other methods first).
from magisk-modules-repo-util.
IzzySoft
commented on September 27, 2024
Fine with me, thanks! The linked SO Q&A has several alternative approaches as well. And I don't know what other improvements json5 might hold, or if it could cause other complications – so I leave this entirely to you.
from magisk-modules-repo-util.
IzzySoft
commented on September 27, 2024
Thanks, works fine – just verified against the above "example mod". Now it would be nice if the ZIP retained its date as well (you have the timestamp in track.json fine as last_update, so maybe touch the ZIP with that?)
from magisk-modules-repo-util.
Related Issues (20)
- quoted versionCode in update.json causes ValueError HOT 13
- sync improvements
- improve handling of logging for disappeared sources
- (temporarily) disable updates for a module
- Questions on updating modules HOT 17
- Bug with updating from GIT HOT 4
- Some modules are updated on each scan despite not having been changed HOT 2
- adjust timestamps when building from git-clone HOT 4
- field names in modules.json HOT 4
- Sources downloaded from the releases page are just crashing HOT 1
- cli.py sync crashes HOT 1
- [FR] Add a check for `max_num` HOT 4
- "cli.py sync" crashes on comparing 'str' and 'int' for versionCode HOT 6
- TypeError: Object of type PosixPath is not JSON serializable HOT 1
- last_update vs last_build HOT 23
- fields in track.json
- Inverted versions array field HOT 1
- Problem with ghproxy in zipUrl HOT 4
- cli.py sync exits with returncode 1 without telling why
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magisk-modules-repo-util.