Comments (4)
Yes, full ack to that. I just try to evaluate possibilities. Looking from the users' perspective, this is technically correct – but if the client maintainer cannot "quickly implement" it – and MRepo lacks some functionality they need which "the other" has… I could e.g. have my magisk-repo class export a modules.json
in the format used by other clients, to mitigate for a while. But yes, that could lead to either not working anyway (different ZIP than expected) – or to the maintainers of those other clients to see no urgency 🤷♂️
That said, it would be nice to have a (base) standard to agree upon. But if that's not possible, we'll have to accept that. I lack the deep insight to tell or argue here, so I'll accept your decision 😄
from magisk-modules-repo-util.
Since there never was an official json format
, I uses a scheme which I like, I don't think modules.json of the Magisk-Alt-Repo is a good choice, the zip they use is not a real magisk module.
from magisk-modules-repo-util.
OK, thanks! So you think even if we made the format of the JSON "compatible", it won't work anyway (as we'd ship a "real module" in the ZIP)?
from magisk-modules-repo-util.
It shouldn't be up to repositories to adapt clients, this should be done by clients.
from magisk-modules-repo-util.
Related Issues (20)
- trailing commas in update.json cause JSONDecodeError HOT 4
- quoted versionCode in update.json causes ValueError HOT 13
- sync improvements
- improve handling of logging for disappeared sources
- (temporarily) disable updates for a module
- Questions on updating modules HOT 17
- Bug with updating from GIT HOT 4
- Some modules are updated on each scan despite not having been changed HOT 2
- adjust timestamps when building from git-clone HOT 4
- Sources downloaded from the releases page are just crashing HOT 1
- cli.py sync crashes HOT 1
- [FR] Add a check for `max_num` HOT 4
- "cli.py sync" crashes on comparing 'str' and 'int' for versionCode HOT 6
- TypeError: Object of type PosixPath is not JSON serializable HOT 1
- last_update vs last_build HOT 23
- fields in track.json
- Inverted versions array field HOT 1
- Problem with ghproxy in zipUrl HOT 4
- cli.py sync exits with returncode 1 without telling why
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magisk-modules-repo-util.