mohrm / umklapp_site Goto Github PK

At the moment, every user can see the finished story. This may not be what the participating users want. So, the suggestion is to keep the finished story unpublished until explicit action is taken.

Ideas:

• startUser can publish
• someone can express desire to publish and story is published if everyone/the majority agrees
• anyone can publish

If I click on an unfinished story, I see a text indicating whose turn it is and a button / link labeled "Geschichte verlassen". Since it's not my turn and this is the only thing I can do, I may think that this button / link just brings me back to the overview page and does not do anything else (like "diese Seite verlassen"). We should add a " back" button / link, so that it is made clear that "Geschichte verlassen" is something different.

When clicking "Passwort vergessen?" and requesting the password reset instructions it says you get an email. However, it seems the mail never gets sent.

Currently, the owner/creator of a story is the single authority over publication.

Everybody who participated should have to agree, before a story is published.

@nomeata did something break with your clean-up-urls-commit?

After a teller entered his part, show him what he has written and ask him to confirm or edit again. This way, we would have much less incomplete story parts...

If a user has left a story, they can re-enter it without invitation, just by pressing a button.

In particular the mobile users cannot see the tooltip and therefore do not get any information about the meaning of the symbols. Partly the symbols are not very self-explanatory (what is the connection between sunglasses and publishing?), so let's add some short explanations.

Why not

• give more points for contributions to bigger stories (more parts, more participants)
• punish leaving a story

This would make point-farming harder and promote stories with more people involved, but not too many...

I think it would be nice to directly see in which of the finished stories I have participated. Therefore highlighting those or even splitting the list of finished stories into separate categories "Meine beendete Geschichten" and "Andere beendete Geschichten" would help to bring more structure into the list.

At the moment, the following is displayed:

Erforderlich. 30 Zeichen oder weniger. Nur alphanumerische Zeichen (Buchstaben, Ziffern und @/./+/-/_) sind erlaubt.

Non-geeky german users do not get that äöüß do not fall under the category 'alphanumerische Zeichen'. I would really like to clarify that. But how can I modify this help text?

It has to be the total number of tellers which contributed at least one part, not the number of tellers which have not left at the end of the story...

At least on a small (mobile) screen I do not see them anymore. Was that intentional?

Currently only the story creator can see which of the stories he started are publicly available (and he can only see that, if he is reading the story). It would be nice, if everybody who participated can see, if his/her story is publicly available.

At the moment, you can see the (other) contributors to a story if you hover over a story part with your mouse. This is bad for mobile users.

Why not show the contributors to the left of a story in a timeline-like fashion?

since a user cannot see stories which he/she is not a participant of, he/she has to be invited
Either by the start user or by the one whose turn it is

Possible "highscores":

• how many stories are waiting for which user
• how many stories did which user create
• how many outstanding skip votes has which user/story

It does not make sense to put all of this on the overview page, but we have enough data that it becomes interesting to show this data.

This can be used to show the password change function (see issue #40).
We can also present that user's statistics (parts written, stories participated in, stories started, ...) there.

Sometimes, in a story you want to tell a substory - like, for example, when you want to add some context to a character. Or someone in the story tells another story.
Wouldn't it be really cool for umklapp to support such sub-stories? I imagine something like the following:

• a teller can choose to start a new sub-story
• following users will then see the part just before the sub-story and the last part of the sub-story. They can then either continue the sub-story, or again start a sub-story, or finish the sub-story.
• if a sub-story is finished, the next teller does not see only the last sentence of it, but the whole sub-story.
• a story can only be finished if all sub-stories are finished

Currently, the only way for users to change their password seems to be abusing the password reset feature.

This way, the most recent stories are always on top.

We have a pleathora of new features now but most of the new features are untested. So we need to add more tests. A code coverage tool could help to uncover untested code.

in particular not that the system is waiting for continuation

Sometimes I got
7 nomeata 18
8 Cici 18
9 mheck01 18

and later:
7 mheck01 18
8 nomeata 18
9 Cici 18

I also think they should all receive the same position (not showing a position for all except the first one).

Currently, it silently cuts of the sentence.

Either, the author should be warned in time or the limit should effectively not exist.

Examples in Thor: "Fi • rewall" and "Felsvo • gel"

in particular: make 'continue' link a button(?)

More precisely: There have to be more than two tellers initially for auto-finishing to happen. Otherwise, we would essentially forbid stories with only two tellers (they don't make much sense but this is not sufficient for forbidding)

Like @ratefuchs suggested in issue #62, this page could provide infos about how the game works and also links to the github repo.

I think it'd be cool if one could add additional rules while creating a story. What I have in mind is just an additional textbox that is visible to all contributors of the story. What do you think?

Now that travis automatically deploys on openshift, I do not know anymore which commit is live...

For example, on Firefox 46 in Windows, if the browser window is maximized, the user selection list on story creation expands to the top. We now have a bunch of users, which means that you cannot see the 'select all'/'select none' links.

user should see how many rounds / contributions a story consists of so far

We have „Mich einmal überspringen“ and „Nicht mehr mitschreiben“. Semantically, the latter is just „Skip me always“, isn’t it? Maybe we should name it this way, for a simpler UI model.

It might be a nice feature if finished stories that a user has not read yet are highlighted. This would help in identifying newly finished stories if the finished story list gets too long.

this may mean that the story has to be finished if there would be only one participant left

Since 2e48721 there is a test which checks for the number of queries in the overview and it takes a lot more time than the other tests.

I want my tests to run fast.

Maybe we should split this into correctness and performance tests?

The overview page could be reduced to unread finished stories.

I think the clickable area of the logout button should cover only the text "Abmelden" plus a bit of margin. At the moment the button reaches too far to the left and right such that the whole button is around 3 times the size it should be.

See the mousepointer in this screenshot:

Imagine the following scenario:

1. Open '/' (overview)
2. Wait for half a minute
3. Click on one of the finished stories
4. After reading click the browser's back button

After step 4. one would expect to see the same site as just before step 3.
Instead one gets just the content of the <div id="content"> without any style sheet information or other surrounding data.

I guess this issue stems from the fact, that the call to jQuery.get in startRefresh uses the same url as the overview site itself. However when requested via ajax only the <div> container is transferred. Therefore confusing the browsers cache of the site.

• Users should be able to say that they are unavailable (for an unspecified amount of time).
• Unavailable users should always be skipped.
• Stories, in which all but one participant are unavailable should be finished immediately.
• I am not quite sure whether unavailable users should be invitable to new stories. If yes, then the user could participate in the story when they are back and would not be excluded from the community. On the other hand, this could complicate the logic and the exclusion problem would be gone, once we have implemented #7

What do you think?

Similar as issue #60 the list of running stories could be trimmed to those, where you can do something.

I already made a /running page for the full list in b0f22bf. The hard part is excluding stories in the query. We currently filter in Python.

If a single teller delays a story, the others should be able to vote.

Implementation on branch skipvote, but it resulted in "Internal Server Error". Needs error log powers of @mohrm