minvws / nl-covid19-coronacheck-app-ios Goto Github PK
View Code? Open in Web Editor NEWLicense: European Union Public License 1.2
License: European Union Public License 1.2
Upon opening the app on my IOS14.7 device, the coronacheck.app warns:
Security risks were found, your device is jailbroken.
Does it search for certain files or running ps/daemons?
IOS 14.7 is not jailbreakable at the moment, so I was wondering how it thinks it is?
In the international section of the app, my app shows both on the overview and the QR-code “scroller” that I have 3/1 vaccinations. This is also reflected in international the QR-code and seen by other international scanners.
Steps to reproduce the behavior:
The app shows 1/3, 2/3 and 3/3 for the vaccinations.
Smartphone (please complete the following information):
Add any other context about the problem here.
See title, the little bike takes few seconds to start moving on national QR code, and pauses between loops
Same as international QR code: always have some movement (multiple people on the conveyor belt). don't loop with a break in between. Or have multiple bikes that loop along the screen instead of one with a start/stop motion.
N/A.
This has the potential to undermine the security of the app. The scanner app is fast enough that there could not be any movement during the 'scanning' period and bouncer might not have time to observe the movement as they're checking IDs.
Not as much of an issue on Android as screenshots aren't as easily made.
The app currently shows 1/1 vaccinations after retrieving two vaccinations if a certificate of recovery is also present. This will certainly cause problems with countries that require two vaccinations even if recovered, e.g. UK. This is new behaviour introduced (I guess) some time in the past week or so.
E.g.
Steps to reproduce the behavior:
I expect the vaccination certificate to always show the exact amount of doses received (and retrieved from GGD/RIVM), regardless of any other information being available. I.e., if two (or three with a booster) shots were received the app should always show that amount. The only time information on recovery should be used is if a single shot was received.
n/a
Smartphone (please complete the following information):
I switched phones this week and the old phone still shows 2/2 from a certificate retrieved before this week.
Dear developers,
It has come to my attention that the Corona check app uses client side date validation. This seems to be an oversight!
Use case:
I have my second shot, on July 30th, the app recognizes this and tells met it will be 13 days until my Dutch certificate becomes valid. I change my local phone time to 15th of August, and voila, the app displays a (valid?) code.
Please fix.
Ik was de code aan het lezen, ik zag in Sources/CTR/Infrastructure/Services/WallerManager.swift deze regel (nu regel 250):
for case let greenCard as GreenCard in greenCrards.allObjects {
Ik begreep niet helemaal hoe je dit zou kunnen compileren met de 'greenCrards' tikfout. Maar ik zie dat dit ook al in de regel daarvoor misgetikt is:
if let greenCrards = wallet.greenCards {
for case let greenCard as GreenCard in greenCrards.allObjects {
...
}
}
Zo is het dus een wat vreemde maar verder onschuldige tikfout.
Implementation of the PassKit API to add your QR to Apple Wallet would be a great addition.
Input ICTRecht tijdelijke wet testbewijzen covid-19 12032021.pdf
Please find the (dutch) opinion article about an improvement to the coronacheckapp to support large venues and their organisers. This case is about AFC Ajax NV / Johan Cruijff Arena, but multiple large event-organisers and ticket-companies would be able to support this flow.
Our stadium is ready for 55.000 fans, the current coronacheck-app lacks integration with the organiser and fans.
In the current proposal it would require us to employ at least 250 (untested) extra stewards to manually scan-and-verify all credentials. Also if credentials don't match or no test is done the fan will only find out at the location, we think that should be much more in advance to prevent unnecessary travel.
Our concrete request is support "universal links" for the coronacheck app (i.e like "Idin" and "Ideal").
fan-flow:
This way is in our opinion according to all privacy laws and this principle has been tested up to 12K fans during the start of the season with 5 matches (only corona questions instead of coronacheck app).
See title. If there's already a certificate in the app, adding a paper certificate seems to work but nothing happens (i.e. it is not stored).
Steps to reproduce the behavior:
One of two things: either an error message stating there's already a certificate installed, or a question asking if it should be overriden.
Of course it'd be perfect if the app would support multiple certificates but this is on the roadmap IIRC.
N/A
Smartphone (please complete the following information):
Workaround: delete app, reinstall and then scanning works fine.
The same URL scheme is used for all app packages (Acc, Prod, Test, App Store, Debug, Release): coronatester-app-dev
I would expect different URL schemes for different app packages.
When using the same URL scheme for different app packages, the latest installed app will be the one registered to that URL scheme. Furthermore, the '-dev' suffix seems to indicate it should not be used for production. And it is (when installing the CoronaCheck app version 1.1.3 through the App Store, then coronatester-app-dev:// opens the app).
My suggestion is to generate the plist files based on a template plist file. From the template file a file is generated for each specific package, when that package is built. This can be for example done by replacing a template value.
This approach can be reused in the future for other plist entries that need to be differentiated between different packages.
I can create a pull request with this behaviour, please let me know if this would contribute to the project.
The app hides the QR codes for three minutes after a screenshot is taken. This is presumably because the NL codes change every so often (3 minutes?) to prevent fraud with these codes. This is fine.
However, the app also hides the international QR codes, even though those do not change, or at least not as rapidly as the NL codes, which makes the 3 minute lockout period a nuisance. Additionally, the app informs you that "a screenshot is not a valid certificate" which in the case of the international codes is patently false as no requirement is made for the certificate to be presented in an app by (EU) 2021/953.
The reason this is a nuisance is that some countries are now requiring that QR-codes be uploaded to a system before travel to that country is authorised. For example, Singapore requires this as part of their Vaccinated Travel Lane program, where you get a travel authorisation from their system before you are able to board by uploading the QR code along with some other personal details ahead of time. This can be done in the form of a screenshot from your respective DCC app, but the Dutch CoronaCheck App frustrates this process by unnecessarily hiding the codes after a screenshot is made.
Steps to reproduce the behavior:
I expect the NL code to be hidden as a fraud prevention measure. I do not expect the international code to be hidden.
Smartphone (please complete the following information):
I don't own an Android phone but as I understand it, on Android creating a screenshot is entirely prevented and the mechanism of hiding on iOS is done because iOS does not offer the ability to prevent screenshots from being taken. The same applies: international codes should be screenshot-able.
After updating to version 2.7.0, the details button of the Dutch QR code screen is not working.
If you press on the details button, it will have the "pressed state". But no detail screen appears.
Note: the international QR code details button does work.
Details:
When you get 1 dose in the hospital and one dose by the GGD the international qr code says 1/1 dose instead of 2/2.
E.g.
Steps to reproduce the behavior:
Since mijn.rivm is having 2 vaccination the international qr code should represent both doses.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Tried uninstalling and reinstalling app.
It really is 2565 in thailand, so that is correct. However this confuses ANY european user.(in my case the german restaurant i sat down in) The data should ALWAYS be in european date format DD-MM-YYYY
E.g.
Steps to reproduce the behavior:
All dates should be in european format. (android is ok)
Currently CoronaCheck version 2.1.0, 2.1.1 and 2.1.3 are rolled out through the App Store, but not yet available in this GitHub repo. This undermines the open-source principals. Source code should be made first available on GitHub, before pushing to Apple and rolling out, so that it can be independently checked.
Ping @Rool @iandundas
'Add certificate' in CoronaCheck app doesn't work when the default browser is other than Safari.
Steps to reproduce:
Worked around this by temporarily switching Safari to be the default browser, but I expect the app to work with Edge browser as well. Later switched default browser back to Edge Canary, and no issue is observed in showing certificates that are already there. So only with adding a certificate.
Observed on iPhone 11 Pro, software version 14.6, default Edge Canary browser version 93.0.953.0 (also observed by others with default Edge Dev browser)
Please review as CoronaCheck app on iPhone is eligible for improvement.
Thank you and kind regards, inge
To integrate with other apps, please add deeplinking so it is possible to open the CoronaCheck app on a certain screen from another app or from a webpage. For example:
coronacheck://makeappointment to open the app on the 'Make appointment' screen
coronacheck://createqr to open the app on the 'create QR' screen
coronacheck://showqr to open the app on the the screen that shows the QR
Or:
coronacheck://createorshowqr which shows the create QR if none was created, or if already created it shows the QR code directly. If there are multiple QRs available (is that possible?), then show a selection screen.
Registering a domain would improve the user experience even more (this can be done for both iOS and Android). For example when https://downloadcoronacheckapp.rijksoverheid.nl/ is registered, it is possible to create the behaviour that when URL is visited on a phone that doesn't have the app installed, it will redirect to the download page. When the app is installed, visiting this url will open the app.
Our product (http://www.thecloseapp.com) is the communication platform between the organizers and the visitors of the FieldLab events. We send instructions to visitors where to download and install the Corona Check app and when to open and show the QR code. The user experience would be greatly improved if we could link directly to screens in the app. This improves the conversion to the Corona Check app, makes it easier to use for visitors of the FieldLab event and thus makes it less error prone for visitors to use.
While adding a vaccination certificate the "completionreason" is displayed, however this label is not shown in the details page of the DCC (International QR).
In cases where the first series was completed by 1 dose mRNA Pfizer after a corona recovery the completion reason is given by string holder_eventdetails_vaccinationStatus_recovery ("ja (eerder corona gehad)" / "yes (I’ve had coronavirus earlier)") when adding the vaccination certificate. After adding both this certificate and the booster one the "Dose %@/%@" label is given as "1/1" on the first certificate and "2/1" on the second certificate, which is to be expected.
However, this causes issues outside the Netherlands, primarily in Germany, as the DCC page does not include a reference to a 3rd dose in this case, which most people expect to look for and thus will often reject a "2/1" labeled certificate where boosters are mandatory (e.g. 2G+). In order to solve this confusion it would be helpful to be able to open the details and show that this is due to only receiving 1 dose the first time. As far as I'm aware (one of) the German App does indicate this when displaying the DCC.
holder.event.about.vaccination.completionreason and holder_eventdetails_vaccinationStatus_recovery labels shown in DCC vaccination details when applicable (e.g. earlier corona recovery + 1 Pfizer dose + optionally booster)
Just installed and opened the app, and it keeps spinning saying "we'r starting the app". And after some seconds it tells me I'm not connected to the internet
I would expect the app to handle better the check over connectivity.
Desktop (please complete the following information):
Smartphone (please complete the following information):
I opened the app while being in Italy.
For which there is no issue tracker.. Neither for the DCC Scanner, for border patrol.
Example leaked EU DCC QR code: https://github.com/ehn-dcc-development/hcert-spec/discussions/105#discussioncomment-1591595
Already reported it here about a week ago: https://twitter.com/henkpoley/status/1457713831514451972?s=21
Since the list is dynamically downloaded, I suppose that report never really went anywhere (going back to, no public issue tracker).
I'm running into issues building and I suspect more people will run into this. A short readme.md should prevent this. The issue I see is an error during compilation: No such module 'Clcore'
I am running into issues during the build. Steps I followed:
sudo bundle install
pod intall
Then opening CTR.xcworkspace using Xcode 12.4. When compiling (for both for Simulator and a real device) I get a 'No such module 'Clcore'
I would expect a short readme explaining the requirements, dependencies and steps to take to build.
If you don't have a valid QR yet, for example, it has been 4 days since your 2nd vaccination it currently shows that the QR will become on x date. But if you change the time to the future in your phone's settings, the view QR button becomes clickable and you can see the QR code.
Steps to reproduce the behavior:
The code should not be available.
Note, this is NOT my phone. I already have a valid QR. Nor is the person abusing this app's behaviour.
Smartphone (please complete the following information):
A way to fix this issue. Is connect to the API and ask what time it is over there instead of relying on the local time of the device.
I've received two vaccinations via GGD and see them twice in the app (RIVM + GGD).
When comparing the vaccination details with coronacheck.nl, data seems to be missing or inconsistent in the iOS app. Also within the app, data is incosistent between the vaccination details and the International QR Code details.
Steps to reproduce the behavior:
Desktop (please complete the following information):
Smartphone (please complete the following information):
Moved from #40 to a separate issue, since #40 got closed.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.