Giter Club home page Giter Club logo

Comments (19)

simi avatar simi commented on August 16, 2024

It is in latest version.

https://github.com/metaskills/less-rails-bootstrap/blob/v3.1.1.1/app/frameworks/twitter/bootstrap/grid.less#L30.

Can you fill missing informations from https://github.com/metaskills/less-rails-bootstrap/blob/master/ISSUES.md?

from less-rails-bootstrap.

 avatar commented on August 16, 2024

Versions:

Rails: 4.0.0
Ruby: 2.0.0p353
less-rails-bootstrap: (3.1.1.1)
less-rails: (~> 2.5.0)

I rechecked from the chrome's developer tools, I still don't see the .container-fluid loaded from the less-rails-bootstrap.

from less-rails-bootstrap.

simi avatar simi commented on August 16, 2024

Are you able to prepare some basic demo app?

from less-rails-bootstrap.

 avatar commented on August 16, 2024

Or, may be it's missing while creating the custom_bootstrap ?

from less-rails-bootstrap.

simi avatar simi commented on August 16, 2024

Maybe, you can paste it here. Do you have mixins included there?

from less-rails-bootstrap.

 avatar commented on August 16, 2024

By the way I regenerated custom_bootstrap. Yet no sign of .container-fluid.

custom_bootstrap.less

// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
// !!! AUTOMATICALLY GENERATED FILE. DO NOT MODIFY !!!
// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

// Core variables and mixins
@import "twitter/bootstrap/variables.less";
@import "custom_bootstrap/variables.less"; // Modify this for custom colors, font-sizes, etc
@import "twitter/bootstrap/mixins.less";
@import "custom_bootstrap/mixins.less"; // Modify this for custom mixins

// Reset
@import "twitter/bootstrap/normalize.less";
@import "twitter/bootstrap/print.less";

// Core CSS
@import "twitter/bootstrap/scaffolding.less";
@import "twitter/bootstrap/type.less";
@import "twitter/bootstrap/code.less";
@import "twitter/bootstrap/grid.less";
@import "twitter/bootstrap/tables.less";
@import "twitter/bootstrap/forms.less";
@import "twitter/bootstrap/buttons.less";

// Components
@import "twitter/bootstrap/component-animations.less";
@import "twitter/bootstrap/glyphicons.less";
@import "twitter/bootstrap/dropdowns.less";
@import "twitter/bootstrap/button-groups.less";
@import "twitter/bootstrap/input-groups.less";
@import "twitter/bootstrap/navs.less";
@import "twitter/bootstrap/navbar.less";
@import "twitter/bootstrap/breadcrumbs.less";
@import "twitter/bootstrap/pagination.less";
@import "twitter/bootstrap/pager.less";
@import "twitter/bootstrap/labels.less";
@import "twitter/bootstrap/badges.less";
@import "twitter/bootstrap/jumbotron.less";
@import "twitter/bootstrap/thumbnails.less";
@import "twitter/bootstrap/alerts.less";
@import "twitter/bootstrap/progress-bars.less";
@import "twitter/bootstrap/media.less";
@import "twitter/bootstrap/list-group.less";
@import "twitter/bootstrap/panels.less";
@import "twitter/bootstrap/wells.less";
@import "twitter/bootstrap/close.less";

// Components w/ JavaScript
@import "twitter/bootstrap/modals.less";
@import "twitter/bootstrap/tooltip.less";
@import "twitter/bootstrap/popovers.less";
@import "twitter/bootstrap/carousel.less";

// Utility classes
@import "twitter/bootstrap/utilities.less";
@import "twitter/bootstrap/responsive-utilities.less";

from less-rails-bootstrap.

 avatar commented on August 16, 2024

@simi I tried to open grid.less and as mentioned by you .container-fluid is present on line 30.

from less-rails-bootstrap.

simi avatar simi commented on August 16, 2024

And yours application.css?

from less-rails-bootstrap.

 avatar commented on August 16, 2024

application.css

/*
 * This is a manifest file that'll be compiled into application.css, which will include all the files
 * listed below.
 *
 * Any CSS and SCSS file within this directory, lib/assets/stylesheets, vendor/assets/stylesheets,
 * or vendor/assets/stylesheets of plugins, if any, can be referenced here using a relative path.
 *
 * You're free to add application-wide styles to this file and they'll appear at the top of the
 * compiled file, but it's generally better to create a new file per style scope.
 *
 *= require_self
 *= require custom_bootstrap/custom_bootstrap
 *= require custom_bootstrap/variables
 *= require custom_bootstrap/mixins
 *= require font-awesome
 *= require custom.css
 *= require header.css
 *= require footer.css
 */

from less-rails-bootstrap.

simi avatar simi commented on August 16, 2024

And can you reach any other TWBS features?

from less-rails-bootstrap.

 avatar commented on August 16, 2024

Yeap, Everything else works as intended

from less-rails-bootstrap.

maxd avatar maxd commented on August 16, 2024

I rechecked from the chrome's developer tools, I still don't see the .container-fluid loaded from the less-rails-bootstrap.

How do you check this?

Can you open 'application.css' in Chrome Developer Tool (or download use wget) and try to find container-fluid inside response body?

from less-rails-bootstrap.

 avatar commented on August 16, 2024

@maxd you can have a look at entire .css here https://gist.github.com/ajjublr/9911621 (custom_bootstrap.css)

Can't find .container-fluid in this.

Also I know this file is compiled properly by searching #336699, which I have changed in variables.less @brand-primary: #336699;

from less-rails-bootstrap.

maxd avatar maxd commented on August 16, 2024

I don't think that this file was compiled properly with TB 3.1.1 because it has comment:

/*! normalize.css v2.1.3 | MIT License | git.io/normalize */

but TB 3.1.1 has comment:

/*! normalize.css v3.0.0 | MIT License | git.io/normalize */

So, I think your application cached old version of custom_bootstrap.css.

As I understand you have this problem in development environment. Right? So, do these things:

  1. Remove 'assets' directory from 'public' directory if it exists
  2. Run rake tmp:clear for clear cache
  3. Check settings related to caching inside 'environments/development.rb'. Cache should be disabled in development environment. For any case can you publish this file too?

Restart app.

from less-rails-bootstrap.

 avatar commented on August 16, 2024

Perfect !!

Yeap that was a cache problem... Thanks !!

Now i get
/*! normalize.css v3.0.0 | MIT License | git.io/normalize */

development.rb

Myapp::Application.configure do

Settings specified here will take precedence over those in config/application.rb.

In the development environment your application's code is reloaded on

every request. This slows down response time but is perfect for development

since you don't have to restart the web server when you make code changes.

config.cache_classes = false

Do not eager load code on boot.

config.eager_load = false

Show full error reports and disable caching.

config.consider_all_requests_local = true
config.action_controller.perform_caching = false

Don't care if the mailer can't send.

config.action_mailer.raise_delivery_errors = false

Print deprecation notices to the Rails logger.

config.active_support.deprecation = :log

Raise an error on page load if there are pending migrations

config.active_record.migration_error = :page_load

Debug mode disables concatenation and preprocessing of assets.

This option may cause significant delays in view rendering with a large

number of complex assets.

config.assets.debug = true

config.action_mailer.default_url_options = { :host => 'localhost:3000' }
end

from less-rails-bootstrap.

maxd avatar maxd commented on August 16, 2024

As I understand the 'config.action_controller.perform_caching' was enabled. Right?

from less-rails-bootstrap.

 avatar commented on August 16, 2024

Nope, It wasn't... that's the actual file. I have pasted without changing it...

from less-rails-bootstrap.

simi avatar simi commented on August 16, 2024

It is cool to see this issue closed. GJ @maxd.
Also thanks @ajjublr. Thanks to this issue, I found a problem in future releases. #111

Let's celebrate it:
jfa9lbr

from less-rails-bootstrap.

 avatar commented on August 16, 2024

;) pleasure is mine. It wasn't the less-rails-bootstrap issue at all 👍

from less-rails-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.