melshyrule / mels-twitter Goto Github PK

This is the feedback guide for Assignment 4 - Twitter.

• Did you minimize the number of public functions and properties in your classes? You should always try to minimize the number of properties and functions that are public or internal. This is a coding best practice.
• Is your TweetsViewController generic enough that it can be reused to display tweets from other Twitter endpoints? A view controller that displays a list of tweets is the type of view controller that you want to make generic enough that it can be used in multiple places throughout an app. This particular TweetsViewController can come in handy for displaying the user's home timeline, but can also be reused for displaying a list of tweets that mention the particular user, showing another user's timeline, etc.
• Did you properly handle the conditionally present label "retweeted by..." in your custom TweetCell? You'll notice that for some tweets you'll need to display the "retweeted by..." label and have this hidden for other tweets. You'll want to create an outlet for a top margin AutoLayout constraint and modify the constant depending on whether you want to show the label or not.
• Did you create a model class for both Tweets and Users? Having model classes for both Tweets and Users and being able to initialize each one from a json dictionary makes it easier to handle the Twitter network response and turn it into model objects that can be reused throughout your app. It's also a good idea to check out libraries like Mantle which reduce the boilerplate code you need to implement these model classes.
• Did you properly format the timestamp of each Tweet? You'll notice that in the actual Twitter app the timestamps for each tweet are presented in a friendly format (i.e. "10m", "1h", etc). Since this isn't how the timestamp is returned from the server, you'll need to do the conversion yourself. DateTools is a handy Cocoa Pod that does this for you.
• Did you handle reply/retweet/favorite actions from within the TweetCell? This is an example where it's useful for your model to be able to handle network actions, so you can simply wire up the buttons to a method like [tweet retweet]. You can even pass in an optional block if you want to handle a failure of the network event.
• Did you immediately update the retweet and favorite counts when a user retweets or favorites a tweet? It's common practice when building an app to have actions like favoriting a tweet assume success and ignore any failures. This gives the user an immediate response to his/her action without having to wait for a network response.
• In your ComposeViewController, did you pass back the Tweet after it was successfully created? This will allow you to locally insert newly created tweets so you don't have to do a network refresh to see the new tweets.
• Did you share code between your ProfileViewController and TimelineViewController? The ProfileViewController and the TimelineViewController both contain a feed of tweets. There are three general strategies: you can have a single view controller that conditionally has the profile header, you can create the ProfileViewController as a subclass of the TimelineViewController, or you can create a separate class called a TimelineController (not a view controller). TimelineController is a dataSource and a delegate to a UITableView and knows how to show a feed of tweets.
• Each Storyboard scene should have Auto Layout constraints specified for each view. There should be no yellow Auto Layout warnings, even if the layout seems to work. Auto Layout warnings are like having bad HTML. The browser will try to render it, and it might even look right, but it won't be fully predictable.
• Did you implement the blurred table view header on the profile screen? This can be implemented in several ways. You can implement it as a table header, a section header, or a cell. My preferred approach is to implement it as a table header, it's the easiest way to flow the image above the content.