mdstcl - dir/full segfault about mdsplus HOT 8 CLOSED

I was also able to reproduce the segfaults on Ubuntu20 with a recent build of alpha.

from mdsplus.

We have diagnosed this issue, and it is related to the compression method specification byte in the NCI introduced in 2021 (commit 7f0a492 ), looking at an initialized byte in the NCI. We have designed a fix, which is to add an optional DBI to specify if the compression method should be looked at, with a default of 'NO'. We have verified that since 22 years ago the Database information data structure has been initialized to zero: https://github.com/MDSplus/mdsplus/blame/263cc8bce631b291f17ae2c3e09164c55a067b93/treeshr/TreeOpen.c#L659

The plan is to have a working solution by the end of today, and a completed PR for this week (tomorrow or Thursday ?)

from mdsplus.

Glad you have a working theory and plan for resolution.

I don't see how 7f0a492 is related to the description of the bug "compression method specification byte in the NCI".

from mdsplus.

See edits to the original post, but appears to have been introduced in release alpha-7.134.13 which would be:
https://github.com/MDSplus/mdsplus/releases/tag/alpha_release-7-134-13

from mdsplus.

Thanks - this was mentioned above... There is a WIP PR #2647 that should address this

from mdsplus.

Hi @smithsp -- Regarding your question (~3 posts above), I believe the situation is as follows.

• commit 7f0a492 is the last version that did not have the bug
• commit 9829bf6 is the commit that introduced the bug (i.e., this is the commit Josh mentioned in the associated PR).

from mdsplus.

Thanks @mwinkel-dev . That makes more sense.

from mdsplus.

This is fixed by PR #2647

from mdsplus.