mdsplus8 has wrong node name sizes in tcl_directory.c about mdsplus HOT 1 OPEN

The Version 7 (and earlier) pattern does not apply to Version 8, because of an important difference in the node name definitions.

• Version 8 defines a node name to be a 64 character array that always includes a null char terminator (thus a maximum of 63 visible characters).
• Pre-v8 defined a node name as an array of 12 visible characters and an optional null terminator. Meaning that node name, A234567890B2, was stored without a trailing null. Shorter node names, such as XYZ, were stored with null characters filling the rest of the node name array.

The optional null character in v7 and earlier, added some complexity to all code that processes node names. Reading used strncpy() to obtain the 12 characters from the node name field, and then appended a null terminator if needed. Thus the v7 code needs to be adjusted a bit for v8 which always has a null terminator.

A spot check of various portions of the v8 source code reveals that there are some places where the adjustments have not yet been made. Or that the adjustments were done slightly incorrectly. This typically results in an "off by one" error in the string length (e.g., dropping the 63rd visible character of a long node name).

from mdsplus.